From d56904388cb474250a784a4282261ec3c6a6f75f Mon Sep 17 00:00:00 2001 From: dev-12 Date: Fri, 3 Oct 2025 13:32:24 +0530 Subject: [PATCH 1/3] ci: ignore `UnusedQuantity` lint --- lint.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lint.xml b/lint.xml index 61366ae3..405e69b8 100644 --- a/lint.xml +++ b/lint.xml @@ -5,7 +5,8 @@ - + + -- GitLab From 91f0f48c5910d2a2ebc061d656b21bac193761e1 Mon Sep 17 00:00:00 2001 From: dev-12 Date: Tue, 30 Sep 2025 19:10:17 +0530 Subject: [PATCH 2/3] fix: migrate to standardize account removed callback from account manager --- app/src/main/AndroidManifest.xml | 9 ++++++--- .../account/receivers/AccountRemoveCallbackReceiver.java | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 922cf504..62ef9611 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -29,6 +29,7 @@ + - + android:permission="foundation.e.accountmanager.permission.ACCOUNT_EVENTS"> - + diff --git a/app/src/main/java/foundation/e/drive/account/receivers/AccountRemoveCallbackReceiver.java b/app/src/main/java/foundation/e/drive/account/receivers/AccountRemoveCallbackReceiver.java index c8f16a69..c24afac7 100644 --- a/app/src/main/java/foundation/e/drive/account/receivers/AccountRemoveCallbackReceiver.java +++ b/app/src/main/java/foundation/e/drive/account/receivers/AccountRemoveCallbackReceiver.java @@ -35,7 +35,7 @@ import timber.log.Timber; public class AccountRemoveCallbackReceiver extends BroadcastReceiver { - private static final String ACTION_ACCOUNT_REMOVED = "android.accounts.action.ACCOUNT_REMOVED"; + private static final String ACTION_ACCOUNT_REMOVED = "foundation.e.accountmanager.action.ACCOUNT_REMOVED"; @SuppressLint("UnsafeProtectedBroadcastReceiver") @Override -- GitLab From 3ba03b8fe15628175854a60782e6c6e2a4144bc0 Mon Sep 17 00:00:00 2001 From: dev-12 Date: Wed, 1 Oct 2025 11:50:33 +0530 Subject: [PATCH 3/3] fix: unify permission across account events. don't ignore exported security warning; account added is protected by permission now, it should not be possible to call it without proper permission --- app/src/main/AndroidManifest.xml | 4 +--- .../e/drive/account/receivers/AccountAddedReceiver.kt | 9 +++++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 62ef9611..a4b19720 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -28,7 +28,6 @@ tools:ignore="QueryAllPackagesPermission" /> - - + android:permission="foundation.e.accountmanager.permission.ACCOUNT_EVENTS"> diff --git a/app/src/main/java/foundation/e/drive/account/receivers/AccountAddedReceiver.kt b/app/src/main/java/foundation/e/drive/account/receivers/AccountAddedReceiver.kt index 7ed75c7a..fb8a751d 100644 --- a/app/src/main/java/foundation/e/drive/account/receivers/AccountAddedReceiver.kt +++ b/app/src/main/java/foundation/e/drive/account/receivers/AccountAddedReceiver.kt @@ -30,10 +30,19 @@ import timber.log.Timber * @author Vincent Bourgmayer */ class AccountAddedReceiver : BroadcastReceiver() { + + companion object { + const val ACTION_ACCOUNT_ADDED = "foundation.e.accountmanager.action.ACCOUNT_ADDED" + } + override fun onReceive(context: Context?, intent: Intent?) { Timber.d("\"Account added\" intent received") if (context == null || intent == null || intent.extras == null) return + if (intent.action != ACTION_ACCOUNT_ADDED) { + Timber.wtf("AccountAddedReceiver.onReceive is called without proper action") + return + } val extras = intent.extras!! val accountName = extras.getString(AccountManager.KEY_ACCOUNT_NAME, "") -- GitLab