Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c72b7ec5 authored by Vincent Bourgmayer's avatar Vincent Bourgmayer
Browse files

fix: apply's Sayantan suggestion: 

Remove useless test in a job & remove a useless comment on a variable
parent dc479ef4

.gitlab-ci.yml

+1 −11
Original line number Diff line number Diff line
@@ -3,7 +3,7 @@ image: "registry.gitlab.e.foundation/e/os/docker-android-apps-cicd:latest" 
variables:

  SENTRY_DSN: "${SENTRY_DSN}"

  APK_PATH: "app/build/outputs/apk/release"

  UNSIGNED_APK: "eDrive-release-unsigned.apk" # TODO: check if usage of * is working then update or remove this comment

  UNSIGNED_APK: "eDrive-release-unsigned.apk"

  COMMUNITY_APK: "eDrive-community.apk"

  OFFICIAL_APK: "eDrive-official.apk"
@@ -104,16 +104,6 @@ generate-apks: 
  before_script:

    - apt update && apt install apksigner -y

  script:

    - |

      if [[ -z $KEYSTORE ]]; then

        echo "KEYSTORE not set"

        exit 1

      fi

    - |

      if [[ -z $KEYSTORE_PASSWORD ]]; then

        echo "KEYSTORE_PASSWORD not set"

        exit 1

      fi

    - |

      ./systemAppsUpdateInfo/scripts/generate-apks.sh \

      "$APK_PATH" "$UNSIGNED_APK" "$COMMUNITY_APK" "$OFFICIAL_APK"