Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 54a6f129 authored by Vincent Bourgmayer's avatar Vincent Bourgmayer
Browse files

Fix UploadFileOperationTest.java 

- Add missing parameter for various constructor
- Remove first parameter of @Config(...)
parent 99b7f9d2

app/src/test/java/foundation/e/drive/operations/UploadFileOperationTest.java

+8 −11
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ import java.io.IOException; 
import java.util.ArrayList;

import java.util.List;



import foundation.e.drive.BuildConfig;

import foundation.e.drive.database.DbHelper;

import foundation.e.drive.models.SyncedFileState;

import foundation.e.drive.models.SyncedFolder;
@@ -35,7 +34,7 @@ import foundation.e.drive.utils.CommonUtils; 




@RunWith(RobolectricTestRunner.class)

@Config(constants = BuildConfig.class, sdk = Build.VERSION_CODES.O, manifest = Config.NONE)

@Config(sdk = Build.VERSION_CODES.O, manifest = Config.NONE)

public class UploadFileOperationTest {



    private List<SyncedFileState> syncedFileStates= new ArrayList<>();
@@ -105,7 +104,7 @@ public class UploadFileOperationTest { 
            Assert.fail(e.getMessage());

        }



        final SyncedFileState sfs = new SyncedFileState(-1, "dummy.txt", TestUtils.TEST_LOCAL_ROOT_FOLDER_PATH+"small/dummy.txt", TestUtils.TEST_REMOTE_ROOT_FOLDER_PATH+"small/dummy.txt",  "", 0l, 0, true);

        final SyncedFileState sfs = new SyncedFileState(-1, "dummy.txt", TestUtils.TEST_LOCAL_ROOT_FOLDER_PATH+"small/dummy.txt", TestUtils.TEST_REMOTE_ROOT_FOLDER_PATH+"small/dummy.txt",  "", 0l, 0, true, 3);

        sfs.setId(DbHelper.manageSyncedFileStateDB(sfs, "INSERT", RuntimeEnvironment.application));



        syncedFileStates.add(sfs);
@@ -161,8 +160,7 @@ public class UploadFileOperationTest { 




        boolean checkEtag = false;

        UploadFileOperation testOperation = new UploadFileOperation(syncedFileStates.get(0));

        testOperation.setContext(RuntimeEnvironment.application); //Without it, it won't update database

        UploadFileOperation testOperation = new UploadFileOperation(syncedFileStates.get(0), RuntimeEnvironment.application);



        RemoteOperationResult result = testOperation.execute(client);

        String errorMsg = "The upload failed:\n http code: "+result.getHttpCode()
@@ -192,8 +190,7 @@ public class UploadFileOperationTest { 
        SyncedFileState syncedFileState = null;

        //Test fails at the moment because of UploadFileOperation's constructor not checking for syncedFileState is null)

        // check https://gitlab.e.foundation/e/apps/eDrive/-/issues/120

        UploadFileOperation testOperation = new UploadFileOperation(syncedFileState);

        testOperation.setContext(RuntimeEnvironment.application);

        UploadFileOperation testOperation = new UploadFileOperation(syncedFileState, RuntimeEnvironment.application);



        RemoteOperationResult result = testOperation.execute(client);

        Assert.assertEquals("Expected result code was FORBIDDEN but got: "+result.getCode().name(), RemoteOperationResult.ResultCode.FORBIDDEN, result.getCode());
@@ -213,7 +210,7 @@ public class UploadFileOperationTest { 
        Assert.assertTrue("SyncedFileState loaded from DB must have an empty Etag", sfs_fromDB.getLastETAG().isEmpty());



        boolean checkEtag = false;

        UploadFileOperation testOperation = new UploadFileOperation(syncedFileStates.get(0));

        UploadFileOperation testOperation = new UploadFileOperation(syncedFileStates.get(0), RuntimeEnvironment.application);



        File smallFile = new File(sfs_fromDB.getLocalPath());

        Assert.assertTrue("Local file deletion return false instead of true", smallFile.delete());
@@ -231,7 +228,7 @@ public class UploadFileOperationTest { 
        //long freeQuota = getUserRemoteFreeQuota();

        Assert.assertFalse("Reading remote free quota fails"+userFreeQuota, -1 == userFreeQuota);

        //We don't care of parameter of UploadFileOperation's constructor

        RemoteOperationResult actualResult = new UploadFileOperation(Mockito.mock(SyncedFileState.class))

        RemoteOperationResult actualResult = new UploadFileOperation(Mockito.mock(SyncedFileState.class), RuntimeEnvironment.application)

                .checkAvailableSpace(client, (userFreeQuota+1));

        Assert.assertEquals("Quota check ("+ userFreeQuota+"vs"+(userFreeQuota+1)+") failed", RemoteOperationResult.ResultCode.QUOTA_EXCEEDED, actualResult.getCode());

    }
@@ -246,7 +243,7 @@ public class UploadFileOperationTest { 
        //long freeQuota = getUserRemoteFreeQuota();

        Assert.assertFalse("Reading remote free quota fails"+userFreeQuota, -1 == userFreeQuota);



        RemoteOperationResult actualResult = new UploadFileOperation(Mockito.mock(SyncedFileState.class))

        RemoteOperationResult actualResult = new UploadFileOperation(Mockito.mock(SyncedFileState.class), RuntimeEnvironment.application)

                .checkAvailableSpace(client, userFreeQuota);

        Assert.assertEquals("Quota check  ("+ userFreeQuota+" vs "+userFreeQuota+") failed",

                RemoteOperationResult.ResultCode.QUOTA_EXCEEDED,
@@ -263,7 +260,7 @@ public class UploadFileOperationTest { 
        //long freeQuota = getUserRemoteFreeQuota();

        Assert.assertFalse("Reading remote free quota fails "+userFreeQuota, -1 == userFreeQuota);



        RemoteOperationResult actualResult = new UploadFileOperation(Mockito.mock(SyncedFileState.class))

        RemoteOperationResult actualResult = new UploadFileOperation(Mockito.mock(SyncedFileState.class), RuntimeEnvironment.application)

                .checkAvailableSpace(client, (userFreeQuota-1));

        Assert.assertEquals("Quota check ("+ userFreeQuota+" vs "+(userFreeQuota-1)+") failed",

                RemoteOperationResult.ResultCode.OK,