Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 7eb35b08 authored by Carmelo Messina's avatar Carmelo Messina
Browse files

Partitioning all cookies by top frame domain: keep disabled... 

Partitioning all cookies by top frame domain: keep disabled kNativeUnpartitionedStoragePermittedWhen3PCOff and enable kDisallowSpaceCharacterInURLHostParsing by default
parent 8ac9a4bf

build/patches/Partitioning-all-cookies-by-top-frame-domain.patch

+16 −3
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html 
 .../strings/android/site_settings.grdp        |  4 +-

 .../core/browser/cookie_settings.cc           |  4 +-

 .../core/common/cookie_settings_base.cc       | 54 +------------------

 ...ioning-all-cookies-by-top-frame-domain.inc |  3 ++

 ...ioning-all-cookies-by-top-frame-domain.inc |  4 ++

 ...ioning-all-cookies-by-top-frame-domain.inc |  1 +

 ...ioning-all-cookies-by-top-frame-domain.inc |  1 +

 ...ioning-all-cookies-by-top-frame-domain.inc | 16 ++++++
@@ -36,7 +36,8 @@ License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html 
 .../modules/cookie_store/cookie_store.cc      |  3 ++

 .../cookie_store_delete_options.idl           |  2 +-

 ui/webui/webui_allowlist.cc                   |  1 +

 27 files changed, 86 insertions(+), 82 deletions(-)

 url/url_features.cc                           |  1 +

 28 files changed, 88 insertions(+), 82 deletions(-)

 create mode 100644 cromite_flags/components/content_settings/core/common/features_cc/Partitioning-all-cookies-by-top-frame-domain.inc

 create mode 100644 cromite_flags/components/permissions/features_cc/Partitioning-all-cookies-by-top-frame-domain.inc

 create mode 100644 cromite_flags/content/public/common/content_features_cc/Partitioning-all-cookies-by-top-frame-domain.inc
@@ -266,10 +267,11 @@ diff --git a/cromite_flags/components/content_settings/core/common/features_cc/P 
new file mode 100644

--- /dev/null

+++ b/cromite_flags/components/content_settings/core/common/features_cc/Partitioning-all-cookies-by-top-frame-domain.inc

@@ -0,0 +1,3 @@

@@ -0,0 +1,4 @@

+SET_CROMITE_FEATURE_DISABLED(kTrackingProtection3pcd);

+SET_CROMITE_FEATURE_DISABLED(kUserBypassUI);

+SET_CROMITE_FEATURE_DISABLED(kTpcdHeuristicsGrants);

+SET_CROMITE_FEATURE_DISABLED(kNativeUnpartitionedStoragePermittedWhen3PCOff);

diff --git a/cromite_flags/components/permissions/features_cc/Partitioning-all-cookies-by-top-frame-domain.inc b/cromite_flags/components/permissions/features_cc/Partitioning-all-cookies-by-top-frame-domain.inc

new file mode 100644

--- /dev/null
@@ -515,4 +517,15 @@ diff --git a/ui/webui/webui_allowlist.cc b/ui/webui/webui_allowlist.cc 
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

   DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);

 

diff --git a/url/url_features.cc b/url/url_features.cc

--- a/url/url_features.cc

+++ b/url/url_features.cc

@@ -24,6 +24,7 @@ BASE_FEATURE(kStandardCompliantNonSpecialSchemeURLParsing,

 BASE_FEATURE(kDisallowSpaceCharacterInURLHostParsing,

              "DisallowSpaceCharacterInURLHostParsing",

              base::FEATURE_DISABLED_BY_DEFAULT);

+SET_CROMITE_FEATURE_ENABLED(kDisallowSpaceCharacterInURLHostParsing);

 

 bool IsUsingIDNA2008NonTransitional() {

   // If the FeatureList isn't available yet, fall back to the feature's default

--