From ddd1832f4cc02dc29173e1c4ef05238a5ddf1844 Mon Sep 17 00:00:00 2001
From: Fahim Salam Chowdhury <fahim@e.email>
Date: Mon, 28 Mar 2022 22:41:10 +0600
Subject: [PATCH] 3551-Hide_zoom_slider_control_by_default

issue: https://gitlab.e.foundation/e/backlog/-/issues/3551

According to
https://gitlab.e.foundation/e/os/backlog/-/issues/94#note_181520
discussion, the zoom slider button might overlap on camera switcher
button. This commit set `preference_show_zoom_slider_controls`'s default
value to false to hide zoom slider by default.
---
 app/src/main/java/net/sourceforge/opencamera/MainActivity.java | 2 +-
 app/src/main/java/net/sourceforge/opencamera/ui/MainUI.java    | 2 +-
 app/src/main/res/xml/preferences.xml                           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/net/sourceforge/opencamera/MainActivity.java b/app/src/main/java/net/sourceforge/opencamera/MainActivity.java
index 27553fcea..14330f5a2 100644
--- a/app/src/main/java/net/sourceforge/opencamera/MainActivity.java
+++ b/app/src/main/java/net/sourceforge/opencamera/MainActivity.java
@@ -4090,7 +4090,7 @@ public class MainActivity extends Activity {
                     }
                 });
 
-                if( sharedPreferences.getBoolean(PreferenceKeys.ShowZoomSliderControlsPreferenceKey, true) ) {
+                if( sharedPreferences.getBoolean(PreferenceKeys.ShowZoomSliderControlsPreferenceKey, false) ) {
                     if( !mainUI.inImmersiveMode() ) {
                         zoomSeekBar.setVisibility(View.VISIBLE);
                     }
diff --git a/app/src/main/java/net/sourceforge/opencamera/ui/MainUI.java b/app/src/main/java/net/sourceforge/opencamera/ui/MainUI.java
index db3404580..8e4246c95 100644
--- a/app/src/main/java/net/sourceforge/opencamera/ui/MainUI.java
+++ b/app/src/main/java/net/sourceforge/opencamera/ui/MainUI.java
@@ -1106,7 +1106,7 @@ public class MainUI {
                 if (main_activity.getPreview().supportsZoom() && sharedPreferences.getBoolean(PreferenceKeys.ShowZoomControlsPreferenceKey, false)) {
                     zoomControls.setVisibility(visibility);
                 }
-                if (main_activity.getPreview().supportsZoom() && sharedPreferences.getBoolean(PreferenceKeys.ShowZoomSliderControlsPreferenceKey, true)) {
+                if (main_activity.getPreview().supportsZoom() && sharedPreferences.getBoolean(PreferenceKeys.ShowZoomSliderControlsPreferenceKey, false)) {
                     zoomSeekBar.setVisibility(visibility);
                 }
                 String pref_immersive_mode = sharedPreferences.getString(PreferenceKeys.ImmersiveModePreferenceKey, "immersive_mode_low_profile");
diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml
index ee4f5b002..f4e9ed12e 100644
--- a/app/src/main/res/xml/preferences.xml
+++ b/app/src/main/res/xml/preferences.xml
@@ -671,7 +671,7 @@
                 android:key="preference_show_zoom_slider_controls"
                 android:title="@string/preference_show_zoom_slider_controls"
                 android:summary="@string/preference_show_zoom_slider_controls_summary"
-                android:defaultValue="true"
+                android:defaultValue="false"
                 />
 
             <CheckBoxPreference
-- 
GitLab