Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff34d04d authored by Mark Harman's avatar Mark Harman Committed by Mohammed Althaf T
Browse files

longClickedTakePhoto() should return false if in video mode.

parent a7e94bcf

_docs/history.html

+2 −0
Original line number Diff line number Diff line
@@ -54,6 +54,8 @@ FIXED Device specific crashes when starting with Camera2 API (related to camer 
FIXED   Crash when saving images if unable to create thumbnail.

FIXED   If force destroyed when in settings, the camera would be incorrectly opened when application

        was recreated (camera should only be reopened when leaving settings).

FIXED   Long pressing on the shutter button in video mode meant nothing happened when releasing

        touch.

ADDED   Camera vendor extensions show percentage progress on supported Android 14 devices.

ADDED   Long press on switch camera icons now bring up a menu to jump to any camera.

UPDATED Improvements for loading thumbnails for gallery icon (including fixing orientation for

app/src/main/java/net/sourceforge/opencamera/MainActivity.java

+10 −3
Original line number Diff line number Diff line
@@ -2152,12 +2152,19 @@ public class MainActivity extends AppCompatActivity { 
        applicationInterface.getImageSaver().waitUntilDone();

    }



    /**

     * @return True if the long-click is handled, otherwise return false to indicate that regular

     * click should still be triggered when the user releases the touch.

     */

    private boolean longClickedTakePhoto() {

        if( MyDebug.LOG )

            Log.d(TAG, "longClickedTakePhoto");

        if( preview.isVideo() ) {

            // no long-click action for video mode

        }

        else if( supportsFastBurst() ) {

            // need to check whether fast burst is supported (including for the current resolution),

            // in case we're in Standard photo mode

        if( supportsFastBurst() ) {

            CameraController.Size current_size = preview.getCurrentPictureSize();

            if( current_size != null && current_size.supports_burst ) {

                MyApplicationInterface.PhotoMode photo_mode = applicationInterface.getPhotoMode();