Android Studio seems to have changed what it complains about. (e34d9727) · Commits · e / os / Camera

app/src/androidTest/java/net/sourceforge/opencamera/test/MainActivityTest.java

+0 −3

Original line number	Diff line number	Diff line
		@@ -9998,7 +9998,6 @@ public class MainActivityTest extends ActivityInstrumentationTestCase2<MainActiv
		SharedPreferences settings = PreferenceManager.getDefaultSharedPreferences(mActivity);
		SharedPreferences.Editor editor = settings.edit();

		@SuppressWarnings("deprecation") // "This functionality and UI is better handled with custom views and layouts" doesn't really work here - anyhow, we no longer use ZoomControl by default
		final ZoomControls zoomControls = mActivity.findViewById(net.sourceforge.opencamera.R.id.zoom);
		assertEquals(zoomControls.getVisibility(), View.GONE);

		@@ -15638,7 +15637,6 @@ public class MainActivityTest extends ActivityInstrumentationTestCase2<MainActiv
		inputs.add(avg_images_path + "testAvg25/input2.jpg");
		inputs.add(avg_images_path + "testAvg25/input3.jpg");

		//noinspection unused
		HistogramDetails hdrHistogramDetails = subTestAvg(inputs, "testAvg25_output.jpg", 512, 1000000000L/20, 1.0f, new TestAvgCallback() {
		@Override
		public void doneProcessAvg(int index) {
		@@ -16712,7 +16710,6 @@ public class MainActivityTest extends ActivityInstrumentationTestCase2<MainActiv
		* @param camera_angle_x The value of preview.getViewAngleX(for_preview=false) (in degrees) when taking the input photos (on the device used).
		* @param camera_angle_y The value of preview.getViewAngleY(for_preview=false) (in degrees) when taking the input photos (on the device used).
		*/
		@SuppressWarnings("unused")
		private void subTestPanorama(List<String> inputs, String output_name, String gyro_debug_info_filename, float panorama_pics_per_screen, float camera_angle_x, float camera_angle_y, float gyro_tol_degrees) throws IOException, InterruptedException {
		Log.d(TAG, "subTestPanorama");

app/src/main/java/net/sourceforge/opencamera/HDRProcessor.java

+0 −1

Original line number	Diff line number	Diff line
		@@ -3031,7 +3031,6 @@ public class HDRProcessor {
		* @param allocation_in The input allocation.
		* @param width The width of the allocation.
		*/
		@SuppressWarnings("unused")
		@RequiresApi(api = Build.VERSION_CODES.LOLLIPOP)
		private float computeSharpness(Allocation allocation_in, int width, long time_s) {
		if( MyDebug.LOG )

app/src/main/java/net/sourceforge/opencamera/ImageSaver.java

+0 −1

Original line number	Diff line number	Diff line
		@@ -1172,7 +1172,6 @@ public class ImageSaver extends Thread {

		@SuppressWarnings("WeakerAccess")
		public static class GyroDebugInfo {
		@SuppressWarnings("unused")
		public static class GyroImageDebugInfo {
		public float [] vectorRight; // X axis
		public float [] vectorUp; // Y axis

app/src/main/java/net/sourceforge/opencamera/MainActivity.java

+0 −9

Original line number	Diff line number	Diff line
		@@ -4425,26 +4425,20 @@ public class MainActivity extends Activity {
		Log.d(TAG, "set up zoom");
		if( MyDebug.LOG )
		Log.d(TAG, "has_zoom? " + preview.supportsZoom());
		@SuppressWarnings("deprecation") // "This functionality and UI is better handled with custom views and layouts" doesn't really work here - anyhow, we no longer use ZoomControl by default
		ZoomControls zoomControls = findViewById(R.id.zoom);
		SeekBar zoomSeekBar = findViewById(R.id.zoom_seekbar);

		if( preview.supportsZoom() ) {
		if( sharedPreferences.getBoolean(PreferenceKeys.ShowZoomControlsPreferenceKey, false) ) {
		//noinspection deprecation
		zoomControls.setIsZoomInEnabled(true);
		//noinspection deprecation
		zoomControls.setIsZoomOutEnabled(true);
		//noinspection deprecation
		zoomControls.setZoomSpeed(20);

		//noinspection deprecation
		zoomControls.setOnZoomInClickListener(new View.OnClickListener(){
		public void onClick(View v){
		zoomIn();
		}
		});
		//noinspection deprecation
		zoomControls.setOnZoomOutClickListener(new View.OnClickListener(){
		public void onClick(View v){
		zoomOut();
		@@ -4614,15 +4608,12 @@ public class MainActivity extends Activity {
		}
		});

		@SuppressWarnings("deprecation") // "This functionality and UI is better handled with custom views and layouts" doesn't really work here - anyhow, we no longer use ZoomControl by default
		ZoomControls seek_bar_zoom = findViewById(R.id.exposure_seekbar_zoom);
		//noinspection deprecation
		seek_bar_zoom.setOnZoomInClickListener(new View.OnClickListener(){
		public void onClick(View v){
		changeExposure(1);
		}
		});
		//noinspection deprecation
		seek_bar_zoom.setOnZoomOutClickListener(new View.OnClickListener(){
		public void onClick(View v){
		changeExposure(-1);

app/src/main/java/net/sourceforge/opencamera/MyApplicationInterface.java

+0 −4

Original line number	Diff line number	Diff line
		@@ -1005,10 +1005,6 @@ public class MyApplicationInterface extends BasicApplicationInterface {
		}
		else {
		// If save folder path is a full path, see if it matches the "external" storage (which actually means "primary", which typically isn't an SD card these days).
		// The reason given for deprecation is wrong - the path will only be inaccessible when also running on Android 10;
		// when using scoped storage, we should no longer hit this codepath, but we are still using this for older Android
		// versions.
		@SuppressWarnings("deprecation")
		File storage = Environment.getExternalStorageDirectory();
		if( MyDebug.LOG )
		Log.d(TAG, "compare to: " + storage.getAbsolutePath());