Camera2 API is now a "list" selection rather than a boolean switch.

<h2>General notes</h2>

<p>If you're just interested in taking photos with non-advanced features (without enabling "Camera2 API"), then most things

<p>If you're just interested in taking photos with non-advanced features (without using "Camera2 API"), then most things

        should work on most devices, as far as I can tell. I do occasionally get bug reports of things which seem to be device

        specific, but not enough to draw conclusions about things not working on particular devices. The most commonly reported

        issues seems to be:</p>

<h3>Sony Xperia</h3>

<p>To enable the 23MP photo resolution, you need to enable Settings/"Use Camera2 API". Someone has reported to me this works on the

<p>To enable the 23MP photo resolution, you need to set Settings/"Camera API" to "Camera2 API". Someone has reported to me this works on the

        Sony XA1 (G3123) (Android 8), I'm not sure about older devices.</p>

<!--<p>23MP photo resolution isn't available, the maximum seems to be 8MP. This seems to be due to

        <a href="http://talk.sonymobile.com/t5/Xperia-Z5-Z5-Compact-Z5-Premium/Full-camera-res-in-third-party-apps/td-p/1045437/highlight/true/page/4">Sony

a photo. In some cases, you can also hold (long press) for a continuous burst:</p>

<ul>

	<li>Photo mode must be Standard or Fast Burst</li>

	<li>Settings/"Use Camera2 API" must be enabled.</li>

	<li>Settings/"Camera API" must be set to "Camera2 API".</li>

	<li>Continuous burst only supported on some devices and resolutions.</li>

</ul>

    conditions, so there is no guarantee that the resultant video's frame rate will match with the requested value.</li>

	<li>Some frame rate values may be unsupported by your device, and cause the recording to fail, so please test before

    using.</li>

	<li>For best results (especially for 120fps or higher), please enable Settings/"Use Camera2 API". Even there, some

	<li>For best results (especially for 120fps or higher), please set Settings/"Camera API" to "Camera2 API". Even there, some

	devices seem to show buggy behaviour, so please test before using.</li>

	<li>This setting is ignored in slow motion mode, where instead Open Camera will choose an appropriate high speed frame

	rate.</li>

<p><b>Donate to support development</b> - Loads the page for

<a href="https://play.google.com/store/apps/details?id=harman.mark.donation">my donation app</a>.</p>

<p><b>Use Camera2 API</b> - If selected, this enables support for the Camera2 API that was introduced

in Android 5. Turning this option on or off will cause Open Camera to restart. This enables some new features

<p><b>Camera API</b> - If set to "Camera2 API", this enables support for the Camera2 API that was introduced

in Android 5. Changing this setting will cause Open Camera to restart. Camera2 API enables some new features

(including manual ISO/exposure, manual focus, HDR, exposure bracketing).

Note that not all Android 5 devices have full support for the Camera2 API (Open Camera will only show this

option if all cameras report either "LIMITED" or "FULL" support for the API; "LEGACY" devices are not supported).

option if at least one camera reports either "LIMITED" or "FULL" support for the API; "LEGACY" only devices are not supported).

Also note that even if devices support Camera2 API, many

devices have extremely poor support, leading to bugs such as poor flash behaviour, or video recording not working.

These are not necessarily bugs in Open Camera, but problems with manufacturer support for Camera2 API. If you have

possible for Open Camera to support them. Even where they are, since there is no current standard on what the extra

cameras are used for, it can't do anything with them other than allowing you to switch between them.</p>

<p><b>Why doesn't Open Camera support the maximum video resolution on my device?</b> - If you have

Settings/"Use Camera2 API" enabled, make sure that you're not in slow motion mode (see "Speed" under

<p><b>Why doesn't Open Camera support the maximum video resolution on my device?</b> - If you

are using Camera2 API, make sure that you're not in slow motion mode (see "Speed" under

the popup menu), and you don't have a non-default frame rate set (under Settings/Video settings). If

a high speed frame rate is in use, then this usually limits the maximum video resolution. If this

isn't the case, then it may be that the device isn't exposing the highest video resolution to third

if Camera2 API isn't enabled).</p>

<p><b>Why doesn't the FPS/bitrate setting for video work?</b> - These settings only give "recommendations" to the

camera, and there is no guarantee that they will be met. For best chance of success, try with Settings/"Use Camera2 API"

enabled.</p>

camera, and there is no guarantee that they will be met. For best chance of success, try setting Settings/"Camera API" to "Camera2 API".</p>

<p><b>But my camera can do 60/120FPS, so why can't Open Camera?</b> - High frame rates often are achieved only by the

"stock" camera app (or "mods" of it) because these are written for a specific device and don't have to go through

better for users to have this choice, rather than Open Camera having its own custom gallery.</p>

<p><b>Can you implement disabling shutter sound for my phone?</b> -

If your device supports "Settings/Use Camera2 API", then enabling that means you'll be able to disable

If Open Camera shows the option Settings/"Camera API", then changing to "Camera2 API" means you'll be able to disable

shutter sounds under "Settings/More camera controls...".

When not using Camera2 API, if the option "Shutter sound" under "More camera controls..." isn't shown,

then it's not available. There

Please ensure that you've downloaded from one of the places listed above

on this page.</p>

<p><b>Does Open Camera support features like manual controls for exposure/ISO/focus, and RAW?</b> - Enable

Settings/"Use Camera2 API" for such features (if the option isn't there, it's not supported on your device).

<p><b>Does Open Camera support features like manual controls for exposure/ISO/focus, and RAW?</b> -

Set Settings/"Camera API" to "Camera2 API" for such features (if the option isn't there, it's not supported on your device).

This is turned off by default as some <a href="devices.html">devices</a> have poor behaviour.</p>

<p><b>My device has Android 5 or later, why can't I select the Camera2 API?</b> - Some Android 5+ devices only have

Version 1.47.3 (Work in progress)

FIXED   Grids were being drawing too faintly.

UPDATED Camera2 API is now a "list" selection rather than a boolean switch.

UPDATED Minor accessibility improvements.

UPDATED Clarify in settings that PNG image format is not truly lossless.

        editor.clear();

        if( test_camera2 ) {

            MainActivity.test_force_supports_camera2 = true;

            editor.putBoolean(PreferenceKeys.UseCamera2PreferenceKey, true);

            //editor.putBoolean(PreferenceKeys.UseCamera2PreferenceKey, true);

            editor.putString(PreferenceKeys.CameraAPIPreferenceKey, "preference_camera_api_camera2");

        }

        editor.apply();

        Log.d(TAG, "setUp: 2");

    }

    /** Tests that we handle the upgrade from the preference boolean key "preference_use_camera2"

     *  to the string key PreferenceKeys.CameraAPIPreferenceKey that occured in v1.48.

     */

    public void testCamera2PrefUpgrade() {

        Log.d(TAG, "testCamera2PrefUpgrade");

        // n.b., don't bother calling setToDefault()

        waitUntilCameraOpened();

        assertFalse(mPreview.usingCamera2API());

        // test legacy key present, but set to old api

        SharedPreferences settings = PreferenceManager.getDefaultSharedPreferences(mActivity);

        SharedPreferences.Editor editor = settings.edit();

        editor.clear();

        editor.putBoolean("preference_use_camera2", false);

        editor.apply();

        restart();

        assertFalse(mPreview.usingCamera2API());

        // now test legacy key present for camera2 api

        settings = PreferenceManager.getDefaultSharedPreferences(mActivity);

        editor = settings.edit();

        editor.clear();

        editor.putBoolean("preference_use_camera2", true);

        editor.apply();

        for(int i=0;i<2;i++) {

            restart();

            assertTrue(mPreview.usingCamera2API());

            // also check we switched over to the new key

            settings = PreferenceManager.getDefaultSharedPreferences(mActivity);

            assertFalse(settings.contains("preference_use_camera2"));

            assertTrue(settings.contains(PreferenceKeys.CameraAPIPreferenceKey));

            assertEquals("preference_camera_api_camera2", settings.getString(PreferenceKeys.CameraAPIPreferenceKey, PreferenceKeys.CameraAPIPreferenceDefault));

        }

    }

    private static class HistogramDetails {

        final int min_value;

        final int median_value;

        suite.addTest(TestSuite.createTest(MainActivityTest.class, "testImmediatelyQuit"));

        suite.addTest(TestSuite.createTest(MainActivityTest.class, "testStartCameraPreviewCount"));

        if( !MainActivityTest.test_camera2 ) {

            suite.addTest(TestSuite.createTest(MainActivityTest.class, "testCamera2PrefUpgrade"));

            suite.addTest(TestSuite.createTest(MainActivityTest.class, "testSaveModes"));

            suite.addTest(TestSuite.createTest(MainActivityTest.class, "testFlashVideoMode"));

            //suite.addTest(TestSuite.createTest(MainActivityTest.class, "testSaveFlashTorchSwitchCamera"));