Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8861499 authored by Mark Harman's avatar Mark Harman
Browse files

Fix warnings.

parent f6999385

app/src/main/java/net/sourceforge/opencamera/ImageSaver.java

+2 −0
Original line number Diff line number Diff line
@@ -3204,6 +3204,8 @@ public class ImageSaver extends Thread { 
     * https://sourceforge.net/p/opencamera/tickets/417/ .

     */

    private static class ExifInterfaceHolder {

        // suppress warning - no it can't be local or removed, see documentation above about the garbage collector!

        @SuppressWarnings({"FieldCanBeLocal", "unused"})

        private final ParcelFileDescriptor pfd;

        private final ExifInterface exif;

app/src/main/java/net/sourceforge/opencamera/cameracontroller/CameraController.java

+2 −2
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ public abstract class CameraController { 
    }



    // Android docs and FindBugs recommend that Comparators also be Serializable

    public static class RangeSorter implements Comparator<int[]>, Serializable {

    static class RangeSorter implements Comparator<int[]>, Serializable {

        private static final long serialVersionUID = 5802214721073728212L;

        @Override

        public int compare(int[] o1, int[] o2) {
@@ -148,7 +148,7 @@ public abstract class CameraController { 
    /* Sorts resolutions from highest to lowest, by area.

     * Android docs and FindBugs recommend that Comparators also be Serializable

     */

    public static class SizeSorter implements Comparator<Size>, Serializable {

    static class SizeSorter implements Comparator<Size>, Serializable {

        private static final long serialVersionUID = 5802214721073718212L;



        @Override