Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2cf2608 authored by Mark Harman's avatar Mark Harman
Browse files

Remove speech recognition voice control due to no info for google play data privacy

parent 2ac19119

_docs/help.html

+2 −2
Original line number Diff line number Diff line
@@ -529,8 +529,8 @@ key to focus, then both to take a photo.</li> 
<p><b>Audio control options</b> - If enabled, this allows taking a photo (or starting video recording, depending on the mode)

by making a noise. An on-screen microphone button <img src="ic_mic_white_48dp.png" alt="Microphone icon" width="32" height="32"> will appear, to

start/stop listening. The "loud noise" option will listen for any noise (so you can remotely take a photo by saying "cheese",

whistling, or whatever you prefer). Note that leaving the listening turned on may use additional battery. The "voice command" option

listens specifically for saying "cheese" - so this has the advantage that it's less likely to be triggered unintentionally.

whistling, or whatever you prefer). Note that leaving the listening turned on may use additional battery. <!--The "voice command" option

listens specifically for saying "cheese" - so this has the advantage that it's less likely to be triggered unintentionally.-->

Note that this can't be used to stop video recording - if you want to have some remote control on video recording,

see the "Max duration of video" option.</p>

_docs/index.html

+1 −1
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ browsers --> 
<li>Option to <a href="help.html#auto_stabilise">auto-level</a> so your pictures are perfectly level no matter what.</li>

<li>Expose your camera's functionality: support for scene modes, color effects, white balance, ISO, exposure compensation/lock, selfie with "screen flash", HD video and more.</li>

<li>Handy remote controls: timer (with optional voice countdown), auto-repeat mode (with configurable delay).</li>

<li>Option to take photo remotely by making a noise, or by voice command "cheese".</li>

<li>Option to take photo remotely by making a noise<!--, or by voice command "cheese"-->.</li>

<li>Configurable volume keys and user interface.</li>

<li>Upside-down preview option for use with attachable lenses.</li>

<li>Overlay a choice of grids and crop guides.</li>

_docs/privacy_oc.html

+2 −1
Original line number Diff line number Diff line
@@ -76,12 +76,13 @@ of taking photos and recording videos, to fulfil its purpose as a camera. Microp 
<p>Since Open Camera also uses operating system APIs, you should review relevant privacy policies

    such as for your device, manufacturer, operating system and/or Google accounts. For example:</p>

<ul>

    <li>The optional voice control option uses the Android

    <li>For versions 1.49.2 or earlier: the optional voice control option used the Android

        <a href="https://developer.android.com/reference/android/speech/SpeechRecognizer">speech recognition service</a>.

        When enabled, audio data is likely to be sent to remote servers by Android to perform speech recognition.

        This is subject to the Data Processing Addendum for Products where Google is a Data Processor,

        located at

        <a href="https://privacy.google.com/businesses/gdprprocessorterms/">https://privacy.google.com/businesses/gdprprocessorterms/</a> , as updated from time to time.

        This option is no longer available in version 1.50 onwards.

    </li>

    <li>The "addresses" option for photo stamp or video subtitles uses the Android

        <a href="https://developer.android.com/reference/android/location/Geocoder">Geocoder API</a>.

app/src/androidTest/java/net/sourceforge/opencamera/test/MainActivityTest.java

+6 −6
Original line number Diff line number Diff line
@@ -3230,10 +3230,10 @@ public class MainActivityTest extends ActivityInstrumentationTestCase2<MainActiv 
        Log.d(TAG, "visibility is now: " + audioControlButton.getVisibility());

        assertEquals(audioControlButton.getVisibility(), View.GONE);









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "voice");









        /*editor.putString(PreferenceKeys.AudioControlPreferenceKey, "voice");









        editor.apply();









        updateForSettings();









        assertEquals(audioControlButton.getVisibility(), View.VISIBLE);









        assertEquals(audioControlButton.getVisibility(), View.VISIBLE);*/

















        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "none");









        editor.apply();








@@ -4908,7 +4908,7 @@ public class MainActivityTest extends ActivityInstrumentationTestCase2<MainActiv







        setToDefault();









        SharedPreferences settings = PreferenceManager.getDefaultSharedPreferences(mActivity);









        SharedPreferences.Editor editor = settings.edit();









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "voice");









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "noise");









        editor.apply();









        updateForSettings();
















@@ -4928,7 +4928,7 @@ public class MainActivityTest extends ActivityInstrumentationTestCase2<MainActiv







        SharedPreferences settings = PreferenceManager.getDefaultSharedPreferences(mActivity);









        SharedPreferences.Editor editor = settings.edit();









        editor.putString(PreferenceKeys.ImmersiveModePreferenceKey, "immersive_mode_gui");









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "voice");









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "noise");









        editor.apply();









        updateForSettings();
















@@ -5553,7 +5553,7 @@ public class MainActivityTest extends ActivityInstrumentationTestCase2<MainActiv







        setToDefault();









        SharedPreferences settings = PreferenceManager.getDefaultSharedPreferences(mActivity);









        SharedPreferences.Editor editor = settings.edit();









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "voice");









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "noise");









        editor.apply();









        updateForSettings();
















@@ -6486,7 +6486,7 @@ public class MainActivityTest extends ActivityInstrumentationTestCase2<MainActiv







        setToDefault();









        SharedPreferences settings = PreferenceManager.getDefaultSharedPreferences(mActivity);









        SharedPreferences.Editor editor = settings.edit();









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "voice");









        editor.putString(PreferenceKeys.AudioControlPreferenceKey, "noise");









        editor.apply();









        updateForSettings();








































app/src/main/AndroidManifest.xml



+0
−4






























Original line number
Diff line number
Diff line







@@ -169,9 +169,5 @@







        <intent>









            <action android:name="android.intent.action.TTS_SERVICE" />









        </intent>









        <intent>









            <action









                android:name="android.speech.RecognitionService" />









        </intent>









    </queries>









</manifest>