Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73e6e5c9 authored by Mark Harman's avatar Mark Harman
Browse files

Change automatically applied from updating Android Studio.

parent d06430ac

.idea/inspectionProfiles/Project_Default.xml

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
      <option name="SUGGEST_NULLABLE_ANNOTATIONS" value="false" />

      <option name="DONT_REPORT_TRUE_ASSERT_STATEMENTS" value="false" />

    </inspection_tool>

    <inspection_tool class="ConstantValue" enabled="false" level="WARNING" enabled_by_default="false" />

    <inspection_tool class="EmptyMethod" enabled="false" level="WARNING" enabled_by_default="false" />

    <inspection_tool class="EmptyStatementBody" enabled="false" level="WARNING" enabled_by_default="false">

      <option name="m_reportEmptyBlocks" value="true" />

opencamera_source.txt

+1 −1
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ The file .idea/inspectionProfiles/Project_Default.xml contains settings for Andr 
* BooleanMethodIsAlwaysInverted - Generates too many useless warnings.

* CharsetObjectCanBeUsed - This seems fundamentally broken, as it'll recommend using StandardCharsets, and then give an error that that's not available before API level 19! E.g., see Charset.forName("UTF-8") in SettingsManager.saveSettings(). Strangely though it doesn't warn about the API level if we replace it in ImageSaver.saveImageNow().

* CommentedOutCode - Commented out code is usually intentional!

* ConstantConditions - Unfortunately this seems broken when calling an Android SDK function where only a stub source is available, such that the inspection incorrectly things an exception is thrown. E.g., see calls to TouchUtils.clickView() in MainActivityTest, this inspection thinks that e.g. "i<8" in for loops is always true.

* ConstantConditions, ConstantValue - Unfortunately this seems broken when calling an Android SDK function where only a stub source is available, such that the inspection incorrectly things an exception is thrown. E.g., see calls to TouchUtils.clickView() in MainActivityTest, this inspection thinks that e.g. "i<8" in for loops is always true.

* EmptyMethod - Sometimes can be useful to explicitly have a subclassed empty method, to show I've intentionally left it empty rather than forgotten to consider it.

* EmptyStatementBody - These may be intentional.

* PointlessBooleanExpression - This complains too much about controlling codepaths with final boolean flags (e.g., "if( debug_switch && blah )").