Check for display width greater than height unnecessary, and can be wrong in split-screen mode. (6169abed) · Commits · e / os / Camera

_docs/history.html

+2 −0

Original line number	Diff line number	Diff line
		@@ -61,6 +61,8 @@ FIXED Some devices (e.g. Galaxy S24+) didn't layout UI correctly when switchin
		landscape and reversed landscape orientation.
		FIXED Placement on of-screen text (e.g. zoom indicator) when in reversed landscape orientation and
		focus seekbar was visible.
		FIXED Sometimes didn't layout UI correctly for landscape vs reversed landscape when in
		split-screen mode.
		FIXED Shifted positions of icons (when "along top") to avoid camera privacy indicator on some devices
		e.g. Samsung Galaxy.
		FIXED Icons weren't smoothly rotating the first time the device was rotated (for Camera2 API).

+1 −9

Original line number	Diff line number	Diff line
		@@ -1847,11 +1847,7 @@ public class MainActivity extends AppCompatActivity implements PreferenceFragmen
		case Configuration.ORIENTATION_LANDSCAPE:
		result = SystemOrientation.LANDSCAPE;
		// now try to distinguish between landscape and reverse landscape

		// check whether the display matches the landscape configuration, in case this is inconsistent?
		Point display_size = new Point();
		applicationInterface.getDisplaySize(display_size);
		if( display_size.x > display_size.y ) {
		{
		int rotation = getWindowManager().getDefaultDisplay().getRotation();
		if( MyDebug.LOG )
		Log.d(TAG, "rotation: " + rotation);
		@@ -1875,10 +1871,6 @@ public class MainActivity extends AppCompatActivity implements PreferenceFragmen
		break;
		}
		}
		else {
		if( MyDebug.LOG )
		Log.e(TAG, "display size not landscape: " + display_size);
		}
		break;
		case Configuration.ORIENTATION_PORTRAIT:
		result = SystemOrientation.PORTRAIT;