Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f08fbf0e authored by Mohammed Althaf T's avatar Mohammed Althaf T 😊
Browse files

Fix native autofill

parent 116806ca
Loading
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -162,7 +162,7 @@ sync() {
gclient_config() {
    cat <<EOF > "$chromium_dir/.gclient"
solutions = [{
    "url": "https://chromium.googlesource.com/chromium/src",
    "url": "https://github.com/chromium/chromium",
    "managed": False,
    "name": "src",
    "custom_deps": {},
+55 −0
Original line number Diff line number Diff line
From 15720b89b3ce8a9a9e6900527c2c27be4eb8baba Mon Sep 17 00:00:00 2001
From: althafvly <althafvly@gmail.com>
Date: Thu, 28 Sep 2023 21:11:16 +0530
Subject: [PATCH] fixup Enable native Android autofill

---
 android_webview/browser/aw_autofill_client.cc                  | 3 ++-
 android_webview/browser/aw_contents.cc                         | 3 +--
 .../chromium/components/embedder_support/view/ContentView.java | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/android_webview/browser/aw_autofill_client.cc b/android_webview/browser/aw_autofill_client.cc
index f0c74e6755702..6b0496c55a450 100644
--- a/android_webview/browser/aw_autofill_client.cc
+++ b/android_webview/browser/aw_autofill_client.cc
@@ -400,7 +400,8 @@ AwAutofillClient::AwAutofillClient(WebContents* contents,
               ? base::BindRepeating(&autofill::AndroidDriverInitHook, this)
               : base::BindRepeating(&autofill::BrowserDriverInitHook,
                                     this,
-                                    base::android::GetDefaultLocaleString()))
+                                    base::android::GetDefaultLocaleString(),
+                                    /*enable_secondary_autofill_manager*/ false))
 #if DCHECK_IS_ON()
       ,
       use_android_autofill_manager_(use_android_autofill_manager)
diff --git a/android_webview/browser/aw_contents.cc b/android_webview/browser/aw_contents.cc
index 9ae7dc6c17032..1324713845cbe 100644
--- a/android_webview/browser/aw_contents.cc
+++ b/android_webview/browser/aw_contents.cc
@@ -214,8 +214,7 @@ AwBrowserPermissionRequestDelegate* AwBrowserPermissionRequestDelegate::FromID(
 AwSafeBrowsingUIManager::UIManagerClient*
 AwSafeBrowsingUIManager::UIManagerClient::FromWebContents(
     WebContents* web_contents) {
-  return AwContents::FromWebContents(web_contents,
-                                /*enable_secondary_autofill_manager*/ false);
+  return AwContents::FromWebContents(web_contents);
 }
 
 // static
diff --git a/components/embedder_support/android/java/src/org/chromium/components/embedder_support/view/ContentView.java b/components/embedder_support/android/java/src/org/chromium/components/embedder_support/view/ContentView.java
index d42234d302efb..dfeeb225a790d 100644
--- a/components/embedder_support/android/java/src/org/chromium/components/embedder_support/view/ContentView.java
+++ b/components/embedder_support/android/java/src/org/chromium/components/embedder_support/view/ContentView.java
@@ -628,7 +628,7 @@ public class ContentView extends FrameLayout
     /**
     * API level 26 implementation that includes autofill.
     */
-    public static class ContentViewWithAutofill extends ContentView {
+    private static class ContentViewWithAutofill extends ContentView {
         private ViewAndroidDelegate viewAndroidDelegate;
 
         private ContentViewWithAutofill(Context context, EventOffsetHandler eventOffsetHandler, WebContents webContents) {
-- 
2.34.1