Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4446efb authored by Nishith Khanna's avatar Nishith Khanna
Browse files

Remove list tab mode related code from Move navigation bar to bottom patch 

Chromium removed list tab mode but Cromite adds it back again with use-list-mode patch which we don't use. Cromite adds some of the code related to in move navigation to bottom patch but it errors as the source doesn't contain list tab mode
parent d6bd840a

build/e_patches/fixup-Move-navigation-bar-to-bottom.patch

0 → 100644
+42 −0
Original line number Diff line number Diff line 
From 22d42082fdb5470aab05bfdaecc0476c2daa4135 Mon Sep 17 00:00:00 2001

From: Nishith Khanna <nishithkhanna@e.email>

Date: Mon, 18 Aug 2025 12:56:14 +0000

Subject: fixup Move navigation bar to bottom



---

 .../tab_management/TabListCoordinator.java    | 19 -------------------

 1 file changed, 19 deletions(-)



diff --git a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListCoordinator.java b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListCoordinator.java

index 5c9c8de07b54a..860a6ac577205 100644

--- a/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListCoordinator.java

+++ b/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListCoordinator.java

@@ -554,25 +554,6 @@ public class TabListCoordinator implements PriceWelcomeMessageProvider, DestroyO

                             }

                         };

                 mRecyclerView.setLayoutManager(layoutManager);

-            } else if (mMode == TabListMode.LIST) {

-                if (dialogHandler == null && selectionDelegateProvider == null &&

-                        ChromeFeatureList.sMoveTopToolbarToBottom.isEnabled()) {

-                    FrameLayout.LayoutParams recyclerViewParams =

-                        (FrameLayout.LayoutParams) mRecyclerView.getLayoutParams();

-                    int toolbarHeightPx = mBrowserControlsStateProvider.getTopControlsHeight();

-                    recyclerViewParams.topMargin = toolbarHeightPx;

-                    mRecyclerView.setLayoutParams(recyclerViewParams);

-                }

-                LinearLayoutManager layout =

-                    new LinearLayoutManager(activity, LinearLayoutManager.VERTICAL, false) {

-                            @Override

-                            public void onLayoutCompleted(RecyclerView.State state) {

-                                super.onLayoutCompleted(state);

-                                checkAwaitingLayout();

-                            }

-                        };

-                layout.setStackFromEnd(ChromeFeatureList.sMoveTopToolbarToBottom.isEnabled());

-                mRecyclerView.setLayoutManager(layout);

             }

             mMediator.setRecyclerViewItemAnimationToggle(mRecyclerView::setDisableItemAnimations);

         }

-- 

2.50.0

build/e_patches_list.txt

+1 −0
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ fixup-Revert-removal-of-execution-context-address-space.patch 
fixup-Bromite-subresource-adblocker.patch

fixup-Disable-fetching-of-all-field-trials.patch

fixup-eyeo-Browser-Ad-filtering-Solution.patch

fixup-Move-navigation-bar-to-bottom.patch

add-trichrome-browser-apk-targets.patch

Browser-disable-price-shopping-commerce-integration.patch

Remove-bromite-auto-updater-option.patch