Loading CHANGELOG.md +7 −0 Original line number Diff line number Diff line # 89.0.4389.100 * enable AImageReader by default (fixes https://github.com/bromite/bromite/issues/1005) * fix missing flag for AImageReader * move incognito snapshots flag to proper section (fixes https://github.com/bromite/bromite/issues/1006) * add missing icon for exit menu * implement SAF for bookmarks export functionality (thanks to @uazo, fixes https://github.com/bromite/bromite/issues/831) # 89.0.4389.92 * updated zh_CN translations (thanks to @zhmars, https://github.com/bromite/bromite/pull/1000) * introduce Alt+D hotkey to focus address bar (fixes https://github.com/bromite/bromite/issues/979) Loading build/RELEASE +1 −1 Original line number Diff line number Diff line 89.0.4389.92 89.0.4389.100 build/bromite_patches_list.txt +1 −1 Original line number Diff line number Diff line Loading @@ -54,6 +54,7 @@ Add-flags-to-disable-device-motion-orientation-APIs.patch Disable-metrics-on-all-I-O-threads.patch Always-respect-async-dns-flag-regardless-of-SDK-version.patch Add-flag-to-configure-maximum-connections-per-host.patch Do-not-ignore-download-location-prompt-setting.patch Add-bookmark-import-export-actions.patch Add-an-always-incognito-mode.patch Add-custom-tab-intents-privacy-option.patch Loading @@ -80,7 +81,6 @@ Offer-builtin-autocomplete-for-chrome-flags.patch Do-not-grant-notifications-to-default-search-engine.patch Add-flag-to-disable-IPv6-probes.patch Add-a-proxy-configuration-page.patch Do-not-ignore-download-location-prompt-setting.patch Disable-previews-by-default.patch Use-4-tile-rows-never-show-logo.patch Disable-metrics-collection-for-NTP-tiles.patch Loading build/patches/AImageReader-CFI-crash-mitigations.patch +6 −46 Original line number Diff line number Diff line Loading @@ -22,8 +22,7 @@ See discussions at: base/android/android_image_reader_compat.cc | 8 +++++++- base/android/android_image_reader_compat.h | 4 ++++ chrome/browser/flag-metadata.json | 2 +- gpu/config/gpu_driver_bug_list.json | 16 ++++++++++++++++ gpu/config/gpu_finch_features.cc | 11 ++++++++++- gpu/config/gpu_finch_features.cc | 5 +++++ gpu/config/gpu_finch_features.h | 1 + gpu/config/gpu_util.cc | 8 ++++++++ gpu/config/gpu_workaround_list.txt | 1 + Loading @@ -31,7 +30,7 @@ See discussions at: gpu/ipc/service/stream_texture_android.cc | 11 ++++++++++- media/base/media_switches.cc | 4 ++++ media/base/media_switches.h | 1 + 12 files changed, 68 insertions(+), 4 deletions(-) 11 files changed, 47 insertions(+), 3 deletions(-) diff --git a/base/android/android_image_reader_compat.cc b/base/android/android_image_reader_compat.cc --- a/base/android/android_image_reader_compat.cc Loading Loading @@ -83,41 +82,15 @@ diff --git a/base/android/android_image_reader_compat.h b/base/android/android_i diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json --- a/chrome/browser/flag-metadata.json +++ b/chrome/browser/flag-metadata.json @@ -1724,7 +1724,7 @@ @@ -1772,7 +1772,7 @@ { "name": "enable-heavy-ad-intervention", "owners": [ "johnidel", "jkarlin" ], "name": "enable-image-reader", "owners": [ "vikassoni", "liberato" ], - "expiry_milestone": 90 + "expiry_milestone": -1 }, { "name": "enable-heuristic-stylus-palm-rejection", diff --git a/gpu/config/gpu_driver_bug_list.json b/gpu/config/gpu_driver_bug_list.json --- a/gpu/config/gpu_driver_bug_list.json +++ b/gpu/config/gpu_driver_bug_list.json @@ -3254,6 +3254,22 @@ "dont_delete_source_texture_for_egl_image" ] }, + { + "id":335, + "cr_bugs": [1051705], + "description": "Disable AImageReader on ARM GPUs", + "os": { + "type": "android", + "version": { + "op": "<", + "value": "10" + } + }, + "gl_vendor": "ARM.*", + "features": [ + "disable_aimagereader" + ] + }, { "id": 336, "cr_bugs": [625785], "name": "enable-immersive-fullscreen-toolbar", diff --git a/gpu/config/gpu_finch_features.cc b/gpu/config/gpu_finch_features.cc --- a/gpu/config/gpu_finch_features.cc +++ b/gpu/config/gpu_finch_features.cc Loading @@ -133,19 +106,6 @@ diff --git a/gpu/config/gpu_finch_features.cc b/gpu/config/gpu_finch_features.cc // Used to limit GL version to 2.0 for skia raster on Android. const base::Feature kUseGles2ForOopR{"UseGles2ForOopR", base::FEATURE_DISABLED_BY_DEFAULT}; @@ -55,7 +60,11 @@ const base::FeatureParam<std::string> kAndroidSurfaceControlBlocklist{ // Use AImageReader for MediaCodec and MediaPlyer on android. const base::Feature kAImageReader{"AImageReader", - base::FEATURE_ENABLED_BY_DEFAULT}; +#ifdef ARCH_CPU_ARM64 + base::FEATURE_DISABLED_BY_DEFAULT}; +#else + base::FEATURE_ENABLED_BY_DEFAULT}; +#endif // If webview-draw-functor-uses-vulkan is set, use vulkan for composite and // raster. diff --git a/gpu/config/gpu_finch_features.h b/gpu/config/gpu_finch_features.h --- a/gpu/config/gpu_finch_features.h +++ b/gpu/config/gpu_finch_features.h Loading build/patches/Add-a-flag-to-allow-screenshots-in-Incognito-mode.patch +6 −6 Original line number Diff line number Diff line Loading @@ -17,19 +17,19 @@ See also: diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -5387,6 +5387,12 @@ const FeatureEntry kFeatureEntries[] = { SINGLE_VALUE_TYPE(switches::kEnableGPUServiceLogging)}, @@ -3040,6 +3040,12 @@ const FeatureEntry kFeatureEntries[] = { FEATURE_VALUE_TYPE(ash::features::kSystemTrayMicGainSetting)}, #endif // BUILDFLAG(IS_CHROMEOS_ASH) #if !defined(OS_ANDROID) +#if defined(OS_ANDROID) + {switches::kEnableIncognitoSnapshotsInAndroidRecents, flag_descriptions::kEnableIncognitoSnapshotsInAndroidRecentsName, + flag_descriptions::kEnableIncognitoSnapshotsInAndroidRecentsDescription, kOsAndroid, + SINGLE_VALUE_TYPE(switches::kEnableIncognitoSnapshotsInAndroidRecents)}, +#endif + {"hardware-media-key-handling", flag_descriptions::kHardwareMediaKeyHandling, flag_descriptions::kHardwareMediaKeyHandlingDescription, kOsDesktop, #if (defined(OS_LINUX) || BUILDFLAG(IS_CHROMEOS_LACROS)) && !defined(OS_ANDROID) { "enable-accelerated-video-decode", diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc Loading Loading
CHANGELOG.md +7 −0 Original line number Diff line number Diff line # 89.0.4389.100 * enable AImageReader by default (fixes https://github.com/bromite/bromite/issues/1005) * fix missing flag for AImageReader * move incognito snapshots flag to proper section (fixes https://github.com/bromite/bromite/issues/1006) * add missing icon for exit menu * implement SAF for bookmarks export functionality (thanks to @uazo, fixes https://github.com/bromite/bromite/issues/831) # 89.0.4389.92 * updated zh_CN translations (thanks to @zhmars, https://github.com/bromite/bromite/pull/1000) * introduce Alt+D hotkey to focus address bar (fixes https://github.com/bromite/bromite/issues/979) Loading
build/bromite_patches_list.txt +1 −1 Original line number Diff line number Diff line Loading @@ -54,6 +54,7 @@ Add-flags-to-disable-device-motion-orientation-APIs.patch Disable-metrics-on-all-I-O-threads.patch Always-respect-async-dns-flag-regardless-of-SDK-version.patch Add-flag-to-configure-maximum-connections-per-host.patch Do-not-ignore-download-location-prompt-setting.patch Add-bookmark-import-export-actions.patch Add-an-always-incognito-mode.patch Add-custom-tab-intents-privacy-option.patch Loading @@ -80,7 +81,6 @@ Offer-builtin-autocomplete-for-chrome-flags.patch Do-not-grant-notifications-to-default-search-engine.patch Add-flag-to-disable-IPv6-probes.patch Add-a-proxy-configuration-page.patch Do-not-ignore-download-location-prompt-setting.patch Disable-previews-by-default.patch Use-4-tile-rows-never-show-logo.patch Disable-metrics-collection-for-NTP-tiles.patch Loading
build/patches/AImageReader-CFI-crash-mitigations.patch +6 −46 Original line number Diff line number Diff line Loading @@ -22,8 +22,7 @@ See discussions at: base/android/android_image_reader_compat.cc | 8 +++++++- base/android/android_image_reader_compat.h | 4 ++++ chrome/browser/flag-metadata.json | 2 +- gpu/config/gpu_driver_bug_list.json | 16 ++++++++++++++++ gpu/config/gpu_finch_features.cc | 11 ++++++++++- gpu/config/gpu_finch_features.cc | 5 +++++ gpu/config/gpu_finch_features.h | 1 + gpu/config/gpu_util.cc | 8 ++++++++ gpu/config/gpu_workaround_list.txt | 1 + Loading @@ -31,7 +30,7 @@ See discussions at: gpu/ipc/service/stream_texture_android.cc | 11 ++++++++++- media/base/media_switches.cc | 4 ++++ media/base/media_switches.h | 1 + 12 files changed, 68 insertions(+), 4 deletions(-) 11 files changed, 47 insertions(+), 3 deletions(-) diff --git a/base/android/android_image_reader_compat.cc b/base/android/android_image_reader_compat.cc --- a/base/android/android_image_reader_compat.cc Loading Loading @@ -83,41 +82,15 @@ diff --git a/base/android/android_image_reader_compat.h b/base/android/android_i diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json --- a/chrome/browser/flag-metadata.json +++ b/chrome/browser/flag-metadata.json @@ -1724,7 +1724,7 @@ @@ -1772,7 +1772,7 @@ { "name": "enable-heavy-ad-intervention", "owners": [ "johnidel", "jkarlin" ], "name": "enable-image-reader", "owners": [ "vikassoni", "liberato" ], - "expiry_milestone": 90 + "expiry_milestone": -1 }, { "name": "enable-heuristic-stylus-palm-rejection", diff --git a/gpu/config/gpu_driver_bug_list.json b/gpu/config/gpu_driver_bug_list.json --- a/gpu/config/gpu_driver_bug_list.json +++ b/gpu/config/gpu_driver_bug_list.json @@ -3254,6 +3254,22 @@ "dont_delete_source_texture_for_egl_image" ] }, + { + "id":335, + "cr_bugs": [1051705], + "description": "Disable AImageReader on ARM GPUs", + "os": { + "type": "android", + "version": { + "op": "<", + "value": "10" + } + }, + "gl_vendor": "ARM.*", + "features": [ + "disable_aimagereader" + ] + }, { "id": 336, "cr_bugs": [625785], "name": "enable-immersive-fullscreen-toolbar", diff --git a/gpu/config/gpu_finch_features.cc b/gpu/config/gpu_finch_features.cc --- a/gpu/config/gpu_finch_features.cc +++ b/gpu/config/gpu_finch_features.cc Loading @@ -133,19 +106,6 @@ diff --git a/gpu/config/gpu_finch_features.cc b/gpu/config/gpu_finch_features.cc // Used to limit GL version to 2.0 for skia raster on Android. const base::Feature kUseGles2ForOopR{"UseGles2ForOopR", base::FEATURE_DISABLED_BY_DEFAULT}; @@ -55,7 +60,11 @@ const base::FeatureParam<std::string> kAndroidSurfaceControlBlocklist{ // Use AImageReader for MediaCodec and MediaPlyer on android. const base::Feature kAImageReader{"AImageReader", - base::FEATURE_ENABLED_BY_DEFAULT}; +#ifdef ARCH_CPU_ARM64 + base::FEATURE_DISABLED_BY_DEFAULT}; +#else + base::FEATURE_ENABLED_BY_DEFAULT}; +#endif // If webview-draw-functor-uses-vulkan is set, use vulkan for composite and // raster. diff --git a/gpu/config/gpu_finch_features.h b/gpu/config/gpu_finch_features.h --- a/gpu/config/gpu_finch_features.h +++ b/gpu/config/gpu_finch_features.h Loading
build/patches/Add-a-flag-to-allow-screenshots-in-Incognito-mode.patch +6 −6 Original line number Diff line number Diff line Loading @@ -17,19 +17,19 @@ See also: diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -5387,6 +5387,12 @@ const FeatureEntry kFeatureEntries[] = { SINGLE_VALUE_TYPE(switches::kEnableGPUServiceLogging)}, @@ -3040,6 +3040,12 @@ const FeatureEntry kFeatureEntries[] = { FEATURE_VALUE_TYPE(ash::features::kSystemTrayMicGainSetting)}, #endif // BUILDFLAG(IS_CHROMEOS_ASH) #if !defined(OS_ANDROID) +#if defined(OS_ANDROID) + {switches::kEnableIncognitoSnapshotsInAndroidRecents, flag_descriptions::kEnableIncognitoSnapshotsInAndroidRecentsName, + flag_descriptions::kEnableIncognitoSnapshotsInAndroidRecentsDescription, kOsAndroid, + SINGLE_VALUE_TYPE(switches::kEnableIncognitoSnapshotsInAndroidRecents)}, +#endif + {"hardware-media-key-handling", flag_descriptions::kHardwareMediaKeyHandling, flag_descriptions::kHardwareMediaKeyHandlingDescription, kOsDesktop, #if (defined(OS_LINUX) || BUILDFLAG(IS_CHROMEOS_LACROS)) && !defined(OS_ANDROID) { "enable-accelerated-video-decode", diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc Loading