Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 575a9924 authored by Aayush Gupta's avatar Aayush Gupta
Browse files

Merge tag 90.0.4430.204 from bromite 



ded81bf6 Release 90.0.4430.204
b2075a35 revert last changes + remove record incognito launch reason histogram (#1125)

Signed-off-by: Aayush Gupta's avatarAayush Gupta <theimpulson@e.email>
parents 0b8ce2ba ded81bf6

CHANGELOG.md

+3 −0
Original line number Diff line number Diff line 
# 90.0.4430.204

* fix for custom tab intent tab crashes when in always incognito mode (thanks to @uazo, fixes https://github.com/bromite/bromite/issues/1116)



# 90.0.4430.101

* disable RTCGetCurrentBrowsingContextMedia by default

* disable FLoC by default

build/RELEASE

+1 −1
Original line number Diff line number Diff line 
90.0.4430.101
 
90.0.4430.204

build/patches/Add-an-always-incognito-mode.patch

+40 −1
Original line number Diff line number Diff line
@@ -14,6 +14,8 @@ Enable incognito custom tabs and fix crashes for incognito/custom tab intents (c 
 .../chrome/browser/app/ChromeActivity.java    |  4 +

 .../AppMenuPropertiesDelegateImpl.java        |  6 ++

 .../ChromeContextMenuPopulator.java           |  9 ++-

 .../CustomTabActivityLifecycleUmaTracker.java |  5 --

 .../CustomTabIntentDataProvider.java          |  5 +-

 .../browser/init/StartupTabPreloader.java     | 14 +++-

 .../privacy/settings/PrivacySettings.java     |  2 +

 .../browser/tabmodel/ChromeTabCreator.java    | 16 +++-
@@ -21,7 +23,7 @@ Enable incognito custom tabs and fix crashes for incognito/custom tab intents (c 
 .../webapps/WebappIntentDataProvider.java     | 14 ++++

 .../flags/android/chrome_feature_list.cc      |  2 +-

 .../strings/android_chrome_strings.grd        |  7 ++

 14 files changed, 168 insertions(+), 8 deletions(-)

 16 files changed, 172 insertions(+), 14 deletions(-)

 create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/AlwaysIncognitoLinkInterceptor.java



diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni
@@ -222,6 +224,43 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/Chr 
                     if (!mItemDelegate.isIncognito() && mItemDelegate.isIncognitoSupported()) {

                         linkGroup.add(createListItem(Item.OPEN_IN_INCOGNITO_TAB));

                     }

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivityLifecycleUmaTracker.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivityLifecycleUmaTracker.java

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivityLifecycleUmaTracker.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivityLifecycleUmaTracker.java

@@ -34,11 +34,6 @@ public class CustomTabActivityLifecycleUmaTracker implements PauseResumeWithNati

     private boolean mIsInitialResume = true;

 

     private void recordIncognitoLaunchReason() {

-        IncognitoCustomTabIntentDataProvider incognitoProvider =

-                (IncognitoCustomTabIntentDataProvider) mIntentDataProvider;

-        RecordHistogram.recordEnumeratedHistogram("CustomTabs.IncognitoCCTCallerId",

-                incognitoProvider.getFeatureIdForMetricsCollection(),

-                IntentHandler.IncognitoCCTCallerId.NUM_ENTRIES);

     }

 

     private void recordUserAction() {

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

@@ -48,6 +48,9 @@ import org.chromium.components.browser_ui.widget.TintedDrawable;

 import org.chromium.components.embedder_support.util.UrlConstants;

 import org.chromium.device.mojom.ScreenOrientationLockType;

 

+import org.chromium.base.ContextUtils;

+import org.chromium.chrome.browser.AlwaysIncognitoLinkInterceptor;

+

 import java.lang.annotation.Retention;

 import java.lang.annotation.RetentionPolicy;

 import java.util.ArrayList;

@@ -781,7 +784,7 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid

 

     @Override

     public boolean isIncognito() {

-        return false;

+        return ContextUtils.getAppSharedPreferences().getBoolean(AlwaysIncognitoLinkInterceptor.PREF_ALWAYS_INCOGNITO, false);

     }

 

     @Nullable

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/StartupTabPreloader.java b/chrome/android/java/src/org/chromium/chrome/browser/init/StartupTabPreloader.java

--- a/chrome/android/java/src/org/chromium/chrome/browser/init/StartupTabPreloader.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/init/StartupTabPreloader.java