From 084d62267a8d2bfb0b0a603e0a29be8009d8fd8f Mon Sep 17 00:00:00 2001
From: Jonathan Klee <jonathan.klee@e.email>
Date: Mon, 4 Dec 2023 12:37:03 +0100
Subject: [PATCH] Do not count private methods in detekt

Do not count private methods in dtekt for the TooManyFunctions
rule.
---
 app/detekt-baseline.xml | 13 -------------
 detekt.yml              |  6 ++++++
 2 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/app/detekt-baseline.xml b/app/detekt-baseline.xml
index 7813ffbf5..21ad79f51 100644
--- a/app/detekt-baseline.xml
+++ b/app/detekt-baseline.xml
@@ -169,33 +169,20 @@
     <ID>TooGenericExceptionThrown:AnonymousLoginManager.kt$AnonymousLoginManager$throw Exception( "Error fetching Anonymous credentials\n" + "Network code: ${response.code}\n" + "Success: ${response.isSuccessful}" + response.errorString.run { if (isNotBlank()) "\nError message: $this" else "" } )</ID>
     <ID>TooGenericExceptionThrown:PlayStoreLoginWrapper.kt$PlayStoreLoginWrapper$throw Exception("Validation network code: ${response.code}")</ID>
     <ID>TooGenericExceptionThrown:PlayStoreLoginWrapper.kt$PlayStoreLoginWrapper$throw Exception(error)</ID>
-    <ID>TooManyFunctions:AppInstallProcessor.kt$AppInstallProcessor</ID>
-    <ID>TooManyFunctions:AppPrivacyInfoRepositoryImpl.kt$AppPrivacyInfoRepositoryImpl : IAppPrivacyInfoRepository</ID>
     <ID>TooManyFunctions:ApplicationApi.kt$ApplicationApi</ID>
     <ID>TooManyFunctions:ApplicationApiImpl.kt$ApplicationApiImpl : ApplicationApi</ID>
-    <ID>TooManyFunctions:ApplicationFragment.kt$ApplicationFragment : TimeoutFragment</ID>
     <ID>TooManyFunctions:ApplicationListFragment.kt$ApplicationListFragment : TimeoutFragmentApplicationInstaller</ID>
-    <ID>TooManyFunctions:ApplicationListRVAdapter.kt$ApplicationListRVAdapter : ListAdapter</ID>
     <ID>TooManyFunctions:ApplicationRepository.kt$ApplicationRepository</ID>
-    <ID>TooManyFunctions:DownloadManager.kt$DownloadManager</ID>
     <ID>TooManyFunctions:FusedManagerImpl.kt$FusedManagerImpl : IFusedManager</ID>
     <ID>TooManyFunctions:FusedManagerRepository.kt$FusedManagerRepository</ID>
-    <ID>TooManyFunctions:GPlayHttpClient.kt$GPlayHttpClient : IHttpClient</ID>
-    <ID>TooManyFunctions:HomeChildRVAdapter.kt$HomeChildRVAdapter : ListAdapter</ID>
     <ID>TooManyFunctions:HomeFragment.kt$HomeFragment : TimeoutFragmentApplicationInstaller</ID>
     <ID>TooManyFunctions:IFusedManager.kt$IFusedManager</ID>
     <ID>TooManyFunctions:LoginData.kt$LoginData</ID>
-    <ID>TooManyFunctions:MainActivity.kt$MainActivity : AppCompatActivity</ID>
     <ID>TooManyFunctions:MainActivityViewModel.kt$MainActivityViewModel : ViewModel</ID>
     <ID>TooManyFunctions:PkgManagerModule.kt$PkgManagerModule</ID>
-    <ID>TooManyFunctions:PlayStoreAuthenticator.kt$PlayStoreAuthenticator : StoreAuthenticatorAuthDataValidator</ID>
-    <ID>TooManyFunctions:PlayStoreRepositoryImpl.kt$PlayStoreRepositoryImpl : PlayStoreRepository</ID>
-    <ID>TooManyFunctions:RetrofitModule.kt$RetrofitModule</ID>
     <ID>TooManyFunctions:SearchFragment.kt$SearchFragment : TimeoutFragmentOnQueryTextListenerOnSuggestionListenerApplicationInstaller</ID>
     <ID>TooManyFunctions:TimeoutFragment.kt$TimeoutFragment : Fragment</ID>
     <ID>TooManyFunctions:UpdatesFragment.kt$UpdatesFragment : TimeoutFragmentApplicationInstaller</ID>
-    <ID>TooManyFunctions:UpdatesManagerImpl.kt$UpdatesManagerImpl</ID>
-    <ID>TooManyFunctions:UpdatesWorker.kt$UpdatesWorker : CoroutineWorker</ID>
     <ID>UnusedParameter:SearchViewModel.kt$SearchViewModel$lifecycleOwner: LifecycleOwner</ID>
   </CurrentIssues>
 </SmellBaseline>
diff --git a/detekt.yml b/detekt.yml
index 4f6148616..773174aa0 100644
--- a/detekt.yml
+++ b/detekt.yml
@@ -13,3 +13,9 @@ style:
 
   ForbiddenComment:
     active: false
+
+# Complexity rules
+complexity:
+
+  TooManyFunctions:
+    ignorePrivate: true
-- 
GitLab