From 969f09f3023f8f3d9b48836410cbe3e6ff6d74b2 Mon Sep 17 00:00:00 2001 From: Jonathan Klee Date: Fri, 20 Oct 2023 11:45:10 +0200 Subject: [PATCH 1/2] Add current Detekt baseline New code smells will be detected from this baseline. --- app/detekt-baseline.xml | 232 ++++++++++++++++++++++++++++++++++++++++ build.gradle | 4 +- 2 files changed, 234 insertions(+), 2 deletions(-) create mode 100644 app/detekt-baseline.xml diff --git a/app/detekt-baseline.xml b/app/detekt-baseline.xml new file mode 100644 index 000000000..217b0fd1c --- /dev/null +++ b/app/detekt-baseline.xml @@ -0,0 +1,232 @@ + + + + + ComplexCondition:AppPurchaseFragment.kt$AppPurchaseFragment.<no name provided>$url.contains("https://play.google.com/store/apps/details") && url.contains("raii") && url.contains("raboi") && url.contains("rasi") && url.contains("rapt") + CyclomaticComplexMethod:ApplicationDiffUtil.kt$ApplicationDiffUtil$override fun areContentsTheSame(oldItem: FusedApp, newItem: FusedApp): Boolean + CyclomaticComplexMethod:CategoryUtils.kt$CategoryUtils$fun provideAppsCategoryIconResource(categoryId: String): Int + CyclomaticComplexMethod:DownloadProgressLD.kt$DownloadProgressLD$override fun observe(owner: LifecycleOwner, observer: Observer<in DownloadProgress>) + CyclomaticComplexMethod:FusedApiImpl.kt$FusedApiImpl$private suspend fun generateCleanAPKHome(home: Home, appType: String): List<FusedHome> + CyclomaticComplexMethod:HomeChildFusedAppDiffUtil.kt$HomeChildFusedAppDiffUtil$override fun areContentsTheSame(oldItem: FusedApp, newItem: FusedApp): Boolean + CyclomaticComplexMethod:MainActivity.kt$MainActivity$override fun onCreate(savedInstanceState: Bundle?) + EmptyCatchBlock:NativeDeviceInfoProviderModule.kt$NativeDeviceInfoProviderModule${ } + EmptyFunctionBlock:CleanApkAuthenticator.kt$CleanApkAuthenticator${} + ImplicitDefaultLocale:ApplicationFragment.kt$ApplicationFragment$String.format("%d%%", progressPercentage) + ImplicitDefaultLocale:ApplicationListFragment.kt$ApplicationListFragment$String.format("%d%%", progress) + ImplicitDefaultLocale:HomeFragment.kt$HomeFragment$String.format("%d%%", progress) + ImplicitDefaultLocale:SearchFragment.kt$SearchFragment$String.format("%d%%", progress) + ImplicitDefaultLocale:StorageComputer.kt$StorageComputer$String.format("%.1f %cB", bytes / 1000.0, ci.current()) + ImplicitDefaultLocale:UpdatesFragment.kt$UpdatesFragment$String.format("%d%%", progress) + InstanceOfCheckForException:GPlayHttpClient.kt$GPlayHttpClient$e is SocketTimeoutException + InvalidPackageDeclaration:Trackers.kt$package foundation.e.apps.data.exodus + LargeClass:ApplicationFragment.kt$ApplicationFragment : TimeoutFragment + LargeClass:FusedApiImpl.kt$FusedApiImpl : FusedApi + LongMethod:ApplicationFragment.kt$ApplicationFragment$private fun observeDownloadStatus(view: View) + LongMethod:CategoryUtils.kt$CategoryUtils$fun provideAppsCategoryIconResource(categoryId: String): Int + LongMethod:FusedApiImpl.kt$FusedApiImpl$private suspend fun generateCleanAPKHome(home: Home, appType: String): List<FusedHome> + LongMethod:MainActivity.kt$MainActivity$override fun onCreate(savedInstanceState: Bundle?) + LongMethod:NativeDeviceInfoProviderModule.kt$NativeDeviceInfoProviderModule$@Singleton @Provides fun provideNativeDeviceProperties( @ApplicationContext context: Context, ): Properties + LongParameterList:ApplicationDialogFragment.kt$ApplicationDialogFragment$( drawable: Int = -1, title: String, message: String, positiveButtonText: String = "", positiveButtonAction: (() -> Unit)? = null, cancelButtonText: String = "", cancelButtonAction: (() -> Unit)? = null, cancellable: Boolean = true, onDismissListener: (() -> Unit)? = null, ) + LongParameterList:ApplicationListRVAdapter.kt$ApplicationListRVAdapter$( private val fusedAPIInterface: FusedAPIInterface, private val privacyInfoViewModel: PrivacyInfoViewModel, private val appInfoFetchViewModel: AppInfoFetchViewModel, private val mainActivityViewModel: MainActivityViewModel, private val currentDestinationId: Int, private var lifecycleOwner: LifecycleOwner?, private var paidAppHandler: ((FusedApp) -> Unit)? = null ) + LongParameterList:ApplicationViewModel.kt$ApplicationViewModel$( id: String, packageName: String, origin: Origin, isFdroidLink: Boolean, authObjectList: List<AuthObject>, retryBlock: (failedObjects: List<AuthObject>) -> Boolean, ) + LongParameterList:CleanApkRetrofit.kt$CleanApkRetrofit$( @Query("keyword") keyword: String, @Query("source") source: String = APP_SOURCE_FOSS, @Query("type") type: String = APP_TYPE_ANY, @Query("nres") nres: Int = 20, @Query("page") page: Int = 1, @Query("by") by: String? = null, ) + LongParameterList:EglExtensionProvider.kt$EglExtensionProvider$( egl10: EGL10, eglDisplay: EGLDisplay, eglConfig: EGLConfig?, ai: IntArray, ai1: IntArray?, set: MutableSet<String> ) + LongParameterList:FusedApiImpl.kt$FusedApiImpl$( private val pkgManagerModule: PkgManagerModule, private val pwaManagerModule: PWAManagerModule, private val preferenceManagerModule: PreferenceManagerModule, @Named("gplayRepository") private val gplayRepository: PlayStoreRepository, @Named("cleanApkAppsRepository") private val cleanApkAppsRepository: CleanApkRepository, @Named("cleanApkPWARepository") private val cleanApkPWARepository: CleanApkRepository, @ApplicationContext private val context: Context ) + LongParameterList:FusedManagerImpl.kt$FusedManagerImpl$( @Named("cacheDir") private val cacheDir: String, private val downloadManager: DownloadManager, private val notificationManager: NotificationManager, private val fusedDownloadRepository: FusedDownloadRepository, private val pwaManagerModule: PWAManagerModule, private val pkgManagerModule: PkgManagerModule, @Named("download") private val downloadNotificationChannel: NotificationChannel, @Named("update") private val updateNotificationChannel: NotificationChannel, @ApplicationContext private val context: Context ) + LongParameterList:MainActivityViewModel.kt$MainActivityViewModel$( private val dataStoreModule: DataStoreModule, private val fusedAPIRepository: FusedAPIRepository, private val fusedManagerRepository: FusedManagerRepository, private val pkgManagerModule: PkgManagerModule, private val pwaManagerModule: PWAManagerModule, private val ecloudRepository: EcloudRepository, private val blockedAppRepository: BlockedAppRepository, private val appInstallProcessor: AppInstallProcessor ) + LongParameterList:UpdatesManagerImpl.kt$UpdatesManagerImpl$( @ApplicationContext private val context: Context, private val pkgManagerModule: PkgManagerModule, private val fusedAPIRepository: FusedAPIRepository, private val faultyAppRepository: FaultyAppRepository, private val preferenceManagerModule: PreferenceManagerModule, private val fdroidRepository: FdroidRepository, private val blockedAppRepository: BlockedAppRepository, ) + LongParameterList:UpdatesWorker.kt$UpdatesWorker$( @Assisted private val context: Context, @Assisted private val params: WorkerParameters, private val updatesManagerRepository: UpdatesManagerRepository, private val dataStoreManager: DataStoreManager, private val authenticatorRepository: AuthenticatorRepository, private val appInstallProcessor: AppInstallProcessor, private val blockedAppRepository: BlockedAppRepository, ) + MagicNumber:AnonymousLoginManager.kt$AnonymousLoginManager$200 + MagicNumber:ApkSignatureManager.kt$ApkSignatureManager$1024 + MagicNumber:AppDatabase.kt$AppDatabase.Companion.<no name provided>$3 + MagicNumber:AppDatabase.kt$AppDatabase.Companion.<no name provided>$4 + MagicNumber:ApplicationFragment.kt$ApplicationFragment$100f + MagicNumber:ApplicationFragment.kt$ApplicationFragment$15 + MagicNumber:ApplicationFragment.kt$ApplicationFragment$3 + MagicNumber:ApplicationFragment.kt$ApplicationFragment$3.4 + MagicNumber:ApplicationFragment.kt$ApplicationFragment$6 + MagicNumber:ApplicationListRVAdapter.kt$ApplicationListRVAdapter$0.6f + MagicNumber:ApplicationListRVAdapter.kt$ApplicationListRVAdapter$0.7f + MagicNumber:ApplicationListRVAdapter.kt$ApplicationListRVAdapter$500 + MagicNumber:AuthObject.kt$AuthObject.GPlayAuth$401 + MagicNumber:CleanApkPWARepository.kt$CleanApkPWARepository$20 + MagicNumber:CommonUtilsModule.kt$CommonUtilsModule$10 + MagicNumber:CommonUtilsModule.kt$CommonUtilsModule$1024 + MagicNumber:DepthPageTransformer.kt$DepthPageTransformer$0.75f + MagicNumber:DownloadManagerUtils.kt$DownloadManagerUtils$1500 + MagicNumber:DownloadProgressLD.kt$DownloadProgressLD$20 + MagicNumber:DownloadProgressLD.kt$DownloadProgressLD$500 + MagicNumber:DumpAuthData.kt$DumpAuthData$4 + MagicNumber:EglExtensionProvider.kt$EglExtensionProvider$12440 + MagicNumber:EglExtensionProvider.kt$EglExtensionProvider$4 + MagicNumber:EglExtensionProvider.kt$EglExtensionProvider$7939 + MagicNumber:FileManager.kt$FileManager$1024 + MagicNumber:FusedApiImpl.kt$FusedApiImpl$3 + MagicNumber:FusedManagerRepository.kt$FusedManagerRepository$100 + MagicNumber:HomeChildRVAdapter.kt$HomeChildRVAdapter$0.6f + MagicNumber:HomeChildRVAdapter.kt$HomeChildRVAdapter$0.7f + MagicNumber:HomeChildRVAdapter.kt$HomeChildRVAdapter$500 + MagicNumber:InstallerService.kt$InstallerService$69 + MagicNumber:NativeDeviceInfoProviderModule.kt$NativeDeviceInfoProviderModule$15 + MagicNumber:PWAManagerModule.kt$PWAManagerModule$100 + MagicNumber:PWAManagerModule.kt$PWAManagerModule$500 + MagicNumber:PackageInstallerService.kt$PackageInstallerService$69 + MagicNumber:PkgManagerBR.kt$PkgManagerBR$69 + MagicNumber:PlayStoreLoginWrapper.kt$PlayStoreLoginWrapper$200 + MagicNumber:RetrofitModule.kt$RetrofitModule$999 + MagicNumber:ScreenshotRVAdapter.kt$ScreenshotRVAdapter$10f + MagicNumber:ScreenshotRVAdapter.kt$ScreenshotRVAdapter$50f + MagicNumber:StorageComputer.kt$StorageComputer$1000 + MagicNumber:StorageComputer.kt$StorageComputer$1000.0 + MagicNumber:StorageComputer.kt$StorageComputer$500 + MagicNumber:StorageComputer.kt$StorageComputer$999950 + MagicNumber:TOSFragment.kt$TOSFragment$20 + MaxLineLength:AppInstallProcessor.kt$AppInstallProcessor$"Enqueuing App install work is failed for ${fusedDownload.packageName} exception: ${e.localizedMessage}" + MaxLineLength:AppInstallProcessor.kt$AppInstallProcessor$fusedDownload.areFilesDownloaded() && (!fusedManagerRepository.isFusedDownloadInstalled(fusedDownload) || fusedDownload.status == Status.INSTALLING) + MaxLineLength:AppPrivacyInfo.kt$AppPrivacyInfo + MaxLineLength:ApplicationDiffUtil.kt$ApplicationDiffUtil$((oldItem.trackers == LIST_OF_NULL && newItem.trackers.isEmpty()) || oldItem.trackers == newItem.trackers) + MaxLineLength:ApplicationFragment.kt$ApplicationFragment.Companion$"https://gitlab.e.foundation/e/os/apps/-/blob/main/app/src/main/java/foundation/e/apps/data/exodus/repositories/PrivacyScoreRepositoryImpl.kt" + MaxLineLength:CommonUtilsModule.kt$CommonUtilsModule$* + MaxLineLength:DownloadManager.kt$DownloadManager$Timber.e("Download Issue: $downloadId : DownloadManager returns status: $status but the failed because: reason: $reason") + MaxLineLength:DownloadManagerUtils.kt$DownloadManagerUtils$"Download failed for ${fusedDownload.packageName}, " + "reason: " + "${downloadManager.getDownloadFailureReason(downloadId)}" + MaxLineLength:DownloadManagerUtils.kt$DownloadManagerUtils$Timber.d("===> updateDownloadStatus: ${fusedDownload.name}: $downloadId: $numberOfDownloadedItems/${fusedDownload.downloadIdMap.size}") + MaxLineLength:DownloadManagerUtils.kt$DownloadManagerUtils$if + MaxLineLength:DownloadManagerUtils.kt$DownloadManagerUtils$numberOfDownloadedItems == fusedDownload.downloadIdMap.size && numberOfDownloadedItems == fusedDownload.downloadURLList.size + MaxLineLength:DownloadProgressLD.kt$DownloadProgressLD$cursor.getLong(cursor.getColumnIndexOrThrow(DownloadManager.COLUMN_BYTES_DOWNLOADED_SO_FAR)) + MaxLineLength:DownloadProgressLD.kt$DownloadProgressLD$cursor.getLong(cursor.getColumnIndexOrThrow(DownloadManager.COLUMN_TOTAL_SIZE_BYTES)) + MaxLineLength:DownloadProgressLD.kt$DownloadProgressLD$status == DownloadManager.STATUS_SUCCESSFUL || status == DownloadManager.STATUS_FAILED + MaxLineLength:FdroidRepository.kt$FdroidRepository$override suspend + MaxLineLength:FusedApi.kt$FusedApi$suspend fun getGplayAppsByCategory(authData: AuthData, category: String, pageUrl: String?): ResultSupreme<Pair<List<FusedApp>, String>> + MaxLineLength:FusedApiImpl.kt$FusedApiImpl$val hasGplayLimitedResult = gplayHomes.any { fusedHome -> fusedHome.list.size < THRESHOLD_LIMITED_RESULT_HOME_PAGE } + MaxLineLength:FusedManagerImpl.kt$FusedManagerImpl$. + MaxLineLength:FusedManagerImpl.kt$FusedManagerImpl$return + MaxLineLength:FusedManagerRepository.kt$FusedManagerRepository$downloadList.find { it.origin == app.origin && (it.packageName == app.package_name || it.id == app.package_name) } + MaxLineLength:FusedManagerRepository.kt$FusedManagerRepository$return fdroidRepository.isFdroidApplicationSigned(context, fusedDownload.packageName, apkFilePath, fusedDownload.signature) + MaxLineLength:MainActivity.kt$MainActivity$if + MaxLineLength:MainActivityViewModel.kt$MainActivityViewModel$fusedDownload.origin == it.origin && (fusedDownload.packageName == it.package_name || fusedDownload.id == it._id) + MaxLineLength:PlayStoreRepository.kt$PlayStoreRepository$suspend fun getSearchResult(query: String, subBundle: MutableSet<SearchBundle.SubBundle>?): Pair<List<App>, MutableSet<SearchBundle.SubBundle>> + MaxLineLength:PlayStoreRepositoryImpl.kt$PlayStoreRepositoryImpl$context.getString(R.string.movers_shakers_apps) to mapOf(Chart.MOVERS_SHAKERS to TopChartsHelper.Type.APPLICATION) + MaxLineLength:PlayStoreRepositoryImpl.kt$PlayStoreRepositoryImpl$context.getString(R.string.topselling_free_apps) to mapOf(Chart.TOP_SELLING_FREE to TopChartsHelper.Type.APPLICATION) + MaxLineLength:PrivacyScoreRepositoryImpl.kt$PrivacyScoreRepositoryImpl$return if (numberOfTrackers > THRESHOLD_OF_NON_ZERO_TRACKER_SCORE) MIN_TRACKER_SCORE else MAX_TRACKER_SCORE - numberOfTrackers + MaxLineLength:SettingsFragment.kt$SettingsFragment$showAllApplications?.isChecked == true || showFOSSApplications?.isChecked == true || showPWAApplications?.isChecked == true + MaxLineLength:UpdatesNotifier.kt$UpdatesNotifier$notificationBuilder.setContentText(context.getString(R.string.automatically_install_updates_notification_text)) + MaxLineLength:UpdatesViewModel.kt$UpdatesViewModel$return updatesList.value?.first?.any { it.status == Status.UPDATABLE || it.status == Status.INSTALLATION_ISSUE } == true + MaxLineLength:UpdatesWorker.kt$UpdatesWorker$applicationContext.checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) == PackageManager.PERMISSION_GRANTED + MayBeConst:EcloudApiInterface.kt$EcloudApiInterface.Companion$val BASE_URL = "https://eu.gtoken.ecloud.global/" + NestedBlockDepth:DownloadManager.kt$DownloadManager$fun checkDownloadProgress( downloadId: Long, filePath: String = "", downloadCompleted: ((Boolean, String) -> Unit)? ) + NestedBlockDepth:FusedApiImpl.kt$FusedApiImpl$private suspend fun generateCleanAPKHome(home: Home, appType: String): List<FusedHome> + NestedBlockDepth:PWAManagerModule.kt$PWAManagerModule$fun getPwaStatus(fusedApp: FusedApp): Status + NestedBlockDepth:PkgManagerBR.kt$PkgManagerBR$override fun onReceive(context: Context?, intent: Intent?) + NestedBlockDepth:SettingsFragment.kt$SettingsFragment$override fun onViewCreated(view: View, savedInstanceState: Bundle?) + PrintStackTrace:CommonUtilsModule.kt$CommonUtilsModule$e + PrintStackTrace:EcloudRepository.kt$EcloudRepository$e + PrintStackTrace:InstallWorkManager.kt$InstallWorkManager$e + PrintStackTrace:PkgManagerModule.kt$PkgManagerModule$e + PrintStackTrace:PlayStoreAuthenticator.kt$PlayStoreAuthenticator$e + PrintStackTrace:SystemInfoProvider.kt$SystemInfoProvider$e + ProtectedMemberInFinalClass:ApplicationListFragment.kt$ApplicationListFragment$// protected to avoid SyntheticAccessor protected val args: ApplicationListFragmentArgs by navArgs() + ProtectedMemberInFinalClass:ApplicationListFragment.kt$ApplicationListFragment$// protected to avoid SyntheticAccessor protected val viewModel: ApplicationListViewModel by viewModels() + ProtectedMemberInFinalClass:GoogleSignInFragment.kt$GoogleSignInFragment$// protected to avoid SyntheticAccessor protected val viewModel: LoginViewModel by lazy { ViewModelProvider(requireActivity())[LoginViewModel::class.java] } + ProtectedMemberInFinalClass:MainActivityViewModel.kt$MainActivityViewModel$protected fun ProducerScope<Boolean>.sendInternetStatus(connectivityManager: ConnectivityManager) + ProtectedMemberInFinalClass:SearchFragment.kt$SearchFragment$protected val searchViewModel: SearchViewModel by viewModels() + ReturnCount:ApkSignatureManager.kt$ApkSignatureManager$private fun verifyAPKSignature( apkInputStream: BufferedInputStream, apkSignatureInputStream: InputStream, publicKeyInputStream: InputStream, packageName: String ): Boolean + ReturnCount:AppInstallProcessor.kt$AppInstallProcessor$private suspend fun updateDownloadUrls(fusedDownload: FusedDownload): Boolean + ReturnCount:AppInstallProcessor.kt$AppInstallProcessor$suspend fun enqueueFusedDownload( fusedDownload: FusedDownload, isAnUpdate: Boolean = false ) + ReturnCount:AppPrivacyInfoRepositoryImpl.kt$AppPrivacyInfoRepositoryImpl$override suspend fun getAppPrivacyInfo( fusedApp: FusedApp, appHandle: String ): Result<AppPrivacyInfo> + ReturnCount:AppPrivacyInfoRepositoryImpl.kt$AppPrivacyInfoRepositoryImpl$private fun getAppPrivacyInfo( fusedApp: FusedApp, appTrackerData: List<Report>, ): AppPrivacyInfo + ReturnCount:DownloadManager.kt$DownloadManager$fun getSizeRequired(downloadId: Long): Long + ReturnCount:DownloadManager.kt$DownloadManager$private fun sanitizeStatus(downloadId: Long, status: Int, reason: Int): Int + ReturnCount:Extensions.kt$fun Context.isNetworkAvailable(): Boolean + ReturnCount:FusedApiImpl.kt$FusedApiImpl$override fun isAnyFusedAppUpdated( newFusedApps: List<FusedApp>, oldFusedApps: List<FusedApp> ): Boolean + ReturnCount:FusedApiImpl.kt$FusedApiImpl$override fun isHomeDataUpdated( newHomeData: List<FusedHome>, oldHomeData: List<FusedHome> ): Boolean + ReturnCount:FusedApiImpl.kt$FusedApiImpl$private fun areFusedAppsUpdated( oldFusedHome: FusedHome, newFusedHome: FusedHome, ): Boolean + ReturnCount:FusedManagerRepository.kt$FusedManagerRepository$suspend fun addDownload(fusedDownload: FusedDownload): Boolean + ReturnCount:FusedManagerRepository.kt$FusedManagerRepository$suspend fun calculateProgress( fusedApp: FusedApp?, progress: DownloadProgress ): Int + ReturnCount:PlayStoreAuthenticator.kt$PlayStoreAuthenticator$override suspend fun validateAuthData(): ResultSupreme<AuthData?> + ReturnCount:PlayStoreAuthenticator.kt$PlayStoreAuthenticator$private suspend fun getAuthDataWithGoogleAccount(): ResultSupreme<AuthData?> + ReturnCount:StorageNotificationManager.kt$StorageNotificationManager$private fun getSpaceMissing(fusedDownload: FusedDownload, downloadId: Long? = null): Long + ReturnCount:UpdatesManagerImpl.kt$UpdatesManagerImpl$private suspend fun calculateSignatureVersion(latestCleanapkApp: FusedApp): String + SpreadOperator:DownloadProgressLD.kt$DownloadProgressLD$(*downloadingIds.toLongArray()) + SpreadOperator:EglExtensionProvider.kt$EglExtensionProvider$(*`as`) + SpreadOperator:NativeDeviceInfoProviderModule.kt$NativeDeviceInfoProviderModule$(*context.assets.locales) + SpreadOperator:NativeDeviceInfoProviderModule.kt$NativeDeviceInfoProviderModule$(*systemSharedLibraryNames) + SwallowedException:AppInfoFetchViewModel.kt$AppInfoFetchViewModel$e: Exception + SwallowedException:AppInstallProcessor.kt$AppInstallProcessor$e: ApiException.AppNotPurchased + SwallowedException:ApplicationViewModel.kt$ApplicationViewModel$e: ApiException.AppNotFound + SwallowedException:ApplicationViewModel.kt$ApplicationViewModel$e: Exception + SwallowedException:GPlayHttpClient.kt$GPlayHttpClient$e: Exception + SwallowedException:NativeDeviceInfoProviderModule.kt$NativeDeviceInfoProviderModule$e: Exception + SwallowedException:NativeGsfVersionProvider.kt$NativeGsfVersionProvider$e: PackageManager.NameNotFoundException + SwallowedException:PkgManagerModule.kt$PkgManagerModule$e: PackageManager.NameNotFoundException + SwallowedException:UpdatesManagerImpl.kt$UpdatesManagerImpl$e: Exception + TooGenericExceptionCaught:AnonymousLoginManager.kt$AnonymousLoginManager$e: Exception + TooGenericExceptionCaught:ApiCaller.kt$e: Exception + TooGenericExceptionCaught:ApkSignatureManager.kt$ApkSignatureManager$e: Exception + TooGenericExceptionCaught:AppInfoFetchViewModel.kt$AppInfoFetchViewModel$e: Exception + TooGenericExceptionCaught:AppInstallProcessor.kt$AppInstallProcessor$e: Exception + TooGenericExceptionCaught:ApplicationViewModel.kt$ApplicationViewModel$e: Exception + TooGenericExceptionCaught:BlockedAppRepository.kt$BlockedAppRepository$exception: Exception + TooGenericExceptionCaught:CommonUtilsModule.kt$CommonUtilsModule$e: Exception + TooGenericExceptionCaught:DownloadManager.kt$DownloadManager$e: Exception + TooGenericExceptionCaught:DownloadManager.kt$DownloadManager$e: RuntimeException + TooGenericExceptionCaught:DownloadManager.kt$DownloadManager$exception: Exception + TooGenericExceptionCaught:DownloadProgressLD.kt$DownloadProgressLD$e: Exception + TooGenericExceptionCaught:EcloudRepository.kt$EcloudRepository$e: Exception + TooGenericExceptionCaught:FileManager.kt$FileManager$e: Exception + TooGenericExceptionCaught:FusedApiImpl.kt$FusedApiImpl$e: Exception + TooGenericExceptionCaught:FusedManagerImpl.kt$FusedManagerImpl$e: Exception + TooGenericExceptionCaught:GPlayHttpClient.kt$GPlayHttpClient$e: Exception + TooGenericExceptionCaught:GoogleLoginManager.kt$GoogleLoginManager$e: Exception + TooGenericExceptionCaught:InstallWorkManager.kt$InstallWorkManager$e: Exception + TooGenericExceptionCaught:LocaleChangedBroadcastReceiver.kt$LocaleChangedBroadcastReceiver$ex: Exception + TooGenericExceptionCaught:NativeDeviceInfoProviderModule.kt$NativeDeviceInfoProviderModule$e: Exception + TooGenericExceptionCaught:NetworkHandler.kt$e: Exception + TooGenericExceptionCaught:PWAManagerModule.kt$PWAManagerModule$e: Exception + TooGenericExceptionCaught:PWAPlayerStatusReceiver.kt$PWAPlayerStatusReceiver$e: Exception + TooGenericExceptionCaught:PkgManagerModule.kt$PkgManagerModule$e: Exception + TooGenericExceptionCaught:PlayStoreAuthenticator.kt$PlayStoreAuthenticator$e: Exception + TooGenericExceptionCaught:RetrofitModule.kt$RetrofitModule$e: Exception + TooGenericExceptionCaught:SystemInfoProvider.kt$SystemInfoProvider$e: Exception + TooGenericExceptionCaught:UpdatesManagerImpl.kt$UpdatesManagerImpl$e: Exception + TooGenericExceptionCaught:UpdatesWorker.kt$UpdatesWorker$e: Throwable + TooGenericExceptionThrown:AnonymousLoginManager.kt$AnonymousLoginManager$throw Exception( "Error fetching Anonymous credentials\n" + "Network code: ${response.code}\n" + "Success: ${response.isSuccessful}" + response.errorString.run { if (isNotBlank()) "\nError message: $this" else "" } ) + TooGenericExceptionThrown:PlayStoreLoginWrapper.kt$PlayStoreLoginWrapper$throw Exception("Validation network code: ${response.code}") + TooGenericExceptionThrown:PlayStoreLoginWrapper.kt$PlayStoreLoginWrapper$throw Exception(error) + TooManyFunctions:AppInstallProcessor.kt$AppInstallProcessor + TooManyFunctions:AppPrivacyInfoRepositoryImpl.kt$AppPrivacyInfoRepositoryImpl : IAppPrivacyInfoRepository + TooManyFunctions:ApplicationFragment.kt$ApplicationFragment : TimeoutFragment + TooManyFunctions:ApplicationListFragment.kt$ApplicationListFragment : TimeoutFragmentFusedAPIInterface + TooManyFunctions:ApplicationListRVAdapter.kt$ApplicationListRVAdapter : ListAdapter + TooManyFunctions:DownloadManager.kt$DownloadManager + TooManyFunctions:FusedAPIRepository.kt$FusedAPIRepository + TooManyFunctions:FusedApi.kt$FusedApi + TooManyFunctions:FusedApiImpl.kt$FusedApiImpl : FusedApi + TooManyFunctions:FusedManagerImpl.kt$FusedManagerImpl : IFusedManager + TooManyFunctions:FusedManagerRepository.kt$FusedManagerRepository + TooManyFunctions:GPlayHttpClient.kt$GPlayHttpClient : IHttpClient + TooManyFunctions:HomeChildRVAdapter.kt$HomeChildRVAdapter : ListAdapter + TooManyFunctions:HomeFragment.kt$HomeFragment : TimeoutFragmentFusedAPIInterface + TooManyFunctions:IFusedManager.kt$IFusedManager + TooManyFunctions:LoginData.kt$LoginData + TooManyFunctions:MainActivity.kt$MainActivity : AppCompatActivity + TooManyFunctions:MainActivityViewModel.kt$MainActivityViewModel : ViewModel + TooManyFunctions:PkgManagerModule.kt$PkgManagerModule + TooManyFunctions:PlayStoreAuthenticator.kt$PlayStoreAuthenticator : StoreAuthenticatorAuthDataValidator + TooManyFunctions:PlayStoreRepositoryImpl.kt$PlayStoreRepositoryImpl : PlayStoreRepository + TooManyFunctions:RetrofitModule.kt$RetrofitModule + TooManyFunctions:SearchFragment.kt$SearchFragment : TimeoutFragmentOnQueryTextListenerOnSuggestionListenerFusedAPIInterface + TooManyFunctions:TimeoutFragment.kt$TimeoutFragment : Fragment + TooManyFunctions:UpdatesFragment.kt$UpdatesFragment : TimeoutFragmentFusedAPIInterface + TooManyFunctions:UpdatesManagerImpl.kt$UpdatesManagerImpl + TooManyFunctions:UpdatesWorker.kt$UpdatesWorker : CoroutineWorker + UnusedParameter:ApplicationFragment.kt$ApplicationFragment$it: ImageView + UnusedParameter:FusedAPIRepository.kt$FusedAPIRepository$authData: AuthData + UnusedParameter:FusedApiImpl.kt$FusedApiImpl$source: String = CleanApkRetrofit.APP_SOURCE_FOSS + UnusedParameter:SearchViewModel.kt$SearchViewModel$lifecycleOwner: LifecycleOwner + UnusedPrivateMember:HomeFragment.kt$HomeFragment$private fun onTosAccepted(isTosAccepted: Boolean) + UnusedPrivateProperty:AppInfoFetchViewModel.kt$AppInfoFetchViewModel$val authData = gson.fromJson(dataStoreModule.getAuthDataSync(), AuthData::class.java) + UnusedPrivateProperty:GPlayHttpClient.kt$GPlayHttpClient.Companion$private const val SEARCH = "search" + UnusedPrivateProperty:MainActivityViewModel.kt$MainActivityViewModel.Companion$private const val TAG = "MainActivityViewModel" + UnusedPrivateProperty:UpdatesFragment.kt$UpdatesFragment$val interval = updatesViewModel.getUpdateInterval() + + diff --git a/build.gradle b/build.gradle index f8b70e1c3..4069cac69 100644 --- a/build.gradle +++ b/build.gradle @@ -26,13 +26,13 @@ subprojects { ) config.setFrom("detekt.yml") - + baseline = file("detekt-baseline.xml") parallel = false buildUponDefaultConfig = true allRules = false disableDefaultRuleSets = false debug = false - ignoreFailures = true + ignoreFailures = false basePath = projectDir } } -- GitLab From b2dcbbf7fe6d67b23de95f49395de463fc0d94bb Mon Sep 17 00:00:00 2001 From: Jonathan Klee Date: Fri, 20 Oct 2023 11:46:02 +0200 Subject: [PATCH 2/2] Detekt: Authorize all comments --- detekt.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/detekt.yml b/detekt.yml index 33b730c84..4f6148616 100644 --- a/detekt.yml +++ b/detekt.yml @@ -1,6 +1,15 @@ +# Naming rules naming: + ConstructorParameterNaming: active: false + VariableNaming: active: false + +# Style rules +style: + + ForbiddenComment: + active: false -- GitLab