From 3b2b77fb5f7bea82ce446b4f2814a317d37d97a2 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 17 Oct 2023 17:36:37 +0530 Subject: [PATCH 1/3] update navigation lib version --- app/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index 1a50799bb..3a9e2ca48 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -214,7 +214,7 @@ dependencies { implementation "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.11.2" // Navigation Components - def navigation_version = "2.5.3" + def navigation_version = "2.6.0" implementation "androidx.navigation:navigation-fragment-ktx:$navigation_version" implementation "androidx.navigation:navigation-ui-ktx:$navigation_version" -- GitLab From 1f0cb655bc54da0df82c6b60c7b30223d6747611 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 17 Oct 2023 17:37:14 +0530 Subject: [PATCH 2/3] add null check --- .../foundation/e/apps/ui/application/ApplicationFragment.kt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/foundation/e/apps/ui/application/ApplicationFragment.kt b/app/src/main/java/foundation/e/apps/ui/application/ApplicationFragment.kt index a71ef5263..50efaa8ae 100644 --- a/app/src/main/java/foundation/e/apps/ui/application/ApplicationFragment.kt +++ b/app/src/main/java/foundation/e/apps/ui/application/ApplicationFragment.kt @@ -772,7 +772,8 @@ class ApplicationFragment : TimeoutFragment(R.layout.fragment_application) { if (fusedApp.is_pwa) { pwaManagerModule.launchPwa(fusedApp) } else { - startActivity(pkgManagerModule.getLaunchIntent(fusedApp.package_name)) + pkgManagerModule.getLaunchIntent(fusedApp.package_name) + ?.run { startActivity(this) } } } } -- GitLab From bb2538e2ec3afcfc9d3b6e4bf3a9b0c146ae617c Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Wed, 18 Oct 2023 13:16:36 +0530 Subject: [PATCH 3/3] suggestion --- .../foundation/e/apps/ui/application/ApplicationFragment.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/foundation/e/apps/ui/application/ApplicationFragment.kt b/app/src/main/java/foundation/e/apps/ui/application/ApplicationFragment.kt index 50efaa8ae..e20565ce8 100644 --- a/app/src/main/java/foundation/e/apps/ui/application/ApplicationFragment.kt +++ b/app/src/main/java/foundation/e/apps/ui/application/ApplicationFragment.kt @@ -772,8 +772,8 @@ class ApplicationFragment : TimeoutFragment(R.layout.fragment_application) { if (fusedApp.is_pwa) { pwaManagerModule.launchPwa(fusedApp) } else { - pkgManagerModule.getLaunchIntent(fusedApp.package_name) - ?.run { startActivity(this) } + val launchIntent = pkgManagerModule.getLaunchIntent(fusedApp.package_name) + launchIntent?.run { startActivity(this) } } } } -- GitLab