From 2dc9e315e5131172d6d8220a45de22e2689c4734 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Mon, 12 Jun 2023 09:20:53 +0530 Subject: [PATCH 01/38] update lint.xml --- lint.xml | 3 --- 1 file changed, 3 deletions(-) diff --git a/lint.xml b/lint.xml index f272eed7c..7482312db 100644 --- a/lint.xml +++ b/lint.xml @@ -9,8 +9,5 @@ - - - -- GitLab From 64277e6fe5c8e353bbadad44ad09175f18a46649 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Mon, 12 Jun 2023 10:14:01 +0530 Subject: [PATCH 02/38] add notification permission and permission check --- app/src/main/AndroidManifest.xml | 1 + .../e/apps/install/updates/UpdatesNotifier.kt | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index daa989f11..40bb2c1de 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -13,6 +13,7 @@ + Date: Mon, 12 Jun 2023 11:25:23 +0530 Subject: [PATCH 03/38] fix hardcoded sdcard path --- app/src/main/java/foundation/e/apps/data/DownloadManager.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/foundation/e/apps/data/DownloadManager.kt b/app/src/main/java/foundation/e/apps/data/DownloadManager.kt index 37461b80e..7fbad9239 100644 --- a/app/src/main/java/foundation/e/apps/data/DownloadManager.kt +++ b/app/src/main/java/foundation/e/apps/data/DownloadManager.kt @@ -20,6 +20,7 @@ package foundation.e.apps.data import android.app.DownloadManager import android.content.Context import android.net.Uri +import android.os.Environment import dagger.hilt.android.qualifiers.ApplicationContext import foundation.e.apps.OpenForTesting import foundation.e.apps.R @@ -48,7 +49,8 @@ class DownloadManager @Inject constructor( private val downloadsMaps = HashMap() companion object { - const val EXTERNAL_STORAGE_TEMP_CACHE_DIR = "/sdcard/Download/AppLounge/SplitInstallApks" + private val SDCARD_PATH = Environment.getExternalStorageDirectory().absolutePath + val EXTERNAL_STORAGE_TEMP_CACHE_DIR = "$SDCARD_PATH/Download/AppLounge/SplitInstallApks" } fun downloadFileInCache( -- GitLab From 0e0ec1182186eb8cac42d2dc776a2a7ffb869467 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 13 Jun 2023 05:39:18 +0530 Subject: [PATCH 04/38] lint.xml - warn for outdated gradle dependencies --- lint.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lint.xml b/lint.xml index 7482312db..d06a2712c 100644 --- a/lint.xml +++ b/lint.xml @@ -9,5 +9,8 @@ + + + -- GitLab From b8dfcd5224d8b9d4ef3e20d91ce2b888a1e56bab Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 13 Jun 2023 08:16:01 +0530 Subject: [PATCH 05/38] use timber instead of log --- .../java/foundation/e/apps/data/cleanapk/RetrofitModule.kt | 4 +++- .../e/apps/install/updates/UpdatesWorkManager.kt | 7 +++++-- .../e/apps/ui/applicationlist/ApplicationListRVAdapter.kt | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/foundation/e/apps/data/cleanapk/RetrofitModule.kt b/app/src/main/java/foundation/e/apps/data/cleanapk/RetrofitModule.kt index 7b46568dc..93ade0e79 100644 --- a/app/src/main/java/foundation/e/apps/data/cleanapk/RetrofitModule.kt +++ b/app/src/main/java/foundation/e/apps/data/cleanapk/RetrofitModule.kt @@ -50,6 +50,7 @@ import java.net.ConnectException import java.util.Locale import javax.inject.Named import javax.inject.Singleton +import timber.log.Timber @Module @InstallIn(SingletonComponent::class) @@ -193,7 +194,8 @@ object RetrofitModule { e: Exception, chain: Interceptor.Chain ): Response { - Log.e("Retrofit", "buildErrorResponse: ${e.localizedMessage}") + Timber.tag("Retrofit") + Timber.e("buildErrorResponse: ${e.localizedMessage}") return Response.Builder() .code(999) .message(e.localizedMessage ?: "Unknown error") diff --git a/app/src/main/java/foundation/e/apps/install/updates/UpdatesWorkManager.kt b/app/src/main/java/foundation/e/apps/install/updates/UpdatesWorkManager.kt index 895ebf020..cf3b022e5 100644 --- a/app/src/main/java/foundation/e/apps/install/updates/UpdatesWorkManager.kt +++ b/app/src/main/java/foundation/e/apps/install/updates/UpdatesWorkManager.kt @@ -28,6 +28,7 @@ import androidx.work.OneTimeWorkRequest import androidx.work.PeriodicWorkRequest import androidx.work.WorkManager import java.util.concurrent.TimeUnit +import timber.log.Timber object UpdatesWorkManager { private const val UPDATES_WORK_NAME = "updates_work" @@ -72,11 +73,13 @@ object UpdatesWorkManager { interval: Long, existingPeriodicWorkPolicy: ExistingPeriodicWorkPolicy ) { - Log.i(TAG, "UpdatesWorker interval: $interval hours") + Timber.tag(TAG) + Timber.i("UpdatesWorker interval: $interval hours") WorkManager.getInstance(context).enqueueUniquePeriodicWork( UPDATES_WORK_NAME, existingPeriodicWorkPolicy, buildPeriodicWorkRequest(interval) ) - Log.i(TAG, "UpdatesWorker started") + Timber.tag(TAG) + Timber.i("UpdatesWorker started") } } diff --git a/app/src/main/java/foundation/e/apps/ui/applicationlist/ApplicationListRVAdapter.kt b/app/src/main/java/foundation/e/apps/ui/applicationlist/ApplicationListRVAdapter.kt index a552ad664..a9a3243a3 100644 --- a/app/src/main/java/foundation/e/apps/ui/applicationlist/ApplicationListRVAdapter.kt +++ b/app/src/main/java/foundation/e/apps/ui/applicationlist/ApplicationListRVAdapter.kt @@ -173,7 +173,7 @@ class ApplicationListRVAdapter( placeholder(shimmerDrawable) } } - else -> Log.wtf(TAG, "${searchApp.package_name} is from an unknown origin") + else -> Timber.wtf("${searchApp.package_name} is from an unknown origin") } } -- GitLab From 3b8aefb22c1eee3bc0bf677d95984c2fd186ac78 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 13 Jun 2023 08:48:46 +0530 Subject: [PATCH 06/38] check intent action in LocaleChangedBroadcastReceiver --- .../e/apps/ui/setup/signin/LocaleChangedBroadcastReceiver.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/src/main/java/foundation/e/apps/ui/setup/signin/LocaleChangedBroadcastReceiver.kt b/app/src/main/java/foundation/e/apps/ui/setup/signin/LocaleChangedBroadcastReceiver.kt index 5aeda3fb1..dd927f2d9 100644 --- a/app/src/main/java/foundation/e/apps/ui/setup/signin/LocaleChangedBroadcastReceiver.kt +++ b/app/src/main/java/foundation/e/apps/ui/setup/signin/LocaleChangedBroadcastReceiver.kt @@ -48,6 +48,10 @@ class LocaleChangedBroadcastReceiver : BroadcastReceiver() { private val TAG = LocaleChangedBroadcastReceiver::class.java.simpleName override fun onReceive(context: Context, intent: Intent) { + if (intent.action != Intent.ACTION_LOCALE_CHANGED) { + // security measure so that only the android system can call the receiver + return + } GlobalScope.launch { try { val authDataJson = dataStoreModule.getAuthDataSync() -- GitLab From d5849e76db0e5d6cd4a2f633a3115827db686cc5 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 13 Jun 2023 09:48:03 +0530 Subject: [PATCH 07/38] set exported to false for BOOT_COMPLETED and LOCALE_CHANGED receivers --- app/src/main/AndroidManifest.xml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 40bb2c1de..001b48bdb 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -68,7 +68,8 @@ - + @@ -87,7 +88,8 @@ - + -- GitLab From da79ddde7fd7d49615303e4f9886875ff1b21804 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 13 Jun 2023 10:54:18 +0530 Subject: [PATCH 08/38] AppPurchaseFragment: suppress warning about webview javascript --- .../java/foundation/e/apps/ui/purchase/AppPurchaseFragment.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/foundation/e/apps/ui/purchase/AppPurchaseFragment.kt b/app/src/main/java/foundation/e/apps/ui/purchase/AppPurchaseFragment.kt index f9688f226..c84a651cf 100644 --- a/app/src/main/java/foundation/e/apps/ui/purchase/AppPurchaseFragment.kt +++ b/app/src/main/java/foundation/e/apps/ui/purchase/AppPurchaseFragment.kt @@ -1,5 +1,6 @@ package foundation.e.apps.ui.purchase +import android.annotation.SuppressLint import android.os.Build import android.os.Bundle import android.view.LayoutInflater @@ -48,6 +49,7 @@ class AppPurchaseFragment : Fragment() { setupWebView(url) } + @SuppressLint("SetJavaScriptEnabled") private fun setupWebView(url: String) { val cookieManager = CookieManager.getInstance() cookieManager.removeAllCookies(null) @@ -73,7 +75,7 @@ class AppPurchaseFragment : Fragment() { allowContentAccess = true databaseEnabled = true domStorageEnabled = true - javaScriptEnabled = true + javaScriptEnabled = true // Google Play page is tested to not work otherwise cacheMode = WebSettings.LOAD_DEFAULT } loadUrl(url) -- GitLab From 0a339a2dceada0774475b4e949f1cb1c1eaa5789 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 13 Jun 2023 11:21:15 +0530 Subject: [PATCH 09/38] lint.xml - suppress UnusedQuantity --- lint.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lint.xml b/lint.xml index d06a2712c..37e662aad 100644 --- a/lint.xml +++ b/lint.xml @@ -5,6 +5,9 @@ + + + -- GitLab From 8dafee76c543c318ee624d6da71ad4715c44cf8c Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Tue, 13 Jun 2023 11:25:16 +0530 Subject: [PATCH 10/38] remove some unneeded resources causing conflicts with internal resources --- .../apps/ui/settings/RadioButtonPreference.kt | 50 ------------------- .../layout/preference_category_material.xml | 31 ------------ .../layout/preference_widget_radiobutton.xml | 27 ---------- 3 files changed, 108 deletions(-) delete mode 100644 app/src/main/java/foundation/e/apps/ui/settings/RadioButtonPreference.kt delete mode 100644 app/src/main/res/layout/preference_category_material.xml delete mode 100644 app/src/main/res/layout/preference_widget_radiobutton.xml diff --git a/app/src/main/java/foundation/e/apps/ui/settings/RadioButtonPreference.kt b/app/src/main/java/foundation/e/apps/ui/settings/RadioButtonPreference.kt deleted file mode 100644 index 0dcc41d42..000000000 --- a/app/src/main/java/foundation/e/apps/ui/settings/RadioButtonPreference.kt +++ /dev/null @@ -1,50 +0,0 @@ -/* - * Apps Quickly and easily install Android apps onto your device! - * Copyright (C) 2021 E FOUNDATION - * - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . - */ - -package foundation.e.apps.ui.settings - -import android.content.Context -import android.util.AttributeSet -import androidx.preference.CheckBoxPreference -import foundation.e.apps.R - -class RadioButtonPreference : CheckBoxPreference { - - constructor(context: Context, attrs: AttributeSet, defStyle: Int) : super( - context, - attrs, - defStyle - ) { - setView() - } - - constructor(context: Context, attrs: AttributeSet? = null) : super(context, attrs) { - setView() - } - - private fun setView() { - widgetLayoutResource = R.layout.preference_widget_radiobutton - } - - override fun onClick() { - if (this.isChecked) - return - - super.onClick() - } -} diff --git a/app/src/main/res/layout/preference_category_material.xml b/app/src/main/res/layout/preference_category_material.xml deleted file mode 100644 index 9acd4195f..000000000 --- a/app/src/main/res/layout/preference_category_material.xml +++ /dev/null @@ -1,31 +0,0 @@ - - - \ No newline at end of file diff --git a/app/src/main/res/layout/preference_widget_radiobutton.xml b/app/src/main/res/layout/preference_widget_radiobutton.xml deleted file mode 100644 index 179e45da0..000000000 --- a/app/src/main/res/layout/preference_widget_radiobutton.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - -- GitLab From 53ae4db963c09e2ea9fdbf4b3b8ec7053da611bf Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Wed, 14 Jun 2023 10:13:19 +0530 Subject: [PATCH 11/38] suppress ExportedReceiver, ExportedService --- app/src/main/AndroidManifest.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 001b48bdb..508c47af8 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -75,7 +75,9 @@ + @@ -103,8 +105,10 @@ + -- GitLab From 2b23278f44e62d9658df9502bde47b7a75effa60 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Wed, 14 Jun 2023 12:10:33 +0530 Subject: [PATCH 12/38] updated big icons --- .../res/drawable-nodpi/ic_app_updated_on.xml | 26 ------------------- .../main/res/drawable/ic_app_updated_on.xml | 26 +++++++++++++++++++ app/src/main/res/drawable/ic_cat_family.xml | 10 +++---- app/src/main/res/drawable/ic_cat_news.xml | 10 +++---- app/src/main/res/drawable/ic_cat_travel.xml | 10 +++---- 5 files changed, 41 insertions(+), 41 deletions(-) delete mode 100644 app/src/main/res/drawable-nodpi/ic_app_updated_on.xml create mode 100644 app/src/main/res/drawable/ic_app_updated_on.xml diff --git a/app/src/main/res/drawable-nodpi/ic_app_updated_on.xml b/app/src/main/res/drawable-nodpi/ic_app_updated_on.xml deleted file mode 100644 index 5a1af8b80..000000000 --- a/app/src/main/res/drawable-nodpi/ic_app_updated_on.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - - diff --git a/app/src/main/res/drawable/ic_app_updated_on.xml b/app/src/main/res/drawable/ic_app_updated_on.xml new file mode 100644 index 000000000..52dab93ab --- /dev/null +++ b/app/src/main/res/drawable/ic_app_updated_on.xml @@ -0,0 +1,26 @@ + + + + + diff --git a/app/src/main/res/drawable/ic_cat_family.xml b/app/src/main/res/drawable/ic_cat_family.xml index 56499beb0..7f46134ac 100644 --- a/app/src/main/res/drawable/ic_cat_family.xml +++ b/app/src/main/res/drawable/ic_cat_family.xml @@ -17,11 +17,11 @@ --> + android:width="24dp" + android:height="32dp" + android:viewportWidth="32.0" + android:viewportHeight="32.0"> + android:pathData="M16,10c3.68,0 6.67,-2.24 6.67,-5S19.68,0 16,0s-6.67,2.24 -6.67,5 2.98,5 6.67,5zM27.3,13.51l3.57,-1.88c1.21,-0.63 1.5,-1.88 0.65,-2.79 -0.84,-0.91 -2.51,-1.13 -3.72,-0.49l-3.57,1.88c-4.91,2.58 -11.57,2.58 -16.48,0l-3.57,-1.88c-1.21,-0.64 -2.88,-0.41 -3.72,0.49 -0.85,0.91 -0.56,2.15 0.65,2.79l3.57,1.88c1.45,0.76 3.02,1.34 4.63,1.78v2.51c-0.78,0.35 -1.33,0.96 -1.33,1.69v1.17c0,0.39 0.19,0.74 0.47,1.06L5.25,24.75c-0.76,0.71 -0.78,1.72 -0.05,2.45l4,4c0.53,0.52 1.33,0.8 2.13,0.8 0.56,0 1.12,-0.13 1.6,-0.4 1.18,-0.66 1.42,-1.92 0.53,-2.8l-2.76,-2.76 1.52,-1.43c0.94,0.56 2.1,0.89 3.32,0.89h0.92c1.22,0 2.38,-0.32 3.32,-0.89l1.52,1.43 -2.76,2.76c-0.88,0.88 -0.65,2.14 0.53,2.8 0.48,0.27 1.04,0.4 1.6,0.4 0.82,0 1.61,-0.28 2.13,-0.8l4,-4c0.73,-0.73 0.71,-1.74 -0.05,-2.45l-3.22,-3.02c0.28,-0.32 0.47,-0.68 0.47,-1.06L24.02,19.5c0,-0.73 -0.55,-1.34 -1.33,-1.69v-2.51c1.61,-0.44 3.17,-1.02 4.62,-1.78zM21.33,20.67l-2.99,2.24c-0.5,0.38 -1.18,0.59 -1.88,0.59h-0.92c-0.71,0 -1.38,-0.21 -1.88,-0.59L10.67,20.67L10.67,19.5h10.67v1.17z"/> diff --git a/app/src/main/res/drawable/ic_cat_news.xml b/app/src/main/res/drawable/ic_cat_news.xml index 0b9c85f87..b2358ba80 100644 --- a/app/src/main/res/drawable/ic_cat_news.xml +++ b/app/src/main/res/drawable/ic_cat_news.xml @@ -17,11 +17,11 @@ --> + android:width="32dp" + android:height="28dp" + android:viewportWidth="32.0" + android:viewportHeight="32.0"> + android:pathData="M30.67,4L6.22,4c-1.16,0 -2.15,0.84 -2.51,2L1.33,6c-0.74,0 -1.33,0.67 -1.33,1.5v17c0,1.93 1.39,3.5 3.11,3.5h27.56c0.74,0 1.33,-0.67 1.33,-1.5L32,5.5c0,-0.83 -0.6,-1.5 -1.33,-1.5zM2.67,24.5L2.67,9h0.89v15.5c0,0.28 -0.2,0.5 -0.44,0.5s-0.44,-0.22 -0.44,-0.5zM29.33,25L6.19,25c0.02,-0.16 0.03,-0.33 0.03,-0.5L6.22,7h23.11v18zM9.56,17.5h7.56c0.37,0 0.67,-0.34 0.67,-0.75v-6c0,-0.41 -0.3,-0.75 -0.67,-0.75L9.56,10c-0.37,0 -0.67,0.34 -0.67,0.75v6c0,0.41 0.3,0.75 0.67,0.75zM11.11,12.5h4.44v2.5h-4.44v-2.5zM8.89,21.25v-1.5c0,-0.41 0.3,-0.75 0.67,-0.75h7.56c0.37,0 0.67,0.34 0.67,0.75v1.5c0,0.41 -0.3,0.75 -0.67,0.75L9.56,22c-0.37,0 -0.67,-0.34 -0.67,-0.75zM19.56,21.25v-1.5c0,-0.41 0.3,-0.75 0.67,-0.75h5.78c0.37,0 0.67,0.34 0.67,0.75v1.5c0,0.41 -0.3,0.75 -0.67,0.75L20.22,22c-0.37,0 -0.67,-0.34 -0.67,-0.75zM19.56,12.25v-1.5c0,-0.41 0.3,-0.75 0.67,-0.75h5.78c0.37,0 0.67,0.34 0.67,0.75v1.5c0,0.41 -0.3,0.75 -0.67,0.75L20.22,13c-0.37,0 -0.67,-0.34 -0.67,-0.75zM19.56,16.75v-1.5c0,-0.41 0.3,-0.75 0.67,-0.75h5.78c0.37,0 0.67,0.34 0.67,0.75v1.5c0,0.41 -0.3,0.75 -0.67,0.75L20.22,17.5c-0.37,0 -0.67,-0.34 -0.67,-0.75z"/> diff --git a/app/src/main/res/drawable/ic_cat_travel.xml b/app/src/main/res/drawable/ic_cat_travel.xml index d6537df43..6e557fd4c 100644 --- a/app/src/main/res/drawable/ic_cat_travel.xml +++ b/app/src/main/res/drawable/ic_cat_travel.xml @@ -17,11 +17,11 @@ --> + android:width="28dp" + android:height="32dp" + android:viewportWidth="32.0" + android:viewportHeight="32.0"> + android:pathData="M20,20.5c0,-1.38 1.28,-2.5 2.86,-2.5s2.86,1.12 2.86,2.5 -1.28,2.5 -2.86,2.5 -2.86,-1.12 -2.86,-2.5zM9.14,23c1.58,0 2.86,-1.12 2.86,-2.5s-1.28,-2.5 -2.86,-2.5 -2.86,1.12 -2.86,2.5 1.28,2.5 2.86,2.5zM32,6.86v14.29c0,3.07 -3.12,5.66 -7.08,6.54l4.2,3.67c0.27,0.24 0.08,0.64 -0.3,0.64h-3.46a0.86,0.75 0,0 1,-0.61 -0.22L20.43,28L11.57,28l-4.32,3.78A0.86,0.75 0,0 1,6.64 32L3.18,32c-0.38,0 -0.57,-0.4 -0.3,-0.64l4.2,-3.67C3.13,26.81 0,24.23 0,21.14L0,6.86C0,2.87 5.07,0 9.88,0h12.24C26.99,0 32,2.87 32,6.86zM3.63,6h24.75c-0.73,-1.63 -3.43,-3 -6.26,-3L9.88,3c-2.78,0 -5.5,1.35 -6.25,3zM3.43,14h10.86v-5L3.43,9v5zM28.57,17L3.43,17v4.14C3.43,23.41 7.14,25 9.88,25h12.24C24.82,25 28.57,23.43 28.57,21.14L28.57,17zM28.57,9L17.71,9v5h10.86v-5z"/> -- GitLab From 29197dfdc1c600be9fe19f568cf3f610ff651dff Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Wed, 14 Jun 2023 12:18:42 +0530 Subject: [PATCH 13/38] reduce severity of ExpiredTargetSdkVersion --- lint.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lint.xml b/lint.xml index 37e662aad..e332af1ed 100644 --- a/lint.xml +++ b/lint.xml @@ -15,5 +15,8 @@ + + + -- GitLab From 44577fca8cc2e2f7ac52b8010a16d678d2d13548 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Wed, 14 Jun 2023 12:21:00 +0530 Subject: [PATCH 14/38] ignore overriding PrivateResource --- lint.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lint.xml b/lint.xml index e332af1ed..c3be8d079 100644 --- a/lint.xml +++ b/lint.xml @@ -5,6 +5,9 @@ + + + -- GitLab From 41508424bcde4bcbf8c8bc4d0ffbf0023634f734 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Wed, 14 Jun 2023 12:34:58 +0530 Subject: [PATCH 15/38] Pending intent immutable. --- .../java/foundation/e/apps/install/updates/UpdatesNotifier.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/foundation/e/apps/install/updates/UpdatesNotifier.kt b/app/src/main/java/foundation/e/apps/install/updates/UpdatesNotifier.kt index 3105c0076..1d1f42258 100644 --- a/app/src/main/java/foundation/e/apps/install/updates/UpdatesNotifier.kt +++ b/app/src/main/java/foundation/e/apps/install/updates/UpdatesNotifier.kt @@ -103,7 +103,7 @@ object UpdatesNotifier { flags = Intent.FLAG_ACTIVITY_CLEAR_TASK putExtra(UPDATES_NOTIFICATION_CLICK_EXTRA, true) } - return PendingIntent.getActivity(context, 0, intent, 0) + return PendingIntent.getActivity(context, 0, intent, PendingIntent.FLAG_IMMUTABLE) } private fun createNotificationChannel(context: Context) { -- GitLab From fa8692a7e4d9fcfc7c7729495ff70ab7fea2c823 Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Wed, 14 Jun 2023 12:40:04 +0530 Subject: [PATCH 16/38] delete unnecessary @RequiresApi annotation --- .../main/java/foundation/e/apps/install/pkg/InstallerService.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/app/src/main/java/foundation/e/apps/install/pkg/InstallerService.kt b/app/src/main/java/foundation/e/apps/install/pkg/InstallerService.kt index 9c99665ea..386f5e8e1 100644 --- a/app/src/main/java/foundation/e/apps/install/pkg/InstallerService.kt +++ b/app/src/main/java/foundation/e/apps/install/pkg/InstallerService.kt @@ -55,7 +55,6 @@ class InstallerService : Service() { const val INSTALL_FAILED_UPDATE_INCOMPATIBLE = "INSTALL_FAILED_UPDATE_INCOMPATIBLE" } - @RequiresApi(api = Build.VERSION_CODES.LOLLIPOP) override fun onStartCommand(intent: Intent, flags: Int, startId: Int): Int { val status = intent.getIntExtra(PackageInstaller.EXTRA_STATUS, -69) var packageName = intent.getStringExtra(PackageInstaller.EXTRA_PACKAGE_NAME) -- GitLab From bf4afe277452f8cecc376e67107f553269947ccb Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Thu, 15 Jun 2023 05:19:47 +0530 Subject: [PATCH 17/38] suppress UseCompoundDrawables for shimmers --- lint.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lint.xml b/lint.xml index c3be8d079..8be5f2908 100644 --- a/lint.xml +++ b/lint.xml @@ -11,6 +11,11 @@ + + + + + -- GitLab From 309a155c0d394f4d1895b086a7c96d539a1d878d Mon Sep 17 00:00:00 2001 From: Sayantan Roychowdhury Date: Thu, 15 Jun 2023 05:36:32 +0530 Subject: [PATCH 18/38] fragment_application.xml - remote useless view parents --- .../main/res/layout/fragment_application.xml | 208 +++++++++--------- 1 file changed, 99 insertions(+), 109 deletions(-) diff --git a/app/src/main/res/layout/fragment_application.xml b/app/src/main/res/layout/fragment_application.xml index 1d45a7483..e88df680a 100644 --- a/app/src/main/res/layout/fragment_application.xml +++ b/app/src/main/res/layout/fragment_application.xml @@ -50,128 +50,118 @@ android:layout_width="match_parent" android:layout_height="wrap_content"> - + android:layout_height="match_parent" + android:orientation="vertical"> - - - - - - - - - - + android:layout_height="40dp" + android:visibility="gone" + android:layout_marginLeft="20dp" + android:layout_marginRight="20dp" + android:layout_marginTop="20dp" + app:cardElevation="8dp"> - - + + - - - - + android:layout_marginLeft="10dp" + android:layout_marginRight="10dp" + android:gravity="center_vertical" + android:textColor="@android:color/white" + app:drawableLeftCompat="@drawable/ic_warning_white" + android:drawablePadding="15dp" + android:text="@string/this_app_may_not_work_properly" /> - - - + - + + - - - -