From dd746820df570588e672f56794bcdda304f457dc Mon Sep 17 00:00:00 2001 From: hasibprince Date: Fri, 24 Mar 2023 12:38:39 +0600 Subject: [PATCH 1/3] updated some major plugins --- app/build.gradle | 10 ++--- .../java/foundation/e/apps/MainActivity.kt | 3 +- .../e/apps/application/ApplicationFragment.kt | 3 +- .../ApplicationListRVAdapter.kt | 38 +++++++++---------- .../categories/model/CategoriesRVAdapter.kt | 11 +++--- .../e/apps/home/model/HomeChildRVAdapter.kt | 11 +++--- build.gradle | 21 ++++------ gradle/wrapper/gradle-wrapper.properties | 12 +++--- settings.gradle | 7 ++++ 9 files changed, 58 insertions(+), 58 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 8a1d97c8c..5fb7891dc 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -4,8 +4,8 @@ plugins { id 'kotlin-android' id 'kotlin-kapt' id 'org.jlleitschuh.gradle.ktlint' version '10.2.0' - id 'androidx.navigation.safeargs.kotlin' - id 'dagger.hilt.android.plugin' + id 'androidx.navigation.safeargs' + id 'com.google.dagger.hilt.android' id 'kotlin-allopen' } @@ -217,10 +217,10 @@ dependencies { // Hilt def hilt_version = '2.40.5' - kapt "com.google.dagger:hilt-compiler:$hilt_version" - implementation "com.google.dagger:hilt-android:$hilt_version" + kapt "com.google.dagger:hilt-compiler:2.44" + implementation "com.google.dagger:hilt-android:2.44" implementation 'androidx.hilt:hilt-work:1.0.0' - kapt 'androidx.hilt:hilt-compiler:1.0.0' +// kapt 'androidx.hilt:hilt-compiler:1.0.0' // Lifecycle Components def lifecycle_version = "2.4.0" diff --git a/app/src/main/java/foundation/e/apps/MainActivity.kt b/app/src/main/java/foundation/e/apps/MainActivity.kt index dd3b075e2..3e97caf8c 100644 --- a/app/src/main/java/foundation/e/apps/MainActivity.kt +++ b/app/src/main/java/foundation/e/apps/MainActivity.kt @@ -179,7 +179,8 @@ class MainActivity : AppCompatActivity() { viewModel.purchaseAppLiveData.observe(this) { val action = - AppPurchaseFragmentDirections.actionGlobalAppPurchaseFragment(it.packageName) + AppPurchaseFragmentDirections.actionGlobalAppPurchaseFragment() + action.packageName = it.packageName findNavController(R.id.fragment).navigate(action) } diff --git a/app/src/main/java/foundation/e/apps/application/ApplicationFragment.kt b/app/src/main/java/foundation/e/apps/application/ApplicationFragment.kt index 12a9f3bd5..7c30dfbd1 100644 --- a/app/src/main/java/foundation/e/apps/application/ApplicationFragment.kt +++ b/app/src/main/java/foundation/e/apps/application/ApplicationFragment.kt @@ -242,7 +242,8 @@ class ApplicationFragment : TimeoutFragment(R.layout.fragment_application) { binding.appDescriptionMore.setOnClickListener { view -> val action = - ApplicationFragmentDirections.actionApplicationFragmentToDescriptionFragment(it.description) + ApplicationFragmentDirections.actionApplicationFragmentToDescriptionFragment() + action.description = it.description view.findNavController().navigate(action) } } diff --git a/app/src/main/java/foundation/e/apps/applicationlist/ApplicationListRVAdapter.kt b/app/src/main/java/foundation/e/apps/applicationlist/ApplicationListRVAdapter.kt index 79d4abb76..32c79b6c2 100644 --- a/app/src/main/java/foundation/e/apps/applicationlist/ApplicationListRVAdapter.kt +++ b/app/src/main/java/foundation/e/apps/applicationlist/ApplicationListRVAdapter.kt @@ -218,29 +218,29 @@ class ApplicationListRVAdapter( val catText = searchApp.category.ifBlank { optionalCategory } val action = when (currentDestinationId) { R.id.applicationListFragment -> { - ApplicationListFragmentDirections.actionApplicationListFragmentToApplicationFragment( - searchApp._id, - searchApp.package_name, - searchApp.origin, - catText, - ) + val action = ApplicationListFragmentDirections.actionApplicationListFragmentToApplicationFragment(searchApp.package_name) + action.id = searchApp._id + action.packageName = searchApp.package_name + action.origin = searchApp.origin + action.category = catText + action } R.id.searchFragment -> { - SearchFragmentDirections.actionSearchFragmentToApplicationFragment( - searchApp._id, - searchApp.package_name, - searchApp.origin, - catText, - searchApp.isGplayReplaced - ) + val action = SearchFragmentDirections.actionSearchFragmentToApplicationFragment(searchApp.package_name) + action.id = searchApp._id + action.packageName = searchApp.package_name + action.origin = searchApp.origin + action.category = catText + action.isGplayReplaced = searchApp.isGplayReplaced + action } R.id.updatesFragment -> { - UpdatesFragmentDirections.actionUpdatesFragmentToApplicationFragment( - searchApp._id, - searchApp.package_name, - searchApp.origin, - catText, - ) + val action = UpdatesFragmentDirections.actionUpdatesFragmentToApplicationFragment(searchApp.package_name) + action.id = searchApp._id + action.packageName = searchApp.package_name + action.origin = searchApp.origin + action.category = catText + action } else -> null } diff --git a/app/src/main/java/foundation/e/apps/categories/model/CategoriesRVAdapter.kt b/app/src/main/java/foundation/e/apps/categories/model/CategoriesRVAdapter.kt index f98cf1ce7..ab7bf393b 100644 --- a/app/src/main/java/foundation/e/apps/categories/model/CategoriesRVAdapter.kt +++ b/app/src/main/java/foundation/e/apps/categories/model/CategoriesRVAdapter.kt @@ -51,12 +51,11 @@ class CategoriesRVAdapter : holder.binding.apply { categoryLayout.setOnClickListener { val direction = - CategoriesFragmentDirections.actionCategoriesFragmentToApplicationListFragment( - oldList[position].id, - oldList[position].title, - oldList[position].tag.getOperationalTag(), - oldList[position].browseUrl - ) + CategoriesFragmentDirections.actionCategoriesFragmentToApplicationListFragment() + direction.browseUrl = oldList[position].browseUrl + direction.translation = oldList[position].title + direction.source = oldList[position].tag.getOperationalTag() + direction.category = oldList[position].id holder.itemView.findNavController().navigate(direction) } loadCategoryIcon(position) diff --git a/app/src/main/java/foundation/e/apps/home/model/HomeChildRVAdapter.kt b/app/src/main/java/foundation/e/apps/home/model/HomeChildRVAdapter.kt index 8cf88f29c..b22e975a9 100644 --- a/app/src/main/java/foundation/e/apps/home/model/HomeChildRVAdapter.kt +++ b/app/src/main/java/foundation/e/apps/home/model/HomeChildRVAdapter.kt @@ -92,12 +92,11 @@ class HomeChildRVAdapter( } appName.text = homeApp.name homeLayout.setOnClickListener { - val action = HomeFragmentDirections.actionHomeFragmentToApplicationFragment( - homeApp._id, - homeApp.package_name, - homeApp.origin, - homeApp.category - ) + val action = HomeFragmentDirections.actionHomeFragmentToApplicationFragment(homeApp.package_name) + action.id = homeApp._id + action.packageName = homeApp.package_name + action.origin = homeApp.origin + action.category = homeApp.category holder.itemView.findNavController().navigate(action) } diff --git a/build.gradle b/build.gradle index 474556714..eaf255b5e 100644 --- a/build.gradle +++ b/build.gradle @@ -1,19 +1,12 @@ // Top-level build file where you can add configuration options common to all sub-projects/modules. -buildscript { - repositories { - google() - mavenCentral() - } - dependencies { - classpath 'com.android.tools.build:gradle:7.1.0' - classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.10' - classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.3.5" - classpath "com.google.dagger:hilt-android-gradle-plugin:2.40.5" - classpath "org.jetbrains.kotlin:kotlin-allopen:1.6.10" - // NOTE: Do not place your application dependencies here; they belong - // in the individual module build.gradle files - } +plugins { + id 'com.android.application' version '7.4.0' apply false + id 'com.android.library' version '7.4.0' apply false + id 'org.jetbrains.kotlin.android' version '1.7.21' apply false + id 'com.google.dagger.hilt.android' version '2.44' apply false + id "org.jetbrains.kotlin.plugin.allopen" version "1.7.21" + id 'androidx.navigation.safeargs' version '2.5.3' apply false } allprojects { diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index a11cd90bd..6c95afb59 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,6 +1,6 @@ -#Wed Oct 06 09:42:58 IST 2021 -distributionBase=GRADLE_USER_HOME -distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip -distributionPath=wrapper/dists -zipStorePath=wrapper/dists -zipStoreBase=GRADLE_USER_HOME +#Fri Mar 24 11:52:02 BDT 2023 +distributionBase=GRADLE_USER_HOME +distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip +distributionPath=wrapper/dists +zipStorePath=wrapper/dists +zipStoreBase=GRADLE_USER_HOME diff --git a/settings.gradle b/settings.gradle index 3d4996984..4f3c63f18 100644 --- a/settings.gradle +++ b/settings.gradle @@ -1,3 +1,10 @@ +pluginManagement { + repositories { + google() + mavenCentral() + gradlePluginPortal() + } +} dependencyResolutionManagement { repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS) repositories { -- GitLab From ce148ae174c3349eab619519bf627a57ffd30753 Mon Sep 17 00:00:00 2001 From: hasibprince Date: Fri, 24 Mar 2023 13:14:18 +0600 Subject: [PATCH 2/3] resolved hilt dependency --- app/build.gradle | 13 +++++++------ build.gradle | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 5fb7891dc..7e379ac8a 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -42,7 +42,7 @@ def getSentryDsn = { -> } android { - compileSdk 31 + compileSdk 33 defaultConfig { applicationId "foundation.e.apps" @@ -152,8 +152,9 @@ dependencies { implementation 'foundation.e.lib:telemetry:0.0.4-alpha' implementation 'foundation.e:gplayapi:3.0.1' - implementation 'androidx.core:core-ktx:1.7.0' - implementation 'androidx.appcompat:appcompat:1.4.1' + implementation 'androidx.core:core-ktx:1.9.0' + implementation 'androidx.appcompat:appcompat:1.6.1' + implementation 'androidx.fragment:fragment-ktx:1.5.6' implementation 'com.google.android.material:material:1.5.0' implementation 'androidx.constraintlayout:constraintlayout:2.1.3' implementation 'androidx.legacy:legacy-support-v4:1.0.0' @@ -217,13 +218,13 @@ dependencies { // Hilt def hilt_version = '2.40.5' - kapt "com.google.dagger:hilt-compiler:2.44" - implementation "com.google.dagger:hilt-android:2.44" + kapt "com.google.dagger:hilt-compiler:2.44.2" + implementation "com.google.dagger:hilt-android:2.44.2" implementation 'androidx.hilt:hilt-work:1.0.0' // kapt 'androidx.hilt:hilt-compiler:1.0.0' // Lifecycle Components - def lifecycle_version = "2.4.0" + def lifecycle_version = "2.6.0" implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:$lifecycle_version" implementation "androidx.lifecycle:lifecycle-livedata-ktx:$lifecycle_version" implementation "android.arch.lifecycle:extensions:1.1.1" diff --git a/build.gradle b/build.gradle index eaf255b5e..66271133a 100644 --- a/build.gradle +++ b/build.gradle @@ -3,9 +3,9 @@ plugins { id 'com.android.application' version '7.4.0' apply false id 'com.android.library' version '7.4.0' apply false - id 'org.jetbrains.kotlin.android' version '1.7.21' apply false + id 'org.jetbrains.kotlin.android' version '1.8.0' apply false id 'com.google.dagger.hilt.android' version '2.44' apply false - id "org.jetbrains.kotlin.plugin.allopen" version "1.7.21" + id "org.jetbrains.kotlin.plugin.allopen" version "1.8.0" id 'androidx.navigation.safeargs' version '2.5.3' apply false } -- GitLab From 1070210a82c1c5f6245bf04afc5daa7cad0dbd13 Mon Sep 17 00:00:00 2001 From: hasibprince Date: Fri, 24 Mar 2023 17:44:50 +0600 Subject: [PATCH 3/3] updated other dependencies --- app/build.gradle | 26 +++++------ .../java/foundation/e/apps/MainActivity.kt | 3 +- .../foundation/e/apps/api/DownloadManager.kt | 2 +- .../e/apps/application/ApplicationFragment.kt | 5 +-- .../ApplicationListRVAdapter.kt | 43 ++++++++++--------- .../categories/model/CategoriesRVAdapter.kt | 11 ++--- .../e/apps/home/model/HomeChildRVAdapter.kt | 18 +++++--- .../AppInstallProcessorTest.kt | 4 -- .../installProcessor/FakeDownloadManager.kt | 37 ---------------- .../FakeFusedManagerRepository.kt | 3 +- 10 files changed, 60 insertions(+), 92 deletions(-) delete mode 100644 app/src/test/java/foundation/e/apps/installProcessor/FakeDownloadManager.kt diff --git a/app/build.gradle b/app/build.gradle index 7e379ac8a..f311d9a65 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -4,7 +4,7 @@ plugins { id 'kotlin-android' id 'kotlin-kapt' id 'org.jlleitschuh.gradle.ktlint' version '10.2.0' - id 'androidx.navigation.safeargs' + id 'androidx.navigation.safeargs.kotlin' id 'com.google.dagger.hilt.android' id 'kotlin-allopen' } @@ -165,16 +165,16 @@ dependencies { debugImplementation 'com.squareup.leakcanary:leakcanary-android:2.7' testImplementation "com.google.truth:truth:1.1.3" testImplementation 'junit:junit:4.13.2' - androidTestImplementation 'androidx.test.ext:junit:1.1.3' - androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0' + androidTestImplementation 'androidx.test.ext:junit:1.1.5' + androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1' // Optional -- Robolectric environment - testImplementation "androidx.test:core:1.4.0" + testImplementation "androidx.test:core:1.5.0" // Optional -- Mockito framework - testImplementation "org.mockito:mockito-core:4.6.1" + testImplementation "org.mockito:mockito-core:5.0.0" // Optional -- mockito-kotlin - testImplementation "org.mockito.kotlin:mockito-kotlin:3.2.0" - testImplementation 'org.mockito:mockito-inline:2.13.0' - testImplementation "androidx.arch.core:core-testing:2.1.0" + testImplementation "org.mockito.kotlin:mockito-kotlin:4.1.0" + testImplementation 'org.mockito:mockito-inline:5.0.0' + testImplementation "androidx.arch.core:core-testing:2.2.0" testImplementation "io.mockk:mockk:1.12.3" @@ -183,8 +183,8 @@ dependencies { implementation 'com.github.Baseflow:PhotoView:2.3.0' //Protobuf and Gson - implementation 'com.google.code.gson:gson:2.8.9' - implementation "com.google.protobuf:protobuf-java:3.14.0" + implementation 'com.google.code.gson:gson:2.9.0' + implementation "com.google.protobuf:protobuf-java:3.17.2" // ViewPager2 and RecyclerView implementation "androidx.viewpager2:viewpager2:1.0.0" @@ -212,7 +212,7 @@ dependencies { implementation "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.11.2" // Navigation Components - def navigation_version = "2.3.5" + def navigation_version = "2.5.3" implementation "androidx.navigation:navigation-fragment-ktx:$navigation_version" implementation "androidx.navigation:navigation-ui-ktx:$navigation_version" @@ -221,10 +221,10 @@ dependencies { kapt "com.google.dagger:hilt-compiler:2.44.2" implementation "com.google.dagger:hilt-android:2.44.2" implementation 'androidx.hilt:hilt-work:1.0.0' -// kapt 'androidx.hilt:hilt-compiler:1.0.0' + kapt 'androidx.hilt:hilt-compiler:1.0.0' // Lifecycle Components - def lifecycle_version = "2.6.0" + def lifecycle_version = "2.6.1" implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:$lifecycle_version" implementation "androidx.lifecycle:lifecycle-livedata-ktx:$lifecycle_version" implementation "android.arch.lifecycle:extensions:1.1.1" diff --git a/app/src/main/java/foundation/e/apps/MainActivity.kt b/app/src/main/java/foundation/e/apps/MainActivity.kt index 3e97caf8c..dd3b075e2 100644 --- a/app/src/main/java/foundation/e/apps/MainActivity.kt +++ b/app/src/main/java/foundation/e/apps/MainActivity.kt @@ -179,8 +179,7 @@ class MainActivity : AppCompatActivity() { viewModel.purchaseAppLiveData.observe(this) { val action = - AppPurchaseFragmentDirections.actionGlobalAppPurchaseFragment() - action.packageName = it.packageName + AppPurchaseFragmentDirections.actionGlobalAppPurchaseFragment(it.packageName) findNavController(R.id.fragment).navigate(action) } diff --git a/app/src/main/java/foundation/e/apps/api/DownloadManager.kt b/app/src/main/java/foundation/e/apps/api/DownloadManager.kt index a45e47a10..70883b2c5 100644 --- a/app/src/main/java/foundation/e/apps/api/DownloadManager.kt +++ b/app/src/main/java/foundation/e/apps/api/DownloadManager.kt @@ -111,7 +111,7 @@ class DownloadManager @Inject constructor( return downloadId } - private fun checkDownloadProgress( + fun checkDownloadProgress( downloadId: Long, filePath: String = "", downloadCompleted: ((Boolean, String) -> Unit)? diff --git a/app/src/main/java/foundation/e/apps/application/ApplicationFragment.kt b/app/src/main/java/foundation/e/apps/application/ApplicationFragment.kt index 7c30dfbd1..6da3d4929 100644 --- a/app/src/main/java/foundation/e/apps/application/ApplicationFragment.kt +++ b/app/src/main/java/foundation/e/apps/application/ApplicationFragment.kt @@ -242,8 +242,7 @@ class ApplicationFragment : TimeoutFragment(R.layout.fragment_application) { binding.appDescriptionMore.setOnClickListener { view -> val action = - ApplicationFragmentDirections.actionApplicationFragmentToDescriptionFragment() - action.description = it.description + ApplicationFragmentDirections.actionApplicationFragmentToDescriptionFragment(it.description) view.findNavController().navigate(action) } } @@ -387,7 +386,7 @@ class ApplicationFragment : TimeoutFragment(R.layout.fragment_application) { } private fun setupToolbar(view: View) { - val startDestination = findNavController().graph.startDestination + val startDestination = findNavController().graph.startDestinationId if (startDestination == R.id.applicationFragment) { binding.toolbar.setNavigationOnClickListener { val action = ApplicationFragmentDirections.actionApplicationFragmentToHomeFragment() diff --git a/app/src/main/java/foundation/e/apps/applicationlist/ApplicationListRVAdapter.kt b/app/src/main/java/foundation/e/apps/applicationlist/ApplicationListRVAdapter.kt index 32c79b6c2..216b0335c 100644 --- a/app/src/main/java/foundation/e/apps/applicationlist/ApplicationListRVAdapter.kt +++ b/app/src/main/java/foundation/e/apps/applicationlist/ApplicationListRVAdapter.kt @@ -218,29 +218,31 @@ class ApplicationListRVAdapter( val catText = searchApp.category.ifBlank { optionalCategory } val action = when (currentDestinationId) { R.id.applicationListFragment -> { - val action = ApplicationListFragmentDirections.actionApplicationListFragmentToApplicationFragment(searchApp.package_name) - action.id = searchApp._id - action.packageName = searchApp.package_name - action.origin = searchApp.origin - action.category = catText - action + ApplicationListFragmentDirections.actionApplicationListFragmentToApplicationFragment( + searchApp.package_name, + searchApp._id, + searchApp.origin, + catText, + searchApp.isGplayReplaced + ) } R.id.searchFragment -> { - val action = SearchFragmentDirections.actionSearchFragmentToApplicationFragment(searchApp.package_name) - action.id = searchApp._id - action.packageName = searchApp.package_name - action.origin = searchApp.origin - action.category = catText - action.isGplayReplaced = searchApp.isGplayReplaced - action + SearchFragmentDirections.actionSearchFragmentToApplicationFragment( + searchApp.package_name, + searchApp._id, + searchApp.origin, + catText, + searchApp.isGplayReplaced + ) } R.id.updatesFragment -> { - val action = UpdatesFragmentDirections.actionUpdatesFragmentToApplicationFragment(searchApp.package_name) - action.id = searchApp._id - action.packageName = searchApp.package_name - action.origin = searchApp.origin - action.category = catText - action + UpdatesFragmentDirections.actionUpdatesFragmentToApplicationFragment( + searchApp.package_name, + searchApp._id, + searchApp.origin, + catText, + searchApp.isGplayReplaced + ) } else -> null } @@ -479,7 +481,8 @@ class ApplicationListRVAdapter( searchApp.isFree -> { materialButton.enableInstallButton() materialButton.text = materialButton.context.getString(R.string.install) - materialButton.strokeColor = ContextCompat.getColorStateList(holder.itemView.context, R.color.light_grey) + materialButton.strokeColor = + ContextCompat.getColorStateList(holder.itemView.context, R.color.light_grey) applicationListItemBinding.progressBarInstall.visibility = View.GONE } else -> { diff --git a/app/src/main/java/foundation/e/apps/categories/model/CategoriesRVAdapter.kt b/app/src/main/java/foundation/e/apps/categories/model/CategoriesRVAdapter.kt index ab7bf393b..f98cf1ce7 100644 --- a/app/src/main/java/foundation/e/apps/categories/model/CategoriesRVAdapter.kt +++ b/app/src/main/java/foundation/e/apps/categories/model/CategoriesRVAdapter.kt @@ -51,11 +51,12 @@ class CategoriesRVAdapter : holder.binding.apply { categoryLayout.setOnClickListener { val direction = - CategoriesFragmentDirections.actionCategoriesFragmentToApplicationListFragment() - direction.browseUrl = oldList[position].browseUrl - direction.translation = oldList[position].title - direction.source = oldList[position].tag.getOperationalTag() - direction.category = oldList[position].id + CategoriesFragmentDirections.actionCategoriesFragmentToApplicationListFragment( + oldList[position].id, + oldList[position].title, + oldList[position].tag.getOperationalTag(), + oldList[position].browseUrl + ) holder.itemView.findNavController().navigate(direction) } loadCategoryIcon(position) diff --git a/app/src/main/java/foundation/e/apps/home/model/HomeChildRVAdapter.kt b/app/src/main/java/foundation/e/apps/home/model/HomeChildRVAdapter.kt index b22e975a9..3c59b4e44 100644 --- a/app/src/main/java/foundation/e/apps/home/model/HomeChildRVAdapter.kt +++ b/app/src/main/java/foundation/e/apps/home/model/HomeChildRVAdapter.kt @@ -92,11 +92,13 @@ class HomeChildRVAdapter( } appName.text = homeApp.name homeLayout.setOnClickListener { - val action = HomeFragmentDirections.actionHomeFragmentToApplicationFragment(homeApp.package_name) - action.id = homeApp._id - action.packageName = homeApp.package_name - action.origin = homeApp.origin - action.category = homeApp.category + val action = HomeFragmentDirections.actionHomeFragmentToApplicationFragment( + homeApp.package_name, + homeApp._id, + homeApp.origin, + homeApp.category, + homeApp.isGplayReplaced + ) holder.itemView.findNavController().navigate(action) } @@ -235,7 +237,11 @@ class HomeChildRVAdapter( if (homeApp.is_pwa) { mainActivityViewModel.launchPwa(homeApp) } else { - context.startActivity(mainActivityViewModel.getLaunchIntentForPackageName(homeApp.package_name)) + context.startActivity( + mainActivityViewModel.getLaunchIntentForPackageName( + homeApp.package_name + ) + ) } } } diff --git a/app/src/test/java/foundation/e/apps/installProcessor/AppInstallProcessorTest.kt b/app/src/test/java/foundation/e/apps/installProcessor/AppInstallProcessorTest.kt index 5156a7b34..2e62a91ca 100644 --- a/app/src/test/java/foundation/e/apps/installProcessor/AppInstallProcessorTest.kt +++ b/app/src/test/java/foundation/e/apps/installProcessor/AppInstallProcessorTest.kt @@ -56,7 +56,6 @@ class AppInstallProcessorTest { private lateinit var fakeFusedDownloadDAO: FakeFusedDownloadDAO private lateinit var databaseRepository: DatabaseRepository - private lateinit var fakeDownloadManager: DownloadManager private lateinit var fakeFusedManagerRepository: FakeFusedManagerRepository @Mock @@ -86,14 +85,11 @@ class AppInstallProcessorTest { databaseRepository = DatabaseRepository(fakeFusedDownloadDAO) fakeFusedManagerRepository = FakeFusedManagerRepository(fakeFusedDownloadDAO, fakeFusedManager, fakeFdroidRepository) - fakeDownloadManager = - FakeDownloadManager(downloadManager, "/home/data/foundation.e.apps/", query) appInstallProcessor = AppInstallProcessor( context, databaseRepository, fakeFusedManagerRepository, - fakeDownloadManager, dataStoreManager ) } diff --git a/app/src/test/java/foundation/e/apps/installProcessor/FakeDownloadManager.kt b/app/src/test/java/foundation/e/apps/installProcessor/FakeDownloadManager.kt deleted file mode 100644 index 58c38f0a9..000000000 --- a/app/src/test/java/foundation/e/apps/installProcessor/FakeDownloadManager.kt +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright MURENA SAS 2023 - * Apps Quickly and easily install Android apps onto your device! - * - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . - */ - -package foundation.e.apps.installProcessor - -import foundation.e.apps.api.DownloadManager - -class FakeDownloadManager( - downloadManger: android.app.DownloadManager, - cacheDir: String, - query: android.app.DownloadManager.Query -) : DownloadManager(downloadManger, cacheDir, query) { - - override suspend fun checkDownloadProcess( - downloadingIds: LongArray, - handleFailed: suspend () -> Unit - ) { - if (downloadingIds.contains(-1)) { - handleFailed() - } - } -} diff --git a/app/src/test/java/foundation/e/apps/installProcessor/FakeFusedManagerRepository.kt b/app/src/test/java/foundation/e/apps/installProcessor/FakeFusedManagerRepository.kt index 4d3f0e023..8b65b50b5 100644 --- a/app/src/test/java/foundation/e/apps/installProcessor/FakeFusedManagerRepository.kt +++ b/app/src/test/java/foundation/e/apps/installProcessor/FakeFusedManagerRepository.kt @@ -40,11 +40,12 @@ class FakeFusedManagerRepository( fusedDownload.status = Status.DOWNLOADING fusedDownload.downloadIdMap = mutableMapOf(Pair(341, false), Pair(342, false)) fusedDownloadDAO.updateDownload(fusedDownload) - delay(10000) + delay(5000) if (willDownloadFail) { fusedDownload.downloadIdMap.clear() fusedDownload.downloadIdMap = mutableMapOf(Pair(-1, false), Pair(-1, false)) + fusedDownload.status = Status.INSTALLATION_ISSUE fusedDownloadDAO.updateDownload(fusedDownload) return } -- GitLab