From 6dbe9bb030f629333707c7e5dbce4a5346ebf686 Mon Sep 17 00:00:00 2001
From: hasibprince <hasibprince@e.email>
Date: Tue, 14 Mar 2023 14:30:14 +0600
Subject: [PATCH] extracted strings for download notification

---
 app/src/main/java/foundation/e/apps/api/DownloadManager.kt  | 6 +++++-
 .../foundation/e/apps/manager/fused/FusedManagerImpl.kt     | 3 ++-
 app/src/main/res/values/strings.xml                         | 3 ++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/foundation/e/apps/api/DownloadManager.kt b/app/src/main/java/foundation/e/apps/api/DownloadManager.kt
index a755f8030..7dd418154 100644
--- a/app/src/main/java/foundation/e/apps/api/DownloadManager.kt
+++ b/app/src/main/java/foundation/e/apps/api/DownloadManager.kt
@@ -18,8 +18,11 @@
 package foundation.e.apps.api
 
 import android.app.DownloadManager
+import android.content.Context
 import android.net.Uri
+import dagger.hilt.android.qualifiers.ApplicationContext
 import foundation.e.apps.OpenForTesting
+import foundation.e.apps.R
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.delay
@@ -37,6 +40,7 @@ import kotlin.time.Duration.Companion.seconds
 @Singleton
 @OpenForTesting
 class DownloadManager @Inject constructor(
+    @ApplicationContext private val context: Context,
     private val downloadManager: DownloadManager,
     @Named("cacheDir") private val cacheDir: String,
     private val downloadManagerQuery: DownloadManager.Query,
@@ -93,7 +97,7 @@ class DownloadManager @Inject constructor(
         downloadCompleted: ((Boolean, String) -> Unit)?
     ): Long {
         val request = DownloadManager.Request(Uri.parse(url))
-            .setTitle("Downloading...")
+            .setTitle(context.getString(R.string.downloading))
             .setDestinationUri(Uri.fromFile(downloadFile))
         val downloadId = downloadManager.enqueue(request)
         downloadsMaps[downloadId] = true
diff --git a/app/src/main/java/foundation/e/apps/manager/fused/FusedManagerImpl.kt b/app/src/main/java/foundation/e/apps/manager/fused/FusedManagerImpl.kt
index d5f8ad085..51f6fca17 100644
--- a/app/src/main/java/foundation/e/apps/manager/fused/FusedManagerImpl.kt
+++ b/app/src/main/java/foundation/e/apps/manager/fused/FusedManagerImpl.kt
@@ -28,6 +28,7 @@ import android.os.Environment
 import androidx.annotation.RequiresApi
 import androidx.lifecycle.LiveData
 import dagger.hilt.android.qualifiers.ApplicationContext
+import foundation.e.apps.R
 import foundation.e.apps.manager.database.DatabaseRepository
 import foundation.e.apps.manager.database.fusedDownload.FusedDownload
 import foundation.e.apps.manager.download.DownloadManagerBR
@@ -205,7 +206,7 @@ class FusedManagerImpl @Inject constructor(
                 File(parentPath, "${fusedDownload.packageName}_$count.apk")
             }
             val request = DownloadManager.Request(Uri.parse(it))
-                .setTitle(if (count == 1) fusedDownload.name else "Additional file for ${fusedDownload.name}")
+                .setTitle(if (count == 1) fusedDownload.name else context.getString(R.string.additional_file_for, fusedDownload.name))
                 .setDestinationUri(Uri.fromFile(packagePath))
             val requestId = downloadManager.enqueue(request)
             DownloadProgressLD.setDownloadId(requestId)
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 39baaa291..6628e13ca 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -121,7 +121,8 @@
     <string name="why_open_source_version">Why am I seeing the Open Source version?</string>
     <string name="open_source_apps">Open Source apps</string>
     <string name="duplicate_app_from_sources">Some proprietary apps may also have an Open Source version. Whenever this happens App Lounge shows the Open Source version only, in order to avoid duplicates.</string>
-
+    <string name="downloading">Downloading…</string>
+    <string name="additional_file_for">Additional file for %s</string>
 
 
     <!-- Updates Fragment -->
-- 
GitLab