From 0573665f7c5697d6dabe3c848b3d950939c1e556 Mon Sep 17 00:00:00 2001 From: Hasib Prince Date: Fri, 29 Jul 2022 19:38:17 +0600 Subject: [PATCH 1/2] FusedDownload validated before starting installing --- .../e/apps/manager/fused/FusedManagerRepository.kt | 3 +++ .../e/apps/manager/workmanager/InstallAppWorker.kt | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/app/src/main/java/foundation/e/apps/manager/fused/FusedManagerRepository.kt b/app/src/main/java/foundation/e/apps/manager/fused/FusedManagerRepository.kt index adcfbd44e..6ee2081a7 100644 --- a/app/src/main/java/foundation/e/apps/manager/fused/FusedManagerRepository.kt +++ b/app/src/main/java/foundation/e/apps/manager/fused/FusedManagerRepository.kt @@ -83,4 +83,7 @@ class FusedManagerRepository @Inject constructor( suspend fun updateFusedDownload(fusedDownload: FusedDownload) { fusedManagerImpl.updateFusedDownload(fusedDownload) } + + fun validateFusedDownload(fusedDownload: FusedDownload) = + fusedDownload.packageName.isNotEmpty() && fusedDownload.downloadURLList.isNotEmpty() } diff --git a/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt b/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt index e82cc5dad..b2ce37b9a 100644 --- a/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt +++ b/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt @@ -97,6 +97,11 @@ class InstallAppWorker @AssistedInject constructor( "Installing ${it.name}" ) ) + if (!fusedManagerRepository.validateFusedDownload(fusedDownload)) { + fusedManagerRepository.installationIssue(it) + return@let + } + startAppInstallationProcess(it) mutex.lock() } -- GitLab From 4e977c5a54f329e087748a94b3ebd13dd909fea0 Mon Sep 17 00:00:00 2001 From: Fahim Salam Chowdhury Date: Fri, 29 Jul 2022 13:57:01 +0000 Subject: [PATCH 2/2] Apply 1 suggestion(s) to 1 file(s) --- .../foundation/e/apps/manager/workmanager/InstallAppWorker.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt b/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt index b2ce37b9a..00b60ca1e 100644 --- a/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt +++ b/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt @@ -97,6 +97,7 @@ class InstallAppWorker @AssistedInject constructor( "Installing ${it.name}" ) ) + if (!fusedManagerRepository.validateFusedDownload(fusedDownload)) { fusedManagerRepository.installationIssue(it) return@let -- GitLab