From 45e80fdc27429e91c03a04486fff659f8504dc02 Mon Sep 17 00:00:00 2001 From: SayantanRC Date: Wed, 27 Apr 2022 17:57:12 +0530 Subject: [PATCH] App lounge: (issue_5330) Make InstallAppWorker.kt atomicInteger static to properly increment notification ids. --- .../e/apps/manager/workmanager/InstallAppWorker.kt | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt b/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt index 73438981e..f0b50fd91 100644 --- a/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt +++ b/app/src/main/java/foundation/e/apps/manager/workmanager/InstallAppWorker.kt @@ -46,9 +46,18 @@ class InstallAppWorker @AssistedInject constructor( companion object { private const val TAG = "InstallWorker" const val INPUT_DATA_FUSED_DOWNLOAD = "input_data_fused_download" - } - private val atomicInteger = AtomicInteger() + /* + * If this is not "static" then each notification has the same ID. + * Making it static makes sure the id keeps increasing when atomicInteger.getAndIncrement() + * is called. + * This is possible cause for "Installing ..." notification to linger around + * after the app is installed. + * + * Issue: https://gitlab.e.foundation/e/backlog/-/issues/5330 + */ + private val atomicInteger = AtomicInteger(100) + } override suspend fun doWork(): Result { var fusedDownload: FusedDownload? = null -- GitLab