Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5abe5821 authored by Sayantan Roychowdhury's avatar Sayantan Roychowdhury
Browse files

Merge Issue 6559: Better lint fixes

parent 8f9078dc
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -112,6 +112,9 @@ buildReleaseStable:

lintRelease:
  extends: .lintReleaseDefault
  rules:
    - if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
      when: always
  script:
    - ./gradlew lintRelease
  artifacts:
+3 −0
Original line number Diff line number Diff line
@@ -112,6 +112,9 @@ android {
    lint {
        lintConfig file('lint.xml')
    }
    kotlin.sourceSets.all {
        languageSettings.useExperimentalAnnotation("kotlin.RequiresOptIn")
    }
}

kapt {
+1 −2
Original line number Diff line number Diff line
@@ -304,8 +304,7 @@ class MainActivity : AppCompatActivity() {

    // TODO: move storage availability code to FileManager Class
    private fun isStorageAvailable(fusedDownload: FusedDownload): Boolean {
        var availableSpace = 0L
        availableSpace = calculateAvailableDiskSpace()
        val availableSpace = calculateAvailableDiskSpace()
        return availableSpace > fusedDownload.appSize + (500 * (1000 * 1000))
    }

+0 −2
Original line number Diff line number Diff line
@@ -103,8 +103,6 @@ class DownloadManager @Inject constructor(
            downloadManager.query(downloadManagerQuery.setFilterById(downloadId))
                .use { cursor ->
                    if (cursor.moveToFirst()) {
                        val id =
                            cursor.getLong(cursor.getColumnIndexOrThrow(DownloadManager.COLUMN_ID))
                        val status =
                            cursor.getInt(cursor.getColumnIndexOrThrow(DownloadManager.COLUMN_STATUS))
                        val totalSizeBytes =
+4 −4
Original line number Diff line number Diff line
@@ -50,15 +50,15 @@ class BlockedAppRepository @Inject constructor(
    fun fetchUpdateOfAppWarningList() {
        downloadManager.downloadFileInCache(
            APP_WARNING_LIST_FILE_URL,
            fileName = "app-lounge-warning-list.json"
        ) { success, path ->
            fileName = WARNING_LIST_FILE_NAME
        ) { success, _ ->
            if (success) {
                parseBlockedAppDataFromFile(path)
                parseBlockedAppDataFromFile()
            }
        }
    }

    private fun parseBlockedAppDataFromFile(path: String) {
    private fun parseBlockedAppDataFromFile() {
        coroutineScope.launch {
            val outputPath = "$cacheDir/warning_list/"
            FileManager.moveFile("$cacheDir/", WARNING_LIST_FILE_NAME, outputPath)
Loading