Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fdbc565d authored by Steven Moreland's avatar Steven Moreland
Browse files

String8: explicit int -> char cast. 

Since tolower/toupper take and return integer arguments, ascii chars in
the extended range will be converted from positive int values to
negative char values. In order to silence an error here, which was added
recently with integer sanitization here, casting explicitly.

Fixes: 160831549
Test: w/ libutils_fuzz_string8
Change-Id: Iedcd6643f95f84ce662a80e38931d918a200f508
parent c8e4154d

libutils/String8.cpp

+2 −2
Original line number Diff line number Diff line
@@ -424,7 +424,7 @@ void String8::toLower(size_t start, size_t length) 
    char* buf = lockBuffer(len);

    buf += start;

    while (length > 0) {

        *buf = tolower(*buf);

        *buf = static_cast<char>(tolower(*buf));

        buf++;

        length--;

    }
@@ -448,7 +448,7 @@ void String8::toUpper(size_t start, size_t length) 
    char* buf = lockBuffer(len);

    buf += start;

    while (length > 0) {

        *buf = toupper(*buf);

        *buf = static_cast<char>(toupper(*buf));

        buf++;

        length--;

    }