Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9befac6 authored by Paul Lawrence's avatar Paul Lawrence
Browse files

Remove space check from overlayfs test 

This check means that drives are remounted with overlayfs more or less
at random, which means that overlayfs_remounter selinux policy will have
to be very permissive to support all possible remounts.

Test: system/core/fs_mgr/tests/adb-remount-test.sh, confirmation from
reporter that this does indeed fix their issue

Bug: 394657884
Change-Id: I2b340f5df1a609ad5b8e2214bbe7afddec23ca31
parent e0b5b43e

fs_mgr/fs_mgr_overlayfs_mount.cpp

+2 −3
Original line number Diff line number Diff line
@@ -194,9 +194,8 @@ static bool fs_mgr_is_read_only_f2fs(const std::string& dev) { 


static bool fs_mgr_overlayfs_enabled(FstabEntry* entry) {

    // readonly filesystem, can not be mount -o remount,rw

    // for squashfs, erofs or if free space is (near) zero making such a remount

    // virtually useless, or if there are shared blocks that prevent remount,rw

    if (!fs_mgr_filesystem_has_space(entry->mount_point)) {

    // for squashfs, erofs, or if there are shared blocks that prevent remount,rw

    if (entry->fs_type == "erofs" || entry->fs_type == "squashfs") {

        return true;

    }