Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1f06f86 authored by Akilesh Kailash's avatar Akilesh Kailash
Browse files

libsnapshot: Check if OTA update in progress during reboot



If any of the read-only partitions are mounted off dm-user
then certainly update is in-progress.

Bug: 308900853
Test: OTA on Pixel, reboot during OTA.
Change-Id: I36121e1d99ec7c1f1110a65fc67996190875af18
Signed-off-by: default avatarAkilesh Kailash <akailash@google.com>
parent e343580f
Loading
Loading
Loading
Loading
+19 −21
Original line number Diff line number Diff line
@@ -4339,32 +4339,30 @@ std::string SnapshotManager::ReadSourceBuildFingerprint() {
}

bool SnapshotManager::IsUserspaceSnapshotUpdateInProgress() {
    auto slot = GetCurrentSlot();
    if (slot == Slot::Target) {
        // Merge in-progress
        if (IsSnapuserdRequired()) {
            return true;
        }
    }

    // Let's check more deeper to see if snapshots are mounted
    auto lock = LockExclusive();
    if (!lock) {
    // We cannot grab /metadata/ota lock here as this
    // is in reboot path. See b/308900853
    //
    // Check if any of the partitions are mounted
    // off dm-user block device. If so, then we are certain
    // that OTA update in progress.
    auto current_suffix = device_->GetSlotSuffix();
    auto& dm = DeviceMapper::Instance();
    auto dm_block_devices = dm.FindDmPartitions();
    if (dm_block_devices.empty()) {
        LOG(ERROR) << "No dm-enabled block device is found.";
        return false;
    }

    std::vector<std::string> snapshots;
    if (!ListSnapshots(lock.get(), &snapshots)) {
    for (auto& partition : dm_block_devices) {
        std::string partition_name = partition.first + current_suffix;
        DeviceMapper::TargetInfo snap_target;
        if (!GetSingleTarget(partition_name, TableQuery::Status, &snap_target)) {
            return false;
        }

    for (const auto& snapshot : snapshots) {
        // Active snapshot and daemon is alive
        if (IsSnapshotDevice(snapshot) && EnsureSnapuserdConnected(2s)) {
        auto type = DeviceMapper::GetTargetType(snap_target.spec);
        if (type == "user") {
            return true;
        }
    }

    return false;
}