Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb45db2c authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

Revert "logd: remove start filtration from flushTo" 

Regressed by introducing too much overlap in the results.

This reverts commit 982ad208.

Bug: 38341453
Change-Id: I9d630a6b9f3e464f523424b640090f7e268da9bd
parent 982ad208

logd/LogBuffer.cpp

+8 −3
Original line number Diff line number Diff line
@@ -1142,6 +1142,10 @@ log_time LogBuffer::flushTo(SocketClient* reader, const log_time& start, 
            continue;

        }



        if (element->getRealTime() <= start) {

            continue;

        }



        // NB: calling out to another object with wrlock() held (safe)

        if (filter) {

            int ret = (*filter)(element, arg);
@@ -1168,10 +1172,11 @@ log_time LogBuffer::flushTo(SocketClient* reader, const log_time& start, 
        unlock();



        // range locking in LastLogTimes looks after us

        log_time next = element->flushTo(reader, this, privileged, sameTid);

        max = element->flushTo(reader, this, privileged, sameTid);



        if (next == element->FLUSH_ERROR) return next;

        if (next > max) max = next;

        if (max == element->FLUSH_ERROR) {

            return max;

        }



        skip = maxSkip;

        rdlock();