Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e714cde5 authored by Jiyong Park's avatar Jiyong Park
Browse files

Fix a misleading warning message about sysprop overriding 

Regardless of whether a system property is "ro." or not, it can be
overridden by build.prop from the more specific partition. i.e.
foo.bar=true in system/build.prop can be overridden by
foo.bar=false in vendor/build.prop. However, the warning message
was referring the overridden property as "ro." causing confusion
when reading the log. Fix it by not mentioning "ro.".

Bug: 117892318
Test: N/A
Change-Id: I13014522d0c6b507b30c8754e2087fd71cc39971
parent 3447cdc7

init/property_service.cpp

+2 −2
Original line number Diff line number Diff line
@@ -711,8 +711,8 @@ static void LoadProperties(char* data, const char* filter, const char* filename, 
                if (it == properties->end()) {

                    (*properties)[key] = value;

                } else if (it->second != value) {

                    LOG(WARNING) << "Overriding previous 'ro.' property '" << key << "':'"

                                 << it->second << "' with new value '" << value << "'";

                    LOG(WARNING) << "Overriding previous property '" << key << "':'" << it->second

                                 << "' with new value '" << value << "'";

                    it->second = value;

                }

            } else {