Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3d38969 authored by Suren Baghdasaryan's avatar Suren Baghdasaryan
Browse files

libprocessgroup: Fix warnings when legacy schedtune cgroup is absent 



Issue a warning about missing cpu/schedtune controller only if both of
them are missing.

Bug: 185437398
Signed-off-by: default avatarSuren Baghdasaryan <surenb@google.com>
Change-Id: I3a9d3c9a8c91c8d2c5346bcb431bb0407c64a811
parent 26e5d8f1

libprocessgroup/sched_policy.cpp

+10 −6
Original line number Diff line number Diff line
@@ -159,10 +159,9 @@ static int getCGroupSubsys(int tid, const char* subsys, std::string& subgroup) { 


    if (!controller.IsUsable()) return -1;



    if (!controller.GetTaskGroup(tid, &subgroup)) {

        LOG(ERROR) << "Failed to find cgroup for tid " << tid;

    if (!controller.GetTaskGroup(tid, &subgroup))

        return -1;

    }



    return 0;

}
@@ -174,11 +173,16 @@ int get_sched_policy(int tid, SchedPolicy* policy) { 
    std::string group;

    if (schedboost_enabled()) {

        if ((getCGroupSubsys(tid, "schedtune", group) < 0) &&

            (getCGroupSubsys(tid, "cpu", group) < 0))

            (getCGroupSubsys(tid, "cpu", group) < 0)) {

                LOG(ERROR) << "Failed to find cpu cgroup for tid " << tid;

                return -1;

        }

    }

    if (group.empty() && cpusets_enabled()) {

        if (getCGroupSubsys(tid, "cpuset", group) < 0) return -1;

        if (getCGroupSubsys(tid, "cpuset", group) < 0) {

            LOG(ERROR) << "Failed to find cpuset cgroup for tid " << tid;

            return -1;

        }

    }



    // TODO: replace hardcoded directories