Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1797777 authored by Christopher Ferris's avatar Christopher Ferris Committed by android-build-merger
Browse files

Merge "Set groups before dropping privileges." into nyc-dev 

am: fd1eee58

* commit 'fd1eee58':
  Set groups before dropping privileges.

Change-Id: Ic03fd1f589234d4ed32110d8bdce531a55fdf9b7
parents 798ba98d fd1eee58

debuggerd/debuggerd.cpp

+10 −2
Original line number Diff line number Diff line
@@ -513,13 +513,21 @@ static bool perform_dump(const debugger_request_t& request, int fd, int tombston 
}



static bool drop_privileges() {

  // AID_LOG: for reading the logs data associated with the crashing process.

  // AID_READPROC: for reading /proc/<PID>/{comm,cmdline}.

  gid_t groups[] = { AID_DEBUGGERD, AID_LOG, AID_READPROC };

  if (setgroups(sizeof(groups)/sizeof(groups[0]), groups) != 0) {

    ALOGE("debuggerd: failed to setgroups: %s", strerror(errno));

    return false;

  }



  if (setresgid(AID_DEBUGGERD, AID_DEBUGGERD, AID_DEBUGGERD) != 0) {

    ALOGE("debuggerd: failed to setresgid");

    ALOGE("debuggerd: failed to setresgid: %s", strerror(errno));

    return false;

  }



  if (setresuid(AID_DEBUGGERD, AID_DEBUGGERD, AID_DEBUGGERD) != 0) {

    ALOGE("debuggerd: failed to setresuid");

    ALOGE("debuggerd: failed to setresuid: %s", strerror(errno));

    return false;

  }