Commit e02ef9e9 authored Aug 12, 2022 by David Anderson

libsnapshot: Use SnapshotManager to delete devices.

Diagnosing DM_DEV_REMOVE failures in the test harness is quite
difficult, and it's not clear if failures are spurious or not. Instead
use SnapshotManager's helper function, which can retry on failure, and
will self-diagnose issues on legitimate failures.

Bug: N/A
Test: vts_libsnapshot_test
Change-Id: Ibcaa8406e8b1e8758b99a8e9b58c58d68ed57685

parent 60dd4690

fs_mgr/libsnapshot/snapshot_test.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -349,7 +349,7 @@ class SnapshotTest : public ::testing::Test {
		}

		AssertionResult DeleteDevice(const std::string& device) {
		if (!dm_.DeleteDeviceIfExists(device)) {
		if (!sm->DeleteDeviceIfExists(device, 1s)) {
		return AssertionFailure() << "Can't delete " << device;
		}
		return AssertionSuccess();