Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8fdf603 authored by Greg Kaiser's avatar Greg Kaiser
Browse files

fs_mgr: Fix return in error case

We were doing "return -1" in an error case from a function that
returns bool.  Since it's non-zero, this gets implicitly cast to
'true', which almost certainly isn't what we wanted here.

Test: TreeHugger
Change-Id: I76c188c22d907fc425cf4d5b0b1575f640a78ee3
parent 5bc7941b
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1370,7 +1370,7 @@ static bool fs_mgr_unmount_all_data_mounts(const std::string& block_device) {
        Fstab proc_mounts;
        if (!ReadFstabFromFile("/proc/mounts", &proc_mounts)) {
            LERROR << "Can't read /proc/mounts";
            return -1;
            return false;
        }
        // Now proceed with other bind mounts on top of /data.
        for (const auto& entry : proc_mounts) {