Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5b10fc9 authored by Christopher Ferris's avatar Christopher Ferris
Browse files

Skip guest register getting on arm32. 

Currently, there is no support for a guest architecture when running
in an arm 32 bit process. So always return false in that case instead
of spamming the log with useless messages.

Bug: 384944467

Test: debuggerd tests pass with no extraneous error messages.
Change-Id: I8152f1e76031e8b765c4c594b0bbc6800ab60c9e
parent 0cd212cb

debuggerd/crash_dump.cpp

+2 −4
Original line number Original line Diff line number Diff line
@@ -451,10 +451,8 @@ static bool GetGuestRegistersFromCrashedProcess(pid_t tid, NativeBridgeGuestRegs 
    return false;

    return false;

  }

  }

#elif defined(__arm__)

#elif defined(__arm__)

  if (ptrace(PTRACE_GET_THREAD_AREA, tid, nullptr, &base) == 0) {

  // Arm doesn't support any guest architectures yet.

    PLOG(ERROR) << "failed to get thread area for thread " << tid;

  return false;

  return false;

  }

#elif defined(__i386__)

#elif defined(__i386__)

  struct user_regs_struct regs;

  struct user_regs_struct regs;

  struct iovec pt_iov = {.iov_base = &regs, .iov_len = sizeof(regs)};

  struct iovec pt_iov = {.iov_base = &regs, .iov_len = sizeof(regs)};