Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d506e782 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix clang-tidy performance warnings in metricsd/uploader. 

* Use const reference type for parameters to avoid unnecessary copy.

Bug: 30407689
Change-Id: I5e6bfd1cd3bcf54666316573281b79573cd8a780
Test: build with WITH_TIDY=1
parent 02ccdc5d

metricsd/uploader/sender_http.cc

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ 
#include <brillo/http/http_utils.h>

#include <brillo/mime_utils.h>



HttpSender::HttpSender(const std::string server_url)

HttpSender::HttpSender(const std::string& server_url)

    : server_url_(server_url) {}



bool HttpSender::Send(const std::string& content,

metricsd/uploader/sender_http.h

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 
// Sender implemented using http_utils from libbrillo

class HttpSender : public Sender {

 public:

  explicit HttpSender(std::string server_url);

  explicit HttpSender(const std::string& server_url);

  ~HttpSender() override = default;

  // Sends |content| whose SHA1 hash is |hash| to server_url with a synchronous

  // POST request to server_url.