Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d233c275 authored by Colin Cross's avatar Colin Cross
Browse files

Remove obsolete mentions of LLVM_HOST_BUILD_MK

The libbacktrace common flags don't need the flags from
LLVM_HOST_BUILD_MK, they are added directly to libbacktrace_offline.
The -fno-omit-frame-pointer is unnecessary, as we no longer import
flags only used to build LLVM into everything that depends on LLVM.
Removing -Wno-extern-c-compat doesn't cause any warnings.

Test: mma -j
Change-Id: Ia01380e8572c3d84268843291a54ec8c932a327f
parent 3b261ace
Loading
Loading
Loading
Loading
+0 −14
Original line number Diff line number Diff line
@@ -27,22 +27,8 @@ cc_defaults {

    include_dirs: ["external/libunwind/include/tdep"],

    // TODO: LLVM_DEVICE_BUILD_MK
    // TODO: LLVM_HOST_BUILD_MK

    target: {
        host: {
            // -fno-omit-frame-pointer should be set for host build. Because currently
            // libunwind can't recognize .debug_frame using dwarf version 4, and it relies
            // on stack frame pointer to do unwinding on x86.
            // $(LLVM_HOST_BUILD_MK) overwrites -fno-omit-frame-pointer. so the below line
            // must be after the include.
            cflags: [
                "-Wno-extern-c-compat",
                "-fno-omit-frame-pointer",
            ],
        },

        darwin: {
            enabled: false,
        },