Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0192103 authored by Sandro's avatar Sandro
Browse files

Remove /dev/selinux directory creation from first_stage_init.cpp 

Follow-up from aosp/2203897

Bug: 243923977
Test: m and manual verification
Change-Id: I9e41301d2fe4447906253a5c1249dc6c25cd5218
parent 344f7160

init/first_stage_init.cpp

+0 −3
Original line number Diff line number Diff line
@@ -295,9 +295,6 @@ int FirstStageMain(int argc, char** argv) { 
    // stage init

    CHECKCALL(mount("tmpfs", kSecondStageRes, "tmpfs", MS_NOEXEC | MS_NOSUID | MS_NODEV,

                    "mode=0755,uid=0,gid=0"))



    // First stage init stores Mainline sepolicy here.

    CHECKCALL(mkdir("/dev/selinux", 0744));

#undef CHECKCALL



    SetStdioToDevNull(argv);

init/selinux.cpp

+3 −2
Original line number Diff line number Diff line
@@ -525,7 +525,7 @@ const std::vector<std::string> kApexSepolicy{"apex_file_contexts", "apex_propert 
                                             "apex_service_contexts", "apex_seapp_contexts",

                                             "apex_test"};



Result<void> CreateTmpfsDirIfNeeded() {

Result<void> CreateTmpfsDir() {

    mode_t mode = 0744;

    struct stat stat_data;

    if (stat(kTmpfsDir.c_str(), &stat_data) != 0) {
@@ -539,6 +539,7 @@ Result<void> CreateTmpfsDirIfNeeded() { 
        if (!S_ISDIR(stat_data.st_mode)) {

            return Error() << kTmpfsDir << " exists and is not a directory.";

        }

        LOG(WARNING) << "Directory " << kTmpfsDir << " already exists";

    }



    // Need to manually call chmod because mkdir will create a folder with
@@ -593,7 +594,7 @@ Result<void> GetPolicyFromApex(const std::string& dir) { 


    auto handle_guard = android::base::make_scope_guard([&handle] { CloseArchive(handle); });



    auto create = CreateTmpfsDirIfNeeded();

    auto create = CreateTmpfsDir();

    if (!create.ok()) {

        return create.error();

    }