Commit cc9932b2 authored Apr 20, 2022 by Jiyong Park

Fix: null name is added when using android_set_process_profiles

This CL fixes a bug that null names are passed when profiles are set
via android_set_process_profiles. This is because the `profiles_` vector
was initialized with the number of task profiles and then we append the
actual task profile names to the vector. As a result, when {"a", "b"}
was given, the vector ended up having {"", "", "a", "b"}. Fixing this by
correctly using reserve().

Bug: N/A
Test: m
Change-Id: I28d6c2e891b01a2d3a8a88d9d0652fe0dbffac96

parent a18660fb

libprocessgroup/processgroup.cpp

+2 −1

Original line number	Diff line number	Diff line
		@@ -166,7 +166,8 @@ bool SetTaskProfiles(int tid, const std::vector<std::string>& profiles, bool use
		// https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3574427/5/src/linux/android.rs#12
		extern "C" bool android_set_process_profiles(uid_t uid, pid_t pid, size_t num_profiles,
		const char* profiles[]) {
		std::vector<std::string> profiles_(num_profiles);
		std::vector<std::string> profiles_;
		profiles_.reserve(num_profiles);
		for (size_t i = 0; i < num_profiles; i++) {
		profiles_.emplace_back(profiles[i]);
		}