Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5c6d7d3 authored by Tom Cherry's avatar Tom Cherry
Browse files

Don't include log/log_read.h in log/log.h 

log/log.h primarily concerns itself with writing logs.  The few users
who read logs should directly include log/log_read.h.

Bug: 78370064
Test: build
Change-Id: Ie95c55ea2ffc76fc95768323d445ada6ad4f2520
parent 10f8f5e3

debuggerd/libdebuggerd/tombstone.cpp

+1 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ 
#include <android-base/unique_fd.h>

#include <android/log.h>

#include <log/log.h>

#include <log/log_read.h>

#include <log/logprint.h>

#include <private/android_filesystem_config.h>

#include <unwindstack/DexFiles.h>

liblog/include/log/log.h

+7 −1
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ 
#include <log/log_id.h>

#include <log/log_main.h>

#include <log/log_radio.h>

#include <log/log_read.h>

#include <log/log_safetynet.h>

#include <log/log_system.h>

#include <log/log_time.h>
@@ -64,6 +63,13 @@ extern "C" { 
#endif

#endif



/*

 * The maximum size of the log entry payload that can be

 * written to the logger. An attempt to write more than

 * this amount will result in a truncated log entry.

 */

#define LOGGER_ENTRY_MAX_PAYLOAD 4068



/*

 * Event logging.

 */

liblog/include/log/log_read.h

+0 −7
Original line number Diff line number Diff line
@@ -47,13 +47,6 @@ struct logger_entry { 
  uint32_t uid;      /* generating process's uid */

};



/*

 * The maximum size of the log entry payload that can be

 * written to the logger. An attempt to write more than

 * this amount will result in a truncated log entry.

 */

#define LOGGER_ENTRY_MAX_PAYLOAD 4068



/*

 * The maximum size of a log entry which can be read.

 * An attempt to read less than this amount may result

liblog/logprint.cpp

+3 −1
Original line number Diff line number Diff line
@@ -19,6 +19,8 @@ 
#define HAVE_STRSEP

#endif



#include <log/logprint.h>



#include <assert.h>

#include <ctype.h>

#include <errno.h>
@@ -37,7 +39,7 @@ 
#include <cutils/list.h>



#include <log/log.h>

#include <log/logprint.h>

#include <log/log_read.h>

#include <private/android_logger.h>



#define MS_PER_NSEC 1000000

liblog/tests/liblog_benchmark.cpp

+1 −0
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ 
#include <benchmark/benchmark.h>

#include <cutils/sockets.h>

#include <log/event_tag_map.h>

#include <log/log_read.h>

#include <private/android_logger.h>



BENCHMARK_MAIN();