Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2c5a241 authored by Nick Kralevich's avatar Nick Kralevich
Browse files

property_service: address comments from previous review. 

Address post-submit comments from
69463614

Bug: 10733330
Change-Id: I7c652f7ef0379536df48b9478a2362f1bfd252fe
parent db3f6ef8

init/property_service.c

+2 −4
Original line number Diff line number Diff line
@@ -281,7 +281,6 @@ static void write_persistent_property(const char *name, const char *value) 
static bool is_legal_property_name(const char* name, size_t namelen)

{

    size_t i;

    bool previous_was_dot = false;

    if (namelen >= PROP_NAME_MAX) return false;

    if (namelen < 1) return false;

    if (name[0] == '.') return false;
@@ -291,11 +290,10 @@ static bool is_legal_property_name(const char* name, size_t namelen) 
    /* Don't allow ".." to appear in a property name */

    for (i = 0; i < namelen; i++) {

        if (name[i] == '.') {

            if (previous_was_dot == true) return false;

            previous_was_dot = true;

            // i=0 is guaranteed to never have a dot. See above.

            if (name[i-1] == '.') return false;

            continue;

        }

        previous_was_dot = false;

        if (name[i] == '_' || name[i] == '-') continue;

        if (name[i] >= 'a' && name[i] <= 'z') continue;

        if (name[i] >= 'A' && name[i] <= 'Z') continue;