Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit befa79d7 authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

logcatd: Do not su for setprop 

(cherry pick from commit 8d2a6557)

sepolicy now permits setting persist.logd.logpersistd in shell

Bug: 28788401
Bug: 28813587
Bug: 28936216
Change-Id: Ieed50eae0f91afa5b0c0e4ade7a71922c4b7ef93
parent 7545b471

logcat/logpersist

+7 −7
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ case ${progname} in 
  if [ "${service}" = "`getprop ${property}`" ]; then

    if [ "true" = "${clear}" ]; then

      su root stop ${service}

      su root setprop ${property} ""

      setprop ${property} ""

      # 20ms done, guarantees content stop before rm

      sleep 1

    elif [ "${buffer}|${size}" != "${current_buffer}|${current_size}" ]; then
@@ -103,13 +103,13 @@ case ${progname} in 
    su logd,misc rm -rf "${data}"

  fi

  if [ -n "${buffer}${current_buffer}" ]; then

    su root setprop ${property}.buffer "${buffer}"

    setprop ${property}.buffer "${buffer}"

  fi

  if [ -n "${size}${current_size}" ]; then

    su root setprop ${property}.size "${size}"

    setprop ${property}.size "${size}"

  fi

  # ${service}.rc does the heavy lifting with the following trigger

  su root setprop ${property} ${service}

  setprop ${property} ${service}

  getprop ${property}

  # 20ms done, to permit process feedback check

  sleep 1
@@ -121,12 +121,12 @@ case ${progname} in 
    echo "WARNING: Can not use --size or --buffer with ${progname%.*}.stop" >&2

  fi

  su root stop ${service}

  su root setprop ${property} ""

  setprop ${property} ""

  if [ -n "`getprop ${property}.buffer`" ]; then

    su root setprop ${property}.buffer ""

    setprop ${property}.buffer ""

  fi

  if [ -n "`getprop ${property}.size`" ]; then

    su root setprop ${property}.size ""

    setprop ${property}.size ""

  fi

  if [ "true" = "${clear}" ]; then

    # 20ms done, guarantees content stop before rm