Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be0c1af6 authored by Josh Gao's avatar Josh Gao
Browse files

debuggerd_client: improve error logging. 

system_server is sometimes failing to dump with the following error:

    libdebuggerd_client: received packet of unexpected length from tombstoned: expected 128, received -1

Improve the logging to try to figure out what's going on.

Bug: http://b/114139908
Test: treehugger
Change-Id: Iee1bdc0891b9fc7bd80a330495ec22a530febddb
parent ebb631b0

debuggerd/client/debuggerd_client.cpp

+16 −8
Original line number Diff line number Diff line
@@ -143,11 +143,15 @@ bool debuggerd_trigger_dump(pid_t pid, DebuggerdDumpType dump_type, unsigned int 
  ssize_t rc =

      TEMP_FAILURE_RETRY(recv(set_timeout(sockfd.get()), &response, sizeof(response), MSG_TRUNC));

  if (rc == 0) {

    LOG(ERROR) << "libdebuggerd_client: failed to read response from tombstoned: timeout reached?";

    LOG(ERROR) << "libdebuggerd_client: failed to read initial response from tombstoned: "

               << "timeout reached?";

    return false;

  } else if (rc == -1) {

    PLOG(ERROR) << "libdebuggerd_client: failed to read initial response from tombstoned";

    return false;

  } else if (rc != sizeof(response)) {

    LOG(ERROR)

        << "libdebuggerd_client: received packet of unexpected length from tombstoned: expected "

    LOG(ERROR) << "libdebuggerd_client: received packet of unexpected length from tombstoned while "

                  "reading initial response: expected "

               << sizeof(response) << ", received " << rc;

    return false;

  }
@@ -164,11 +168,15 @@ bool debuggerd_trigger_dump(pid_t pid, DebuggerdDumpType dump_type, unsigned int 


  rc = TEMP_FAILURE_RETRY(recv(set_timeout(sockfd.get()), &response, sizeof(response), MSG_TRUNC));

  if (rc == 0) {

    LOG(ERROR) << "libdebuggerd_client: failed to read response from tombstoned: timeout reached?";

    LOG(ERROR) << "libdebuggerd_client: failed to read status response from tombstoned: "

                  "timeout reached?";

    return false;

  } else if (rc == -1) {

    PLOG(ERROR) << "libdebuggerd_client: failed to read status response from tombstoned";

    return false;

  } else if (rc != sizeof(response)) {

    LOG(ERROR)

      << "libdebuggerd_client: received packet of unexpected length from tombstoned: expected "

    LOG(ERROR) << "libdebuggerd_client: received packet of unexpected length from tombstoned while "

                  "reading confirmation response: expected "

               << sizeof(response) << ", received " << rc;

    return false;

  }