Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc64e50b authored by Tom Cherry's avatar Tom Cherry
Browse files

Assert that ParseInt/ParseUint are only used with signed/unsigned numbers respectively 

Test: build fails when the signedness is mismatched
Test: build succeeds otherwise
Change-Id: Idd6b146cc167d4607eafc81dbad6c2a79b167094
parent e0bc5a9a

base/include/android-base/parseint.h

+3 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 


#include <limits>

#include <string>

#include <type_traits>



namespace android {

namespace base {
@@ -33,6 +34,7 @@ namespace base { 
template <typename T>

bool ParseUint(const char* s, T* out, T max = std::numeric_limits<T>::max(),

               bool allow_suffixes = false) {

  static_assert(std::is_unsigned<T>::value, "ParseUint can only be used with unsigned types");

  while (isspace(*s)) {

    s++;

  }
@@ -96,6 +98,7 @@ template <typename T> 
bool ParseInt(const char* s, T* out,

              T min = std::numeric_limits<T>::min(),

              T max = std::numeric_limits<T>::max()) {

  static_assert(std::is_signed<T>::value, "ParseInt can only be used with signed types");

  while (isspace(*s)) {

    s++;

  }