Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb578203 authored by Howard Yen's avatar Howard Yen
Browse files

init: prevent persist.sys.usb.config initalized as none,adb 

Prevent appending ",adb" to persist.sys.usb.config if "none" is
explicitly defined in default prop.

Bug: 150130503
Test: persist.sys.usb.config initalized correctly
Change-Id: I3b5de6fd102e252019e843f39f0875f5aaea7486
Merged-In: I3b5de6fd102e252019e843f39f0875f5aaea7486
parent 154bd7e0

init/property_service.cpp

+3 −1
Original line number Diff line number Diff line
@@ -813,7 +813,9 @@ static bool load_properties_from_file(const char* filename, const char* filter, 
static void update_sys_usb_config() {

    bool is_debuggable = android::base::GetBoolProperty("ro.debuggable", false);

    std::string config = android::base::GetProperty("persist.sys.usb.config", "");

    if (config.empty()) {

    // b/150130503, add (config == "none") condition here to prevent appending

    // ",adb" if "none" is explicitly defined in default prop.

    if (config.empty() || config == "none") {

        InitPropertySet("persist.sys.usb.config", is_debuggable ? "adb" : "none");

    } else if (is_debuggable && config.find("adb") == std::string::npos &&

               config.length() + 4 < PROP_VALUE_MAX) {