Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9add4a3 authored by Maciej Żenczykowski's avatar Maciej Żenczykowski
Browse files

libnetutils/packet.c - fix a socket leak on bind error 



and clean up the code a little bit while at it.

Test: builds, atest
Bug: 155297277
Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
Change-Id: I01a10e36f852cde1b93a91f95b51294a434885ab
Merged-In: I01a10e36f852cde1b93a91f95b51294a434885ab
parent b7974313

libnetutils/packet.c

+13 −16
Original line number Diff line number Diff line
@@ -37,25 +37,22 @@ 


#include "dhcpmsg.h"



int fatal();



int open_raw_socket(const char *ifname __attribute__((unused)), uint8_t *hwaddr, int if_index)

{

    int s;

    struct sockaddr_ll bindaddr;



    if((s = socket(PF_PACKET, SOCK_DGRAM, htons(ETH_P_IP))) < 0) {

        return fatal("socket(PF_PACKET)");

    }



    memset(&bindaddr, 0, sizeof(bindaddr));

    bindaddr.sll_family = AF_PACKET;

    bindaddr.sll_protocol = htons(ETH_P_IP);

    bindaddr.sll_halen = ETH_ALEN;

int fatal(const char*);



int open_raw_socket(const char* ifname __unused, uint8_t hwaddr[ETH_ALEN], int if_index) {

    int s = socket(PF_PACKET, SOCK_DGRAM, htons(ETH_P_IP));

    if (s < 0) return fatal("socket(PF_PACKET)");



    struct sockaddr_ll bindaddr = {

            .sll_family = AF_PACKET,

            .sll_protocol = htons(ETH_P_IP),

            .sll_ifindex = if_index,

            .sll_halen = ETH_ALEN,

    };

    memcpy(bindaddr.sll_addr, hwaddr, ETH_ALEN);

    bindaddr.sll_ifindex = if_index;



    if (bind(s, (struct sockaddr *)&bindaddr, sizeof(bindaddr)) < 0) {

        close(s);

        return fatal("Cannot bind raw socket to interface");

    }

libnetutils/packet.h

+3 −1
Original line number Diff line number Diff line
@@ -17,7 +17,9 @@ 
#ifndef _WIFI_PACKET_H_

#define _WIFI_PACKET_H_



int open_raw_socket(const char *ifname, uint8_t *hwaddr, int if_index);

#include <linux/if_ether.h>



int open_raw_socket(const char* ifname, uint8_t hwaddr[ETH_ALEN], int if_index);

int send_packet(int s, int if_index, struct dhcp_msg *msg, int size,

                uint32_t saddr, uint32_t daddr, uint32_t sport, uint32_t dport);

int receive_packet(int s, struct dhcp_msg *msg);