Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6c60285 authored by Colin Cross's avatar Colin Cross Committed by Gerrit Code Review
Browse files

Merge changes Ieb94caab,I762da21e

* changes:
  init: move initial property area allocation into bionic
  property_service: make /dev/__properties__ readable
parents 83ada447 2baad525
Loading
Loading
Loading
Loading
+5 −30
Original line number Diff line number Diff line
@@ -110,7 +110,6 @@ struct {
};

typedef struct {
    void *data;
    size_t size;
    int fd;
} workspace;
@@ -118,38 +117,13 @@ typedef struct {
static int init_workspace(workspace *w, size_t size)
{
    void *data;
    int fd;

        /* dev is a tmpfs that we can use to carve a shared workspace
         * out of, so let's do that...
         */
    fd = open("/dev/__properties__", O_RDWR | O_CREAT | O_NOFOLLOW, 0600);
    if (fd < 0)
        return -1;

    if (ftruncate(fd, size) < 0)
        goto out;

    data = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
    if(data == MAP_FAILED)
        goto out;

    close(fd);

    fd = open("/dev/__properties__", O_RDONLY | O_NOFOLLOW);
    int fd = open(PROP_FILENAME, O_RDONLY | O_NOFOLLOW);
    if (fd < 0)
        return -1;

    unlink("/dev/__properties__");

    w->data = data;
    w->size = size;
    w->fd = fd;
    return 0;

out:
    close(fd);
    return -1;
}

static workspace pa_workspace;
@@ -159,12 +133,13 @@ static int init_property_area(void)
    if (property_area_inited)
        return -1;

    if(init_workspace(&pa_workspace, PA_SIZE))
    if(__system_property_area_init())
        return -1;

    fcntl(pa_workspace.fd, F_SETFD, FD_CLOEXEC);
    if(init_workspace(&pa_workspace, 0))
        return -1;

    __system_property_area_init(pa_workspace.data);
    fcntl(pa_workspace.fd, F_SETFD, FD_CLOEXEC);

    property_area_inited = 1;
    return 0;