Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b60befa8 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

riscv64: minor ASLR bits changes. 

Improve the comment, and increase the "minimum maximum" to 24 --- we
only support 64-bit, and 64-bit never has less than 24 bits.

Bug: https://github.com/google/android-riscv64/issues/1
Test: treehugger
Change-Id: I478c7649aa19258352c908a449cabe12da94952c
parent 720007ba

init/security.cpp

+4 −4
Original line number Diff line number Diff line
@@ -117,10 +117,10 @@ Result<void> SetMmapRndBitsAction(const BuiltinArguments&) { 
        return {};

    }

#elif defined(__riscv)

    // TODO: sv48 and sv57 were both added to the kernel this year, so we

    // probably just need some kernel fixes to enable higher ASLR randomization,

    // but for now 24 is the maximum that the kernel supports.

    if (SetMmapRndBitsMin(24, 18, false)) {

    // TODO: sv48 and sv57 have both been added to the kernel, but the kernel

    // still doesn't support more than 24 bits.

    // https://github.com/google/android-riscv64/issues/1

    if (SetMmapRndBitsMin(24, 24, false)) {

        return {};

    }

#elif defined(__x86_64__)