Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3302584 authored by Jiyong Park's avatar Jiyong Park
Browse files

Use no_full_install: true instead of installable: false

So far, we have used `instalable: false` to avoid collision with the
other modules that are installed to the same path. A typical example was
<foo> and <foo>.microdroid. The latter is a modified version of the
former for the inclusion of the microdroid image. They however both have
the same instalation path (ex: system/bin) and stem (ex: foo) so that we
can reference them using the same path regardless of whether we are in
Android or microdroid.

However, the use of `installable: false` for the purpose is actually
incorrect, because `installable: false` also means, obviously, "this
module shouldn't be installed". The only reason this incorrect way has
worked is simply because packaging modules (ex: android_filesystem)
didn't respect the property when gathering the modules.

As packaging modules are now fixed to respect `installable: false`, we
need a correct way of avoiding the collision. `no_full_install: true` is
it.

If a module has this property set to true, it is never installed to the
full instal path like out/target/product/<partition>/... It can be
installed only via packaging modules.

Bug: 338160898
Test: m
Change-Id: I37380c19232f2c497bdf492a83cdc16616f0ae8d
parent 2026332e
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -330,7 +330,7 @@ cc_binary {
    recovery_available: false,
    static_libs: ["libinit.microdroid"],
    cflags: ["-DMICRODROID=1"],
    installable: false,
    no_full_install: true,
    visibility: ["//packages/modules/Virtualization/microdroid"],
}

@@ -480,7 +480,7 @@ cc_binary {
        "init_first_stage_defaults",
    ],
    cflags: ["-DMICRODROID=1"],
    installable: false,
    no_full_install: true,
}

phony {