Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2de4db9 authored by Dan Murphy's avatar Dan Murphy Committed by Mike Lockwood
Browse files

fastboot: Add retry to USB read call. 



If the USB connection to the device is reset but is still there
the code should retry to re-connect the device and continue.

This is a short term fix for a bootloader issue.
We should revisit and look for a better solution.

Signed-off-by: default avatarDan Murphy <D.Murphy@motorola.com>
Signed-off-by: default avatarMike Lockwood <lockwood@android.com>
parent 761aeb43

fastboot/usb_linux.c

+17 −11
Original line number Diff line number Diff line
@@ -51,7 +51,9 @@ 


#include "usb.h"



#if TRACE_USB

#define MAX_RETRIES 5



#ifdef TRACE_USB

#define DBG1(x...) fprintf(stderr, x)

#define DBG(x...) fprintf(stderr, x)

#else
@@ -303,7 +305,7 @@ int usb_read(usb_handle *h, void *_data, int len) 
    unsigned char *data = (unsigned char*) _data;

    unsigned count = 0;

    struct usbdevfs_bulktransfer bulk;

    int n;

    int n, retry;



    if(h->ep_in == 0) {

        return -1;
@@ -316,16 +318,20 @@ int usb_read(usb_handle *h, void *_data, int len) 
        bulk.len = xfer;

        bulk.data = data;

        bulk.timeout = 0;

        retry = 0;



        do{

           DBG("[ usb read %d fd = %d], fname=%s\n", xfer, h->desc, h->fname);

           n = ioctl(h->desc, USBDEVFS_BULK, &bulk);

        DBG("[ usb read %d ] = %d, fname=%s\n", xfer, n, h->fname);

           DBG("[ usb read %d ] = %d, fname=%s, Retry %d \n", xfer, n, h->fname, retry);



           if( n < 0 ) {

            DBG1("ERROR: n = %d, errno = %d (%s)\n",

                n, errno, strerror(errno));

            return -1;

            DBG1("ERROR: n = %d, errno = %d (%s)\n",n, errno, strerror(errno));

            if ( ++retry > MAX_RETRIES ) return -1;

            sleep( 1 );

           }

        }

        while( n < 0 );



        count += n;

        len -= n;